Discontinued support for Justoverclock

Justman10000

I am announcing the end of my support for Justoverclock...

After my PRs were closed 3 times without comment and I got locked from all his Github repositories, I decided to stop supporting him... Maybe you (@Justoverclock) can explain to me here what the dirt was should...

luceos

I actually replied to one of your PR's previously to point out what I think you can improve.

A few pointers for doing better prs:

remain civil, maintainers invest a lot of time into their open source repositories.
open an issue or discuss privately whether new features are wanted and how the maintainer would implement it to reduce reviewing time and iterations
a PR should be ready to be merged when opened, or given a subject of WIP in case it's not done. WIP prs are usually only tolerated in case the maintainer agrees to one
a PR opened with the intent of the maintainer having to complete it, will never be a good thing
sorting files, lists and code formatting usually is frowned upon because there is hardly a benefit and it costs a massive amount to review
do not bundle multiple different changes into one pr, unless requested
don't expect your PR to be merged, the maintainer - in the end - takes full responsibility over maintaining whatever you contributed.
if you don't like the changes made by a maintainer or want to introduce changes the maintainer doesn't like to accept, just fork the code and maintain your own version; make sure to give credit and publish with your own name and ways to provide support
being disappointed about a PR being closed is okay, but getting angry at a maintainer who took the time to review isn't.

Thanks for reading. I hope this helps for the future.

Justoverclock

well, i do not want to spend too much time in this discussion, but, just one thing....

reason for ban:

i have no word for this...specially because since my first day here at Flarum, i'm trying to improve myself to release free extension and features for the entire community.....

if you don't like my approach is ok.....but be respectful....always

jordanjay29

I'm closing this thread as it seems like the question was answered, and some recommendations were offered.

From time to time, there will be disagreements and interpersonal issues, that's common to any community. It's usually better to reach out in private first, and barring that, ensuring that the discussion meets our Community Guidelines.

Calling out a member of the community or staff generally leads to worse feelings. This discussion hasn't gotten there yet, but I'm closing it before it does.