I believe we will have to change it at some point. I don't think the users will remain suspended past that date.
Since we use a single column to store the suspension status and since it was made a date column, we don't have any good way of storing "infinite" without adding a second column. The solution chosen was to store a date far into the future.
I am guessing the reason we use January 2038 as the date must be because the suspension date was stored as
TIMESTAMP at some point in the past, which has a maximum value of
But we have now been using
DATETIME to store this value for a long time, so I don't think this technical limitation exists anymore. Now this is probably just a leftover from the early versions of Flarum.
We still have a few more years to decide what to do 😇