Creation date of posts sometimes missing in Mentions page

matteocontrini

Hello,

I've noticed that in the "Mentions" page of (at least) a user of my forum the creation date of posts is missing, starting from the second post. It's shown as "NaN years ago".

https://forum.fibra.click/u/gregorst/mentions

The problem is that the creation date is returned as null:

Additionally, the user himself cannot see the page because of an exception thrown when evaluating the post edit policy (the user mentioned himself in a post appearing in that page so the policy is invoked):

[2022-08-26 21:04:31] flarum.ERROR: Error: Call to a member function diffInMinutes() on null in /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Post/Access/PostPolicy.php:61
Stack trace:
#0 [internal function]: Flarum\Post\Access\PostPolicy->edit()
#1 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/User/Access/AbstractPolicy.php(52): call_user_func_array()
#2 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/User/Access/Gate.php(78): Flarum\User\Access\AbstractPolicy->checkAbility()
#3 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/User/User.php(785): Flarum\User\Access\Gate->allows()
#4 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Api/Serializer/PostSerializer.php(25): Flarum\User\User->can()
#5 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Api/Serializer/AbstractSerializer.php(88): Flarum\Api\Serializer\PostSerializer->getDefaultAttributes()
#6 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/sycho/json-api/src/Resource.php(183): Flarum\Api\Serializer\AbstractSerializer->getAttributes()
#7 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/sycho/json-api/src/Resource.php(81): Tobscure\JsonApi\Resource->getAttributes()
#8 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/sycho/json-api/src/Collection.php(113): Tobscure\JsonApi\Resource->toArray()
#9 [internal function]: Tobscure\JsonApi\Collection->Tobscure\JsonApi\{closure}()
#10 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/sycho/json-api/src/Collection.php(114): array_map()
#11 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/sycho/json-api/src/Document.php(188): Tobscure\JsonApi\Collection->toArray()
#12 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/sycho/json-api/src/Document.php(232): Tobscure\JsonApi\Document->toArray()
#13 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Api/JsonApiResponse.php(27): Tobscure\JsonApi\Document->jsonSerialize()
#14 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(134): Flarum\Api\JsonApiResponse->__construct()
#15 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle()
#16 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#17 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ExecuteRoute->process()
#18 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/kilowhat/flarum-ext-audit-pro/src/Middlewares/ExtendSetPermissionController.php(19): Laminas\Stratigility\Next->handle()
#19 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Kilowhat\Audit\Middlewares\ExtendSetPermissionController->process()
#20 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/kilowhat/flarum-ext-audit-pro/src/Middlewares/SetLoggerActor.php(28): Laminas\Stratigility\Next->handle()
#21 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Kilowhat\Audit\Middlewares\SetLoggerActor->process()
#22 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle()
#23 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\ThrottleApi->process()
#24 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle()
#25 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\CheckCsrfToken->process()
#26 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle()
#27 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ResolveRoute->process()
#28 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#29 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\SetLocale->process()
#30 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Laminas\Stratigility\Next->handle()
#31 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithHeader->process()
#32 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/fibraclick/flarum-tweaks/src/Middlewares/AuthHeaderMiddleware.php(17): Laminas\Stratigility\Next->handle()
#33 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): FibraClick\Middlewares\AuthHeaderMiddleware->process()
#34 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle()
#35 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithSession->process()
#36 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle()
#37 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\RememberFromCookie->process()
#38 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#39 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\StartSession->process()
#40 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle()
#41 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\FakeHttpMethods->process()
#42 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#43 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ParseJsonBody->process()
#44 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#45 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\HandleErrors->process()
#46 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle()
#47 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\InjectActorReference->process()
#48 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#49 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#50 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\RequestHandler->process()
#51 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle()
#52 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePathRouter->process()
#53 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle()
#54 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Laminas\Stratigility\Middleware\OriginalMessages->process()
#55 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle()
#56 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePath->process()
#57 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle()
#58 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ProcessIp->process()
#59 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#60 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(64): Laminas\Stratigility\MiddlewarePipe->process()
#61 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle()
#62 /usr/local/openresty/nginx/www/fibraclick-forum/vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#63 /usr/local/openresty/nginx/www/fibraclick-forum/public/index.php(22): Flarum\Http\Server->listen()
#64 {main}

The stack trace should give all the information to understand whether an extension is involved. Also, I've checked the posts in the database and the created_at values are actually there.

I have no idea of how to reproduce the issue so I'm posting here before creating an issue on GitHub.

Any clue? Thanks!

clarkwinkelmann

matteocontrini can you check if there are any NULL values for created_at in post_mentions_user table?

I see the mentioned post filter joins the post_mentions_user table onto the posts query. Maybe the post model pulls the wrong created_at from the results? I believe most recent MySQL errors would throw an error if it was happening though, so not sure...

https://github.com/flarum/framework/blob/v1.4.0/extensions/mentions/src/Filter/MentionedFilter.php#L28

Or maybe another table joined by another extension in a global filter or a visibility scope.

matteocontrini

clarkwinkelmann that's it indeed, almost all created_at values are NULL in the post_mentions_user table. Starting from a few weeks ago the value is populated, since this is a change introduced in 1.4.0 flarum/framework3435

Then it's probably the join's fault that's taking the "wrong" column. I'm seeing this issue on Discuss too.

Should I open an issue on GitHub? Or do you want do it yourself (you probably can describe the issue better than me)? Thanks!

SychO

flarum/framework3621

matteocontrini

SychO thanks!

matteocontrini

Related to this problem: the created_at timestamp for mentions is stored as UTC in the database (timestamp type) but retrieved in a local timezone depending on MySQL's configuration. It appears that Flarum is then applying the timezone offset again so if I'm in UTC+2 I see the times in Flarum's mentions page as if they were UTC+4.

I guess this isn't going to be a problem anymore after the next update, but I'm still bringing it to dev's attention. I'm not sure if there are other parts of the code affected by this.

SychO

matteocontrini it's because that field was never meant to be used in flarum's frontend so it's not even specified in the model's date attributes so it's not auto converted to the proper timezone.