Byobu upgrade Past 1.0 without install the FOF extension

thomasarnold81

The issue

I have upgraded past v1.0 without upgrading my Byobu extension to FOF/Byobu.

Now, although the upgrade has worked from a console point of view, the extension won't activate on my test instance.

I try to enable and it just fails.

And yet it's not there in my php info.

Unless I'm the only person stupid enough to not read the upgrade questions I'm guessing this has been resolved before? I just can't see a good candidate in the search results.

Many thanks.

Flarum information

Flarum core 1.4.1
PHP version: 7.4.30
MySQL version: 10.5.16-MariaDB-cll-lve
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bz2, calendar, ctype, curl, hash, filter, ftp, gettext, gmp, SPL, iconv, pcntl, readline, Reflection, session, standard, shmop, SimpleXML, mbstring, tokenizer, xml, i360, bcmath, dom, fileinfo, gd, imap, json, exif, mysqli, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, sockets, xmlreader, xmlwriter, xsl, zip, ionCube Loader
+-------------------------------------+---------+--------+
| Flarum Extensions                   |         |        |
+-------------------------------------+---------+--------+
| ID                                  | Version | Commit |
+-------------------------------------+---------+--------+
| flarum-flags                        | v1.4.0  |        |
| flarum-markdown                     | v1.4.0  |        |
| flarum-suspend                      | v1.4.0  |        |
| flarum-approval                     | v1.4.0  |        |
| ralkage-hcaptcha                    | 1.0.0   |        |
| ozzzzam-autoimage                   | 1.1.0   |        |
| matteocontrini-imgur-upload         | v3.9.1  |        |
| fof-user-directory                  | 1.2.3   |        |
| fof-spamblock                       | 1.0.2   |        |
| fof-reactions                       | 1.1.2   |        |
| fof-pages                           | 1.0.4   |        |
| fof-links                           | 1.1.1   |        |
| fof-linguist                        | 1.0.4   |        |
| fof-formatting                      | 1.0.2   |        |
| flarum-tags                         | v1.4.0  |        |
| flarum-subscriptions                | v1.4.0  |        |
| flarum-sticky                       | v1.4.0  |        |
| flarum-statistics                   | v1.4.1  |        |
| flarum-pusher                       | v1.4.0  |        |
| flarum-mentions                     | v1.4.0  |        |
| flarum-lock                         | v1.4.0  |        |
| flarum-likes                        | v1.4.0  |        |
| flarum-lang-english                 | v1.4.0  |        |
| flarum-bbcode                       | v1.4.0  |        |
| clarkwinkelmann-first-post-approval | 1.0.1   |        |
| clarkwinkelmann-emojionearea        | 1.0.0   |        |
| antoinefr-online                    | v1.0.1  |        |
+-------------------------------------+---------+--------+
Base URL: https://www.onemickjones.com
Installation path: /home/onemickjones/public_html/forum3
Queue driver: sync
Mail driver: mail
Debug mode: off

luceos

thomasarnold81 Now, although the upgrade has worked from a console point of view, the extension won't activate on my test instance.

I try to enable and it just fails.

Have you seen any errors in Flarum's logs under storage/logs?

thomasarnold81

Doh.

Sorry for the obvious poor knowledge on basic trouble shooting.

I'll remember that.

I guess this isn't ideal:

[2022-09-12 07:21:26] flarum.ERROR: PDOException: SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'blocks_byobu_pd' in /home/onemickjones/public_html/forum3/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:117
Stack trace:

luceos

thomasarnold81 Sorry for the obvious poor knowledge on basic trouble shooting.

No problem, you provided quite a bunch in your OP already 😉

Something must have gone wrong, either while running any of the migrations for Byobu or during a previous upgrade. Depending on the state of your community and the use of Byobu therein you have a few options.

you can delete the column blocks_byobu_pd in the users table, but this will reset this setting for everyone
you can insert the migration that adds the column in your migrations table, migration: 2019_07_08_000000_add_blocks_pd_to_users, extension fof-byobu

Regardless of your choice any next migration might fail too. Best to run long running migrations and upgrades is from the terminal/cli, because the web request can time out and kill processing migrations. Use php flarum migrate to run outstanding migrations.

thomasarnold81

Well I have some progress but it now wants the indexes removing one by one removing from the Recipients table.

I guess this could get ugly?

thomasarnold81

Does a composer remove fof/byobu really take away everything completely so you can start from afresh?

luceos

thomasarnold81 it does not, you would need to disable the extension and then purge from the admin area. The question there is whether all removal migrations have been properly configured, there's currently - sadly - no guarantee. I'm a bit confused why your database got so messed up, did you run the web based upgrade screen at some point?

thomasarnold81

luceos I'm a bit confused why your database got so messed up, did you run the web based upgrade screen at some point?

This is the bit that gets me.

No I didn't run any web based updates. All CLI via Kitty for now.

The crazy thing is my test was a complete copy of live. I've carefully switched every item on in test, then prod. It's all working in test after I dropped block_byobu_pd.

It's only prod that now wants these further indexes removing.

Very strange. Clearly I've not completely followed process on both sides.

clarkwinkelmann

If the FoF version of the extension had never been installed before, you could potentially rename all entries in the database table migrations. Every line where column extension is flagrow-byobu, edit that column to say fof-byobu

But that might not work if you have already tried enabling the new FoF extension, because some entries will already exist.

You could try renaming all those that don't already exist (ignore each one where it errors saying an entry already exists with the same name) and it might work.

Make sure to create a database backup before trying any manipulation so you have a previous point to re-try from if things get even more broken after the attempt.

thomasarnold81

OK fixed.

I uninstalled fof/byobu without purging (I wanted to keep the old messages if I could)
Strangely I saw flagrow/byobu reinstall
I then uninstalled flagrow/byobu too
I manually removed every index that was showing in the error log
I had to leave the core index for the main key
Reinstalled fof/byobu

All back to normal with my old messages now back.