about redraw Component

jinber

i added custom Component on page, this is my code:

class PostUnion extends Component {
  oninit(vnode) {
    super.oninit(vnode);
    this.count = 1
  }

  increment() {
    console.log('click')
    this.count++
    m.redraw();
  }

  view() {
    return (<div>
      Count: {this.count}
      <button onclick={this.increment.bind(this)}>
        click
      </button>
    </div>);
  }
}

now, i clicked button,i can see console output 'click', but the view function count not redraw,can some one tell me why and how to make right?thank you

clarkwinkelmann

jinber where is your component inserted? Flarum has special logic in the discussion list and post stream that reduces the number of redraws to improve performance. In those places a Subtree Retainer object is used with a series of callback that determines if the children of the parent component should be rendered again. If you share your code that inserts the component we could suggest the code required to modify the Subtree Renderer.

Also, whenever you use a Mithril event listener like onclick, Mithril already calls m.redraw() after the callback is executed, so you don't need to call m.redraw() manually unless your code is asynchronous.