Sign in with LINE

opencart

about android login with line
after line login succes, page not auto reload ...
.
because line login redirect page url to auth ...
it's make window.opener is null
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Opener-Policy
.
so ... ResponseFactory.php ... authenticationComplete not work
window.opener.app.authenticationComplete(%s);
.
I add cookieStore.addEventListener

<script>
cookieStore.addEventListener("change", (event) => {
  window.location.reload();
});
</script>

.
then edit ResponseFactory.php (cookieStore.set)

private function makeResponse(array $payload): HtmlResponse
{
    $content = sprintf(
        '
        <script>
        window.close(); 
        cookieStore.set({name: "isLogin",  value: "yes"});
        window.opener.app.authenticationComplete(%s);
        </script>
        ',
        json_encode($payload)
    );
    return new HtmlResponse($content);
}

.
I'm not a programmer, just googled, pieced together the code, if there is a better solution, please let me know
.
change event not support firefox & safari (but they support window.opener)
https://developer.mozilla.org/en-US/docs/Web/API/CookieStore/change_event#browser_compatibility
.
many thanks for IanM

clarkwinkelmann

opencart maybe this could also be used to fix the issue https://github.com/clarkwinkelmann/flarum-ext-auth-popup-failsafe

I don't think I created a discussion for that extension on the forum yet.

Subarist

opencart I add cookieStore.addEventListenerwindow.openerwindow.opener.app.authenticationComplete(%s);
<script>
cookieStore.addEventListener("change", (event) => {
window.location.reload();
});
</script>

Will this be added to the Custom Footer?
I get infinite reload ^^

opencart

https://your.flarum.url/admin#/appearance
edit custom header

<script>
cookieStore.onchange = function(event) {
    if (event.changed.some(cookie => cookie.name === "isLogin")) {
        console.log("isLogin cookie has changed!");
        window.location.reload();
    }
};
</script>

.
then edit ResponseFactory.php
path: vendor/flarum/core/src/Forum/Auth

private function makeResponse(array $payload): HtmlResponse
{
    $content = sprintf(
        '
        <script>
        window.close(); 
        const timestamp = new Date().getTime();
        cookieStore.set({name: "isLogin", value: timestamp.toString()});
        window.opener.app.authenticationComplete(%s);
        </script>
        ',
        json_encode($payload)
    );
    return new HtmlResponse($content);
}

.
my flarum work, you can try on android phone
https://opencart.cc

Subarist

opencart
Error reported on https://opencart.cc

opencart

Subarist Because I am changing layout of the login 🤣
I put the button of line login at the bottom

Subarist

opencart
I believe there are still issue , both desktop and mobile devices are reporting errors.

luceos

Subarist the owner of the oauth line application seems to need a developer role. That is what the error seems to imply.

opencart

Subarist now, public 😎

Subarist

luceos

Yes, just let @opencart know that there is an issue with logging into his forum.

Subarist

opencart
The login function is now working properly, but on mobile devices, it still cannot directly return to flarum. need to go back to the previous page on the LINE authentication screen.