Staff Diary: v2.0 Cycle

Oshvam

Darkle congrats 😊

MikeJones

@Darkle congratulations!

SychO

Weeks 18, 19, 20,

Since the last time I reported progress here, I have completed the search refactor and then the search drivers implementation which will easily allow ecosystem developers to create search drivers. That is now awaiting review: flarum/framework3893

Next on my agenda is the implementation of search UI/UX improvements. I'll kickstart this task once the design work by @Darkle is considered ready. He has been diligently working on improving the search experience. Checkout the discussion here if you are interested.

Additionally, @IanM is making remarkable progress on the GDPR extension/changes.

In the meantime, I'm planning to address other open pull requests, tackle recent bugs that have emerged from recent changes, and work on resolving some long-standing issues.

SychO

We just released a patch for the approval extension v1.8.1 which fixes an issue with false positives in the akismet extension.

To update just run:

composer update flarum/approval

Thanks to @rafaucau for the contribution!

meihuak

SychO I use 1.8.3, do I need update this?

SychO

meihuak you probably mean 1.8.3 for core and some other bundled extensions. I am referring to a new 1.8.1 for the approval extension which hasn't had a patch before. So yes 😉

SychO

Hello 👋,

Over the past five weeks (Weeks 21 through 25), @Darkle has completed the mockups for the new search UI/UX improvements. If you haven't seen them yet, you can check them out here: Flarum 2.0: UI/UX Improvements for enhanced search experience.

I acknowledge I haven't been as active as I'd like to be in this period. However, I've been making significant progress on its implementation, which is nearly complete. A few final adjustments are pending to refine some details.

Here is a preview of the implementation:

preview
gif preview

SychO

We just tagged a core v1.8.4 release that prevents certain reported errors with specific php versions (likely 8.1.2 & 8.2.7) (https://discuss.flarum.org/d/33746-an-error-occurred-while-trying-to-load-this-page)

composer update flarum/core

wolfman

SychO @GreXXL Thanks for the fix guys! Update to 1.8.4 worked fine for me now! 🙂

Gorm

SychO this must be doubled in https://discuss.flarum.org/d/32899-flarum-v180-released

Subarist

This is what makes Flarum so different.
A clear direction of development, although it moves at its own pace.
But necessary corrections are always quickly made.
Love you, you are a bunch of heroes.
It feels like home.

Litalino

🇦 Lock file operations: 0 installs, 3 updates, 0 removals

Upgrading flarum/core (v1.8.3 => v1.8.4)
Downgrading s9e/sweetdom (3.2.0 => 2.1.2)
Downgrading s9e/text-formatter (2.15.0 => 2.14.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 3 updates, 0 removals
Downloading flarum/core (v1.8.4)
Downgrading s9e/sweetdom (3.2.0 => 2.1.2): Extracting archive
Downgrading s9e/text-formatter (2.15.0 => 2.14.3): Extracting archive
Upgrading flarum/core (v1.8.3 => v1.8.4): Extracting archive

GreXXL

Litalino, do you have a question about this? The development team has decided to restrict Flarum from using the latest stable version of text-formatter for the moment. There is an issue with version 2.15.0, which causes problems on installations with outdated PHP versions. Once the issue is fixed in text-formatter (or we change the minimum required PHP version), we can relieve this restriction.

JoshyPHP

GreXXL I've just released s9e/text-formatter:2.15.1 and s9e/sweetdom:3.3.0 which should fix all of the DOM issues on older PHP versions.

I ended up completely emulating the DOM4 methods on the affected versions, which are PHP < 8.1.23, and 8.2.0 to 8.2.9. Anything newer than that keeps running the native implementation which, to the best of my knowledge, has no bugs that affect either libraries. I have GitHub actions to test both libraries on whatever 8.1/8.2/8.3 versions are available by default, plus a separate run on 8.1.2 specifically for as long as the docker image remains available. By the way, if anybody knows of a simple way to run GitHub actions on patch-level versions of PHP I'm super interested. It's not currently supported by setup-php.

s9e/SweetDOMreleases/tag/3.3.0 s9e/TextFormatterreleases/tag/2.15.1

Subarist

As far as I know, there shouldn't be any major changes to the UI in 2.0, right? And the current interface doesn't seem easily surpassable.
What I'm curious about is whether there will be significant changes in the structure or syntax of custom CSS?
I'm currently in the early stages of building a new site , and if there are expected to be substantial changes to CSS, I won't invest time in visual modifications.

JoshyPHP

@GreXXL @SychO Could either of you (or any intrepid volunteer) try upgrading your local dependencies to s9e/text-formatter:dev-current/SweetDOMWorkarounds to see if it fixes all of your issues on PHP 8.1.2? It depends on s9e/sweetdom:dev-Workarounds which contains a number of workarounds for PHP < 8.3.0. In actuality, I'm not aware of any relevant bugs in PHP ~8.1.23 or ^8.2.10 but this version of the library contains a backport of a PHP 8.3.0 change.

The reason I'm targeting PHP 8.1.2 is because that's the oldest docker image I found to be available via GitHub actions. To test on PHP 8.1.0 I'd have to manually compile it, which I did and all the tests pass but I won't be able to keep running the test suite on it so the oldest version I can reliably run tests on is 8.1.2.

If there are no further issues, I intend to release updates for both s9e/sweetdom and s9e/text-formatter shortly after.

Subarist

JoshyPHP
with s9e/sweetdom:dev-Workarounds on php 8.1.17
The flarum/waterhole duo currently seems to be functioning quite normally.

SychO

Subarist is that without any of the previous requirements on s9e/textformatter in your root composer.json, you'd also have to lock core to 1.8.3 to actually tell.

I can't reproduce to check myself.

Subarist

SychO
On that vps is still 1.8.1.
I modified the composer.lock require with
"s9e/sweetdom": " * " "s9e/text-formatter": " * "
and then update to s9e : dev

        {
            "name": "flarum/core",
            "version": "v1.8.1",
            "source": {
                "type": "git",
                "url": "https://github.com/flarum/flarum-core.git",
                "reference": "ce3bbf02f0f4dbb9cc56752c1c49a6c42b63f1fc"
            },
        {
            "name": "s9e/text-formatter",
            "version": "dev-current/SweetDOMWorkarounds",
            "source": {
                "type": "git",
                "url": "https://github.com/s9e/TextFormatter.git",
                "reference": "58efa9b90e41aed8853716d99ff6b7270e5c9787"
            },
        {
            "name": "s9e/sweetdom",
            "version": "dev-Workarounds",
            "source": {
                "type": "git",
                "url": "https://github.com/s9e/SweetDOM.git",
                "reference": "a285d940596142c7730d27c9df50510f04eb0dae"
            },

Subarist

JoshyPHP
Thank you sir , 2.15.1 is currently functioning well on Flarum 1.8.3 with PHP 8.1/8.2. and also watherhole is ok.

« Previous Page Next Page »