Duplicate emails

RelicSystem

On this post https://discuss.flarum.org/d/33597-all-users-are-set-to-user-group-none - I had, at the time not selected a best answer, however I received 2 emails asking "Did you manage get your question answered?" - which firstly reads wrong to my English brain should be "Did you manage to get your question answered?" (its missing the to)

I checked the email headers, the emails were 3 seconds apart 00:00:05 and 00:00:08.. not complaining, just seems like a bug that might be using double its resources ? (and the subject line is imo wrong)

IanM

RelicSystem "Did you manage get your question answered?" - which firstly reads wrong to my English brain should be "Did you manage to get your question answered?" (its missing the to)

Confirmed, this is a typo in the en.yml file. FriendsOfFlarum/best-answer/blob/022f7751121e29c543397c566f3245f010d4e3f9/resources/locale/en.yml#L74

(also, note to self to look at the rendering of this type of GitHub link)

I'll get that changed ASAP, thanks for spotting!

As for the double notification, first things first, can I just double check that both notifications are for the same discussion? For example, the included link in the notification is the same discussion id?

RelicSystem

Spotting a typo, no big deal feel like a pleb pointing them out when yourself and the rest of the team do so much work on this project for someone like myself to scream typo! So Uno reverso on the thanks, appreciate your efforts!

I just went back to check the emails and yes, exactly the same email message with the exact same link (same IDs)

RelicSystem

I enabled two factor authentication on my profile and received two emails letting me know I had done so… not concerned with receiving two emails myself but bugs a bug.

I did receive other notifications from this site today and they were as expected a single email letting me know someone had posted in a topic i follow