Rules min not working

Litalino

The code below works fine with the max rule, but the min doesn't work.

class AddPostsValidation extends FormatContent
{

    /**
     * @param Validator $validator
     */
    public function __invoke($flarumValidator, Validator $validator)
    {
        $rules = $validator->getRules();

        if (!array_key_exists('content', $rules)) {
            return;
        }

        if ($this->settings->get('litalino-content-length.limit')) {
            $rules['content'] = array_map(function (string $rule) {
                if (Str::startsWith($rule, 'min:')) {
                    return 'min:' . $this->settings->get('litalino-content-length.min');
                }

                if (Str::startsWith($rule, 'max:')) {
                    return 'max:' . $this->settings->get('litalino-content-length.max');
                }

                return $rule;
            }, $rules['content']);
        }

        $validator->setRules($rules);
    }

Flarum default: PostValidator

<?php

/*
 * This file is part of Flarum.
 *
 * For detailed copyright and license information, please view the
 * LICENSE file that was distributed with this source code.
 */

namespace Flarum\Post;

use Flarum\Foundation\AbstractValidator;

class PostValidator extends AbstractValidator
{
    protected $rules = [
        'content' => [
            'required',
            'max:65535'
        ]
    ];
}

Can anyone help make "rules min" work?

clarkwinkelmann

Litalino I assume this code was based on some examples I shared previously. The use of the array_map function is specifically to replace the existing max: rule with a different one (because if you had two max rules then the larger number would never override the smaller number).

However there are no min: rules in the original validator, so there's nothing it can replace.

To add new rules, just add them to the array: $rules['content'][] = 'min:1234'

Ideally, you should combine the two methods to first look if any other extension added a min: rule and replace it, and if there isn't then create a new rule. But this might be unneeded complexity because if two extensions are changing it you are probably already running into some other forms of conflict.

Litalino

clarkwinkelmann

 (new Extend\Validator(PostValidator::class))
        ->configure(function ($flarumValidator, $validator) {
            $rules = $validator->getRules();

            if (!array_key_exists('content', $rules)) {
                return;
            }

            $rules['content'][] = 'min:30';
            $rules['content'] = array_map(function(string $rule) {
               if (Str::startsWith($rule, 'max:')) {
                    return 'max:500';
                }

                return $rule;
            }, $rules['content']);

            $validator->setRules($rules);
        }),

$rules['content'][] = 'min:30'; Not working
Max: 500 Works fine

Text: "df fd df f dffgg" << 16 Char >> Works fine

Text: "df fd df f df f" >> 15 char >> The content must be at least 30 characters.

https://charactercalculator.com/ << Test Char

https://discuss.flarum.org/d/29812-add-new-validator-to-core/10

Error Post New Content is empty

(new Extend\Event)
        ->listen(\Flarum\Post\Event\Saving::class, function ($event) {
            // Exclude enforcement for administrator and moderator groups
            $user = $event->actor;
            if ($user instanceof \Flarum\User\User && ($user->isAdmin())) { //|| $user->isModerator()
                return;
            }
            if ($event->post->isDirty('content')) {
                resolve(\Illuminate\Contracts\Validation\Factory::class)->make([
                    'content' => $event->post->content,
                ], [
                    'content' => 'min:20|max:20000',
                ])->validate();
            }
        }),

Litalino

Now I'm getting an error in replying with empty content:

CHECK LOG:

[2023-12-02 02:51:51] flarum.ERROR: TypeError: SychO\MovePosts\Formatter\UnparsePostMentions::__invoke(): Argument #2 ($xml) must be of type string, null given, called in /public_html/vendor/flarum/core/src/Foundation/ContainerUtil.php on line 30 and defined in /public_html/vendor/sycho/flarum-move-posts/src/Formatter/UnparsePostMentions.php:18
Stack trace:

ERROR PLUGIN MOVEPOST

Fix: line 20: public function __invoke($context, $xml): ?string //public function __invoke($context, string $xml)

clarkwinkelmann

I believe we have a discussion or GitHub issue somewhere about the content length validation because I remember discussing this previously.

I believe what gets validated is not the user input, but the value being saved to the database, which will be the parsed version of the content in XML format. That XML is generally 14 characters long minimum due to the wrapping tags around the text, but it might vary depending on which plugins are enabled in the formatter.

To validate the actual input, a different strategy might be required.

Edit: I see the post I was thinking of in my notifications tab since you added a like to it. It's indeed this was I referring to https://discuss.flarum.org/d/29812-add-new-validator-to-core/10 I'm not sure if the proposed alternate solution still works

Litalino

clarkwinkelmann Thank you for your reply..

I have problems with the 2 codes below:

CODE A: Works fine. But counting characters is not accurate.

(new Extend\Validator(\Flarum\Post\PostValidator::class))
        ->configure(function ($flarumValidator, $validator) {
            $rules = $validator->getRules();

            // Not all attributes are validated every time. Skip if content is not being validated
            if (!array_key_exists('content', $rules)) {
                return;
            }

            $rules['content'][] = 'min:30';
            $rules['content'] = array_map(function(string $rule) {
     
                if (\Illuminate\Support\Str::startsWith($rule, 'max:')) {
                    return 'max:20000';
                }

                return $rule;
            }, $rules['content']);

            $validator->setRules($rules);
        }),

CODE B: getting error when replying with empty content:

code b: counts the exact number of characters

Error: flarum.ERROR: TypeError: Flarum\Mentions\Formatter\UnparsePostMentions::__invoke(): Argument #2 ($xml) must be of type string, null given, called line 34

/flarum.ERROR: TypeError: Flarum\Mentions\Formatter\UnparsePostMentions::__invoke(): Argument #2 ($xml) must be of type string, null given, called in /public_html/vendor/flarum/core/src/Foundation/ContainerUtil.php on line 30 and defined in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php:36
//flarum.ERROR: TypeError: Flarum\Mentions\Formatter\UnparsePostMentions:: __invoke(): Argument #2 ($xml) must be of type string, null given, called in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php on line 36 and defined in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php:49
//flarum.ERROR: TypeError: Flarum\Mentions\Formatter\UnparsePostMentions::updatePostMentionTags(): Argument #2 ($xml) must be of type string, null given, called in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php on line 36 and defined in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php:49
//flarum.ERROR: TypeError: Flarum\Mentions\Formatter\UnparsePostMentions::unparsePostMentionTags(): Argument #1 ($xml) must be of type string, null given, called in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php on line 37 and defined in /public_html/vendor/flarum/mentions/src/Formatter/UnparsePostMentions.php:81

(new Extend\Event)
        ->listen(\Flarum\Post\Event\Saving::class, function ($event) {
            // Exclude enforcement for administrator and moderator groups
            $user = $event->actor;
            if ($user instanceof \Flarum\User\User && ($user->isAdmin())) { //|| $user->isModerator())
                //return;
            }
            if ($event->post->isDirty('content')) {
                resolve(\Illuminate\Contracts\Validation\Factory::class)->make([
                    'content' => $event->post->content,
                ], [
                    'content' => 'min:20|max:20000',
                ])->validate();
            }
        }),

disable flarum-mention plugin: code B Works fine.

To use code B or To use the code below, to count characters correctly, I had to edit the files: and enable flarum-mentions plugin

/public_html/vendor/flarum/mentions/src/Formatter/

UnparsePostMentions.php 
line 34 public function __invoke($context, $xml): ?string
line 49 protected function updatePostMentionTags($context, $xml): ?string
line 81 protected function unparsePostMentionTags($xml): ?string
line 85 if (@strpos($xml, $tagName) === false) {

UnparseTagMentions.php
line 25 public function __invoke($context, $xml): ?string
line 40 protected function updateTagMentionTags($context, $xml): ?string
line 63 protected function unparseTagMentionTags($xml): ?string
line 67 if (@strpos($xml, $tagName) === false) {

UnparseUserMentions.php
line 36 public function __invoke($context, $xml): ?string
line 51 protected function updateUserMentionTags($context, $xml): ?string
line 78 protected function unparseUserMentionTags($xml): ?string
line 82 if (@strpos($xml, $tagName) === false) {

clarkwinkelmann

This looks like an implemention error within the Mentions extension. It should accept a nullable content value 🤔