HTML Attribute not rendered with s9e/TextFormatter.

Rinfair

I'm now using Flarum 1.8.5 with PHP version 8.1.27. When I found fof/formatting not supporting inserting html elements into posts, I tried to configure text formatter in extend.php using the code below:

use Flarum\Extend;
use s9e\TextFormatter\Configurator;

return [
    (new Extend\Formatter)
        ->configure(function (Configurator $config){
            $config->HTMLElements->allowElement('table');
            $config->HTMLElements->allowUnsafeAttribute('table', 'style');
            $config->HTMLElements->allowElement('td');
            $config->HTMLElements->allowUnsafeAttribute('td', 'style');
            $config->HTMLElements->allowElement('tr');
            $config->HTMLElements->allowAttribute('tr', 'bgcolor');
        }),
];

After that I reloaded the site and cleared cache, and tried the table below:

<table style="width:100%">
<tr bgcolor="#224B0C">
 <td style="color:white">👌 XXXXXX</td>
</tr>
<tr bgcolor="#AC4425">
<td>🙅 XXXXXX</td>
</tr>
</table>

Every element is rendered properly, however the attribute bgcolor is not correctly rendered as the color I set. Instead, the background color is rendered as the one I set in the admin panel-> Appearance ->highlight color.
Does the highlight color setting truly override the element attribute settings? How can I solve this problem?
@JoshyPHP

JoshyPHP

What's the HTML output? If it shows <tr bgcolor="#AC4425"> then it's not a markup issue and the bgcolor attribute is just unsupported by the browser.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tr#bgcolor

Rinfair

JoshyPHP
Output is correct and after further testing I have confirmed that the attribute is truly unsupported now, back to using style instead 😢
By the way, since style is an unsafe attribute, where can I define the css that can be used by anyone in the forum?

JoshyPHP

I suppose you could add CSS classes for that, or something like that.

Otherwise, for what it's worth, you can modify the template used to render <tr> elements so that it turns the bgcolor attribute into a style. I don't know whether that's a better idea than just creating custom BBCodes for your custom tables.

$config->tags['html:tr']->attributes['bgcolor']->filterChain->append('#color');

$dom = $config->tags['html:tr']->template->asDOM();
$dom->firstOf('//xsl:copy-of[@select = "@bgcolor"]')
    ->replaceWithXslIf('@bgcolor')
    ->appendXslAttribute('style', 'background-color:')
    ->appendXslValueOf('@bgcolor');
$dom->saveChanges();