Flarum do perform some automated update?

peopleinside

The issue

As I don't like how sticky post works on Flarum and, as I don't find an extension that do the same good job that a simple code edit in the sticky extension do, I use to edit the sticky source code every time I run a Flarum or a sticky extension update.

Since some months sometimes I discover that my code changing in the sticky extension are reversed to the original.
I don't updated Flarum or sticky extension so I'm asking why this happen.

If there is a sort of auto update I need be notified when this happen or maybe also I don't want active because will let me loose sticky source code that I edited.

The best would be copy the sticky extension and made a new copy extension that I should use instead use the original but in this way I will miss future updates and this seems not good for security.

The question is, Flarum do a sort of auto update to himself or to extension?
I think not but I really cannot explain why I'm loosing sticky source code edit.

I recently just manually updated fof terms extension.

clarkwinkelmann

No, Flarum doesn't have any kind of automatic updates.

However anytime you run Composer it could affect any file under the vendor folder. If you run Composer with a specific list of packages to update it should leave everything else untouched but I don't know whether Composer guarantees it.

Like you say, if you want predictability, you'll need to copy the extension. You can have a local clone of the git repository for an extension installed through a custom Composer path with either committed or uncommitted local changes, and run git pull and cherry pick or resolve conflicts every time the extension has an update.

peopleinside

Thank you for the reply.
Strange in any case as I don't use anymore SSH composer on Flarum as I'm using the package manager.

Copy an extension is not enough, i tried in the past and I get errors 🙂

SychO

You should never touch vendor especially if you're using the package manager, it will create file permission issues causing future actions to fail.

The best you can do is fork sticky, modify it, make it a proper package, install it normally

peopleinside

I'm not a developer and as I said is not easy and get errors also when try to fork and copy an extension. The issue will be also keep this updated because for sure copy a core extension and use it will never include updates so will create a potential security issue.

Sadly the sticky used in Flarum is not a full sticky because it doesn't work for my account that is always logged, that has already read the topic and need to see the topic on top and is not because the topic need to be unread to be sticky.

The only solution for me, at the moment is to edit the core code.
I'm not a developer.
I tried in the past to resolve the sticky issue but no solution has worked.

Someone created an extension that is not fully working and is not yet also updated since two years so this means a potential security issues or bugs can be present.

I tried to fork copy, etc but I broke always Flarum installation so this is not a solution for me, can be for a developer that maybe do that work without issues.

Anyway... will remain a mastery why sometimes I see the core extension code edit to be lost and reset, this was my topic purpose: try to understand why this happen.

adrianm

I had a quick look at this as I think I will need the default behaviour changed on this one changed too.

I could put in a PR to flarum to add an option "Filter read from stickied on All Discussions page" or I could just make a new extension that overrides the core behaviour.

PR on flarum:
I'm not sure what repo to put the PR into - I have checked out the flarum/sticky repo but it is read only?

New extension:
Seems a bit over the top to have a whole extension just for one option - kind of like what I did with my "avatar tools" which was basically a POC to see if I could actually make extensions - haha - but seems like there might be a heap of these random smaller things where it would be nice to have a setting or option but it doesn't make sense to put it in the core? Should they be bundled in one general extension?

luceos

adrianm I'm not sure what repo to put the PR into - I have checked out the flarum/sticky repo but it is read only?

flarum/framework - we use a monorepo with subsplit to push into readonly sub repos.

adrianm

I've created a PR to flarum/framework with an option for filtering out "read" from stickied discussions (default) or not. Will see how that goes - not sure if PRs are being looked at right now, and maybe this needs to be in a 3rd party extension anyway.