GitHub, GitLab FoF oauth both fail, redirect to flarum.org

meonkeys

I'm trying to get "login with GitLab" and "login with GitHub" (3rd party oauth logins) working for https://help.selfhostbook.com. I can see and approve oauth in the popup window for both, but then (back in the main window) I just get redirected to https://flarum.org/.

I'm running Flarum 1.8.5 on PHP 8.3.6 with MySQL 5.7.23-23 and FoF OAuth 1.6.9. The 3rd party bit appears to be working properly: GitHub and GitLab show that auth was approved on their end. I don't see any new users in my Flarum instance.

I have "Log OAuth errors" enabled but I don't see any errors in the log.

luceos

meonkeys this relates to your own community? Did you configure your apps with the right url instead of flarum.org?

meonkeys

this relates to your own community?

Yes. It's a self-hosted Flarum instance.

Did you configure your apps with the right url instead of flarum.org?

Yes, I think so. In Flarum's config.php file, url is set to https://help.selfhostbook.com.

At GitHub I created an oauth app with:

Homepage URL: https://help.selfhostbook.com
Authorization callback URL: https://help.selfhostbook.com/auth/github
Enable Device Flow: not checked

At GitLab I created an oauth app with:

Redirect URI: https://help.selfhostbook.com/auth/gitlab
Confidential: checked
Scopes: read_user

I double checked the app IDs and secrets in the FoF OAuth config: they look correct. The GitLab Domain is set to https://gitlab.com.

At first I did have the "Sign up" global permission set to "Closed", but I didn't see any difference after changing it to "Open". Should that matter?

meonkeys

Strange, but when I try to log in I am getting redirected to flarum.org really uh, aggressively? Check this out:

start at https://help.selfhostbook.com
click "Log in"
click anywhere outside the "Log In" modal
get redirected to flarum.org

This repros whether or not FoF OAuth is enabled.

Oh man, I need to double-check my custom HTML footer... I may have done something really bad like leaving open an a tag. Argh, yep, that was it! Thank you https://validator.w3.org . 🤦

luceos

meonkeys not gonna lie, I was so confused with how you managed to do this 😊

Glad you figured it out!