Get discussion id?

seodevse

Hello, me and my friend ChatGPT have built a DiscussionForumPosting schema.org extension but I had to do a workaround to get the discussion id with strpos($SERVER['REQUEST_URI'], '/d/') !== false then preg_match('/\/d\/(\d+)/', $SERVER['REQUEST_URI'], $matches); $discussionId = $matches[1] ?? null;....

How do I get the discussion id the correct way? I managed to get stuff like this going "use Flarum\Settings\SettingsRepositoryInterface;"

clarkwinkelmann

seodevse which extenders are you using to extend Flarum? The way to access the discussion object is different pending on where/when your code runs in the extension lifecycle.

If your extension is open-source, please share a link to your repository so we can take a look.

Reading the discussion ID from the URL will work on a standard installation, but it might not work if a user customizes the discussion slugger to something different. There are some situations where it could be the only way, in that case there are ways to read the route name and parameters and use the slugger API to obtain this information in a way that will work with customized URLs and customized sluggers.

seodevse

clarkwinkelmann frontend lifecycle of Flarum I think?

Uploaded it to Github here: seodevse/flarum-discussion-forum-posting-schema

Tried adding this to AddSchemaToHeader.php with no luck:
use Psr\Http\Message\ServerRequestInterface;
...
// Dynamically resolve the request from the service container
$request = resolve(ServerRequestInterface::class);

        // Get route parameters from the request
        $routeParams = $request->getAttribute('routeParameters');
        $discussionId = $routeParams['id'] ?? null;

        // Only proceed if discussion ID is available
        if ($discussionId) {....

huseyinfiliz

seodevse

<?php

use Flarum\Extend;
use Flarum\Frontend\Document;
use Flarum\Discussion\DiscussionRepository;
use Psr\Http\Message\ServerRequestInterface;

return [
    (new Extend\Frontend('forum'))
        ->content(function (Document $document, ServerRequestInterface $request) {
            $routeParams = $request->getAttribute('routeParameters') ?? [];
            $discussionSlug = $routeParams['id'] ?? null;

            if ($discussionSlug) {
                $repository = resolve(DiscussionRepository::class);
                $actor = $request->getAttribute('actor');
                $discussion = $repository->findOrFail($discussionSlug, $actor);

                $discussionId = $discussion->id;

                $document->head[] = "<script>console.log('Discussion ID: {$discussionId}');</script>";
            }
        }),
];

Using the code above, I successfully printed the discussion ID to the console via extend.php. However, I used ChatGPT for assistance, and I'm unsure if this code is optimal or the correct method. I hope it proves useful.

seodevse

is this not possible to solve?

luceos

huseyinfiliz I think this code only works on the first hit/visit, because flarum is a spa. If this is for machines only (eg bots) then this solution might actually work.

huseyinfiliz

luceos You're absolutely right. What was being attempted in the example code was to make an existing function within the project work properly instead of creating a new one.

For instance, in this example this code, I managed the rendering not only during the first visit but also on every route/page change and even within different comments inside a discussion.

A similar approach could achieve this as well. However, the example code provided by @seodevse made me feel like such an approach might not be necessary in this case

@luceos I guess I'm starting to improve myself, right? 😄

seodevse

It needs to work on all visits, otherwise I can keep my strpos($SERVER['REQUEST_URI'], '/d/') solution. First visit might cause weird problems with Google bot....

huseyinfiliz

seodevse Even though Google bots typically treat every page as if it's being loaded for the first time, if you're still unsure, I can try a few tests to ensure it works with route changes. I'll take a look at it tomorrow

Addition: When I checked the latest version of your GitHub code, I noticed that it only works on the first visit, not on all visits. I might have made a mistake while testing it with extend.php, but could you please confirm if the updated code correctly updates the discussion ID during page transitions when you test it?