change core code? FulltextGambit.php

fakethinkpad85

Want your opinion or if there is another option of doing this. What i need is to change the search function from using Match (whole word) to Like (part of word/fulltext) and noticed a file FulltextGambit.php that seems to handle the search.

is it fine to change this file or is there a better way?

/core/src/Discussion/Search/Gambit/FulltextGambit.php

from,
->whereRaw('MATCH('.$grammar->wrap('discussions.title').') AGAINST (? IN BOOLEAN MODE)', [$bit]);

to,
->whereRaw('discussions.title LIKE ?', ['%' . $bit . '%']);

and ofcourse the same for the content

as a seperate issue also need to change the "insert code" function to insert triple wrap ´ signs instead of single wrap to automaticle have it detect and format code by default, not sure where this is stored but guessing the implementation would be roughly the same.

Thanks in advance,
Christian

fakethinkpad85

Should mention, I'm not too worried about search performance, it's a smaller local Wiki site that is more important to search content dynamically in and if results takes a 1-10 seconds in not an issue.

ernestdefoe

fakethinkpad85 Have you looked to see if maybe this extension may do what you are needing? When you edit core files and you update you'll have to edit said files again. So take a look at this and see if it does what you need. https://discuss.flarum.org/d/32017-post-stream-search

fakethinkpad85

@ernestdefoe If i understand the documentation correctly it filters/searches inside a specific topic while i need to search through all topics on the forum for any matches.

Understand what you mean by updating, means that it will overwrite the changes but don't really have the knowledge to create my own extension even if that would probably be the way to go.

Searched all over for an extension but haven't found one that does what i need so any pointers are appreciated. can't be alone in wanting the search to do a fulltext/like search, most other forums do.

clarkwinkelmann

To make your changes permanent, just create your own copy of the class directly in extend.php or in a custom namespace registered in the root compose.json, then register it using a local extender.

Something like this (I did not test the code):

<?php

use Flarum\Extend;
use Flarum\Discussion\Search\DiscussionSearcher;
use Flarum\Search\GambitInterface;
use Flarum\Search\SearchState;

class MyFulltextGambit implements GambitInterface
{
    public function apply(SearchState $search, $bit)
    {
        // your logic
    }
}

return [
    (new Extend\SimpleFlarumSearch(DiscussionSearcher::class))
        ->setFullTextGambit(MyFulltextGambit::class),
];

Post Stream Search doesn't change the way the search works. It creates a separate searcher class for posts. The default SQL was copied from the discussion searcher. If you do use Post Stream Search and customized the discussion fulltext gambit, you will also need to separately customize the post fulltext gambit.

Or alternatively if this makes sense, you can use Scout Search, which overrides both of these fulltext gambits to use one of Scout supported search drivers instead.