Profile pictures size and GIF support

HasanMerkit

Please let us edit the minimum and maximum resolutions of profile pictures from the admin panel and provide GIF support.
It seems really unnecessary to require a extension for this. I couldn't find the add-on either.

clarkwinkelmann

HasanMerkit do you mean the maximum file size? Flarum does not enforce any limit for the resolution of the input file. There's also no minimum file size or resolution, that would be extremely annoying.

Or are you talking about changing the output resolution? This doesn't make much sense without an extension, because Flarum never needs to show larger avatars out of the box.

For animated avatars I can't see this ever becoming part of core. This is perfect material for a community extension. There's a lot of validation and conversion required to make such a feature safe and performant.

HasanMerkit

clarkwinkelmann 100x100 very small resolution. I created custom PHP script and works with Flarum database. Im working for custom profile page but 100x100 is very very bad resolution for my plans. My problem is not file size. Resolution and GIF.

If Flarum allows change the convert settigs, its make usefuly. Not just for me. For another thinks. Also, some forums (flarum websites) sometime want use GIFs.

Okey, may be you recomment to us develop a extension. But, some features is need exists in core. Right? 🙏

clarkwinkelmann

HasanMerkit the files/classes relevant are

for the input
flarum/frameworkblob/v1.8.10/framework/core/src/User/AvatarValidator.php

for the output
flarum/frameworkblob/v1.8.10/framework/core/src/User/AvatarUploader.php

For the input, I think it's possible to change most values through the validator extender if you want to stay compatible with other extensions.

For the output, I think you have to create your own class (that can extend the original), then bind it in the container to replace the original. This will not be compatible with other extensions trying to do the same. But this is safe to do, particularly if this is a private extension or local extender just for your forum.

Maybe other people will know if there already exist extensions that do this and whose code can be looked at.