Resuscitate PWA Extension

KBExit

Hey guys,
I have installed the PWA extension a numerous of times on different sites, but lately noticed that it no longer works for newer environments.
As software updates happen, this extension is falling behind... Far behind.
Activity on this extension as been stale.
Developer of the revived extension itself has gone MIA all all accounts, including his own blog / forum.
Trying to install this in PHP 8.4 has been unsuccessful. If this extension is needed / wanted in the community, we need someone that's active in contributing.
I've emailed @huseyinfiliz to voice these concerns, and he said I can have the green light to make a proposal on the revival of this extension. I think he's well suited for this job and obviously cares a lot of Flarum.
What do you guys think?
Thanks again @huseyinfiliz!

Darkle

KBExit Hey, when you say it’s not working, what exactly is happening? Personally, I’m still using it without any issues and it’s important to me. If it turns out it’s not functioning and is actually planned to be abandoned, I’d have no problem taking over its maintenance.

KBExit

Darkle this is what happens when you try and install it now on the latest PHP configurations.
PHP Warning: "resource" is not a supported builtin type and will be interpreted as a class name. Write "\Safe\resource" or import the class with "use" to suppress this warning in /home/fbsfb/htdocs/fbsfb.com/vendor/thecodingmachine/safe/generated/sockets.php on line 797 PHP Warning: "integer" will be interpreted as a class name. Did you mean "int"? Write "\Safe\integer" or import the class with "use" to suppress this warning in /home/fbsfb/htdocs/fbsfb.com/vendor/thecodingmachine/safe/generated/swoole.php on line 17 Clearing the cache...

This happened every time I triggered a command on terminal with the extension installed.

Your requirements could not be resolved to an installable set of packages. Problem 1 - Root composer.json requires askvortsov/flarum-pwa 3.4.1 -> satisfiable by askvortsov/flarum-pwa[v3.4.1]. - askvortsov/flarum-pwa v3.4.1 requires kreait/firebase-php ^5.0 -> satisfiable by kreait/firebase-php[5.0.0, ..., 5.26.5]. - kreait/firebase-php[5.0.0, ..., 5.8.1] require php ^7.2 -> your php version (8.4.12) does not satisfy that requirement. - kreait/firebase-php[5.10.0, ..., 5.26.5] require guzzlehttp/promises ^1.4 -> found guzzlehttp/promises[1.4.0, ..., 1.5.3] but the package is fixed to 2.3.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command. - kreait/firebase-php[5.13.0, ..., 5.19.0] require php ^7.2|~8.0.0 -> your php version (8.4.12) does not satisfy that requirement. - kreait/firebase-php 5.9.0 requires lcobucci/jwt ^3.3.1 -> satisfiable by lcobucci/jwt[3.3.1, ..., 3.4.6]. - lcobucci/jwt[3.3.0, ..., 3.4.6] require php ^5.6 || ^7.0 -> your php version (8.4.12) does not satisfy that requirement. Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

This is what happens when I installed it.

ernestdefoe

KBExit it may work installing on an older version of PHP and updating to a new version but installation itself on a new site with the new php version may be the issue.

KBExit

ernestdefoe if you want it, I may downgrade the PHP version on your site and make sure it's functional. But the extension itself does need updating.

clarkwinkelmann

The PHP Warning is not a problem. You should just disable PHP Warning output in production https://discuss.flarum.org/d/36404-stopping-deprecation-warnings

In the Composer output there are 2 issues. One is a partial update error, which might have occurred as a result of trying to update an incompatible extension, but not directly related. You should try fixing this (one way is deleting vendor and re-installing from the lock file), to see whether there are still problems when there are no longer any partial updates. The other is a dependency issue likely related to PHP 8.4. This is probably the only important part in all of this. The problem is likely that one of the dependencies of PWA does not officially support PHP 8.4. Using the Composer why commands, it should be possible to isolate exactly which one(s) it is and what's the dependency tree. If other people are able to use the extension on PHP 8.4 without issue, it's possible that one of the dependencies is used by multiple extensions, and another extension is restraining which versions can be installed, leading to an unresolvable combination of dependencies.

It's also possible there is in fact no issue at all, that a dependency is just used by multiple extensions, and that you need the -W flag to allow Composer to update it, otherwise it might not try to update it at all. If you come from a different PHP version and think this might be the problem, a good test would be to delete the lock file, and make Composer re-resolve and re-download everything. Keep a backup of your lock file in case you need to revert.

A workaround if you don't want to downgrade your PHP version, is to use the platform Composer configuration to make it download PHP 8.3-compatible packages. This shouldn't cause any issue as all 8.3 code should be compatible with 8.4. The only downside is that if some extensions or dependencies take advantage of 8.4 new features, you'll lose these possible improvements (but you'll still have the benefits of PHP itself running probably faster on 8.4).

It's not very complicated, but I don't have the setup in place right now to run the dependency checks... Can anyone else confirm whether the extension works on PHP 8.4 for them or not? This would help for the starting point to know if this can be investigated with just a clean install, or if we need to identify a combination of incompatible extensions first.

KBExit

clarkwinkelmann So this happened during a clean install on PHP 8.4 unfortunately. I am waiting to hear back from the client about downgrading. I guess 8.3 would be a good starting point on the downgrade process. I know for sure that I have used this extension on 8.2 previously without issues.

clarkwinkelmann

KBExit just to be clear, the error messages above are from 2 different forums then? There's no way the extension fails to install, but also that it produces PHP warnings when used (?)

KBExit

clarkwinkelmann To clarify, the first message happened when I was clearing cache after the install and found that error. Then started on a clean install and then got the second part.
Sorry about the confusion!

Edit:
Flarum core: 1.8.11 PHP version: 8.4.12 MySQL version: 8.4.6-6 Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, Reflection, SPL, session, standard, sodium, memcached, redis, imagick, mysqlnd, PDO, xml, bcmath, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, iconv, intl, exif, mysqli, pdo_mysql, pdo_sqlite, Phar, posix, readline, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Zend OPcache +-----------------------------------+---------+--------+ | Flarum Extensions | | | +-----------------------------------+---------+--------+ | ID | Version | Commit | +-----------------------------------+---------+--------+ | flarum-flags | v1.8.2 | | | flarum-tags | v1.8.5 | | | flarum-approval | v1.8.2 | | | flarum-bbcode | v1.8.0 | | | flarum-suspend | v1.8.4 | | | flarum-sticky | v1.8.2 | | | flarum-lock | v1.8.2 | | | fof-best-answer | 1.6.5 | | | flarum-subscriptions | v1.8.1 | | | walsgit-discussion-cards | 1.3.0 | | | ramon-colored | 1.1.1 | | | michaelbelgium-discussion-views | v7.4.1 | | | kilowhat-rich-embeds | 1.4.0 | | | kilowhat-audit-pro | 1.7.1 | | | justoverclock-reputation-score | 1.6.4 | | | justoverclock-auto-post-badge-pro | 0.3.1 | | | huseyinfiliz-sticky-title | v1.8 | | | huseyinfiliz-notificationhub | v0.3 | | | huseyinfiliz-modern-footer | v0.8 | | | huseyinfiliz-custom-profile-page | 0.2 | | | fof-upload | 1.8.5 | | | fof-polls | 2.2.15 | | | fof-cookie-consent | 1.1.3 | | | flarum-statistics | v1.8.1 | | | flarum-mentions | v1.8.5 | | | flarum-markdown | v1.8.1 | | | flarum-likes | v1.8.1 | | | flarum-lang-english | v1.8.0 | | | flarum-emoji | v1.8.1 | | | capybash-magicbb | v3.1.1 | | | blomstra-realtime | 0.3.3 | | +-----------------------------------+---------+--------+ Base URL: https://fbsfb.com Installation path: /home/fbsfb/htdocs/fbsfb.com Queue driver: redis Session driver: redis (Code override. Configured to file) Scheduler status: Active Mail driver: mailgun Debug mode: off

After getting PWA removed, I was able to install those ^

huseyinfiliz

I’d like to clarify something. I also had to remove the PWA extension due to dependency issues. It’s not something difficult to fix.

In the email you sent me, you mentioned that you wanted it to be updated for Flarum v2 as well.

My preference would be for the current maintainer to continue updating the extension. I’d also really like to see Darkle take it over.

https://discuss.flarum.org/d/38244-flarum-ai-auto-reply/3

The PWA extension requires kreait/firebase-php v5.x, which prevents guzzlehttp/guzzle from being updated to 7.10+.

In my case, removing the PWA extension first solved the problem. After uninstalling PWA, I manually updated the following packages:

IanM

I previously discussed these extensions with @luceos (he was/is in contact with the author).

The current plan is to move these extensions into the FoF namespace, patch them up for 1.x and then begin the refactoring to 2.x. I simply just have not got around to doing this just yet.

@huseyinfiliz and or @Darkle would you perhaps be willing to assist with this, if you have any time?

huseyinfiliz

IanM Yes, I can make some time for this, but I believe @Darkle is more experienced in this area. So, I’d like to wait for Darkle’s response first.

I’m also planning to contribute to updating some FoF extensions to 2.x.

Darkle

IanM huseyinfiliz Sorry for keeping you waiting, it's great to hear about the plan to move the extension under the fof umbrella. How could we help with that, starting with the renaming and maintenance for 1.x?

As for me, I’m definitely short on time for at least the next month, and I don’t want to hold things back, so maybe I can take care of that part, and @huseyinfiliz can handle the update to 2.x? Since he's planning to update other exts, I'm sure he'll have a better grasp of it.

IanM

huseyinfiliz So, I’d like to wait for Darkle’s response first.

Sure thing, no problem at all 🙂

huseyinfiliz I’m also planning to contribute to updating some FoF extensions to 2.x.

Wonderful news! If I can help in any way to get you started, please reach out and let me know! We could potentially even grant you write access to the repo(s) to help things along. 💝

huseyinfiliz

IanM After doing some research on extension development for Flarum 2.x, I started working on making the FoF User Bio extension compatible with version 2.x. After a few hours of work, I managed to install FoF User Bio on Flarum 2.0.0-beta.3. I’m still at the beginning of the process, but I wanted to share that I’ve started working on it.

IanM

huseyinfiliz wonderful, I've moved this to "in progress" in the Friends of Flarum — 2.0 Beta Compatibility Progress thread, and also created the 2.x branch on FoF User Bio ready for when you open the PR 🙂

huseyinfiliz

Darkle This is fine for me. I think the dependency update is more critical for the 1.x branch — it’s causing dependency conflicts with other extensions.

IanM

huseyinfiliz

Darkle

Nice one guys! I've moved the repo over: FriendsOfFlarum/pwa

Feel free to make a start on the 1.x maintenance as you can, and shout if you need anything from my side!

huseyinfiliz

IanM Do you have a chance to test the “fof user-bio” extension?
If the 2.x migration was successful, I can start working on the other extensions as well.

DaleZ

IanM some of PR still in the original repo and they're important - is it needed to open the same PR in FriendsOfFlarum/pwa?

IanM

huseyinfiliz I've not yet, I'm currently working on flarum/gdpr. To make things easier for me, could you please open a PR with your changes to user-bio, and target the 2.x branch? 🙏