OP has to manually sub his own discussion to get notification of replies?

echolocked

Observation: Discussion Creators Don't Receive Reply Notifications by Default

flarum/subscriptions v1.8.x

What I observed :

A user who starts a discussion receives no notification when someone replies, unless they have manually clicked "Follow" first.

  // vendor/flarum/subscriptions/src/Job/SendReplyNotification.php

  $followers = $discussion->readers()
      ->select('users.id', 'users.preferences', 'discussion_user.last_read_post_number')
      ->where('users.id', '!=', $post->user_id)   
      ->where('discussion_user.subscription', 'follow');

A discussion creator's subscription state in discussion_user is NULL until they explicitly choose a subscription option. so they're excluded from notifications, if other users reply by simplying typing in the composer(not by clicking "reply")

Question: Is this intentional?

I created a froked subscription extension that auto sub the OP so that he always gets notified. Am I doing it properly or is there other recommended way?

Thank you for your help.

ernestdefoe

echolocked try this extension and maybe you can enable that setting in it. https://discuss.flarum.org/d/18607-friendsofflarum-default-user-preferences

huoxin

echolocked You can have a look at my extension for auto follow when user create a discussion: https://discuss.flarum.org/d/34680-auto-follow-discussion

That said, I’d also be interested in discussing this with other members. Should this behavior actually be part of the core's extension Subscriptions?

Currently, the Subscriptions extension only provides Automatically follow discussions that I reply to. Enabling this will also make users automatically follow discussions they create, but it’s not exactly the same use case. Some users may not want to follow every discussion they reply to.

In contrast, automatically following discussions that a user creates seems like something that could reasonably be enabled by default, since discussion creators usually want to know when someone replied to their discussion.

andrewjs18

huoxin yes, it should be an actionable setting in the core, imho.

echolocked

I ended up with a fork of flarum/subscriptions by adding a single backend listener, FollowAfterStart.php:

public function handle(Posted $event)                                                                                                                                                    
{
  $post = $event->post;
  $actor = $event->actor;

  if ($post->number !== 1 || !$actor || !$actor->exists) {
      return;
  }

  $state = $post->discussion->stateFor($actor);

  if (!$state->subscription) {
      $state->subscription = 'follow';
      $state->save();
  }
}

Registered in extend.php:
(new Extend\Event())->listen(Posted::class, Listener\FollowAfterStart::class)

I also backfilled DB to patch all existing discussions:

Agreed that this belongs in core as an opt-out setting rather than requiring a fork or third-party extension.

echolocked

maybe should retag this discussion to Proposals?