FYI: post_count of 0 makes discussions invisible for logged-out users

Biff

The issue (which is solved)

I recently migrated from Vanilla to Flarum using the migration script someone kindly wrote.

It's all working great with 2.0 rc4, except for one strange thing: all discussions were visible to logged-in users, but some discussions were not visible when they were logged out (and thus wouldn't be visible to members of the public who don't have accounts).

After comparing the attributes in my SQL database, I noticed that the invisible discussions had 0 in the comment_count column. Setting it to 1 caused the discussion to become visible to logged-out users! I ran a command to find all the discussions with 0 comment_count and set them to 1, and there were 190 of them!

Strangely, there was no visible difference in Flarum between discussions with 0 comment_count and those with 1 -- they all had no posts. I'm assuming this is an artifact of migrating from Vanilla, but it would be good to have something in place to handle this.

Cheers!

Edit: removed SQL command and corrected typos in my post -- I said post_count but meant comment_count.

luceos

Biff I'm assuming this is an artifact of migrating from Vanilla, but it would be good to have something in place to handle this.

Hello and welcome to the community.

I think this is an issue of the migration tool. Flarum has plenty of logic built-in to handle edge cases where this meta value might need invalidation. Best thing to do is report this issue with the author of the script.

The best solution probably would have been to recalculate the meta with a command as this 1.x extension does: askvortsov1/flarum-recalc-meta. With your comment_count set to 1, any reply will auto update this value now as well.

Also, I highly recommend removing the SQL provided. The import script has made a mistake, running this SQL will cause the meta values of all discussions to become invalid by anyone assuming this will fix it for them.

Biff

Thank you for the welcome!

The script hasn't been updated in years, so it's not surprising there was a problem. I don't even know if the creator is around anymore.

I have deleted the SQL. I'm not sure why it would cause meta values to become invalid though. The posts that were invisible became visible when I ran the command, but nothing else happened to them. And as I said, they all had zero replies, regardless of whether they had a 0 or 1 in comment_count.