There is no need to rush, for a diamond to become a brilliant it needs to be polished...
Found what looks like a related regression in the same area: external links
(links to a different domain, e.g. youtube.com) inserted via the post editor's
"insert link" button now open in the same tab/window instead of a new one.
Historically, Flarum core has added target="_blank" rel="noopener noreferrer"
to all external links in post content (see flarum/framework859 from the 1.x
era, where this was implemented in Formatter.php). This appears to no longer
be happening as of rc.8.
Steps to Reproduce:
- Create a new post
- Use the editor's "insert link" toolbar button to add a link to an external
site (e.g. https://youtube.com) with some link text
- Submit the post
- Click the rendered link
Expected: Link opens in a new tab (as it historically has).
Actual: Link opens in the same tab, navigating away from the forum.
This may share a root cause with the internal-link redirect bug reported in
#5012 β both point to the link-attribute logic in Formatter.php possibly
having regressed during the 2.0 rewrite.
Environment: Flarum core 2.0.0-rc.8, same install as #5012.