Permissions aren't working?

deseven

I've just installed the latest beta 6 and can't figure out how to use the permissions system.
Right now i have this:

As you can see, only admins can start discussions. But that simply doesn't work. I created a test user and i'm able to create a discussion anywhere.
Am i missing something?

Kulga

That is interesting.
Are you using any caching like Zend Opcache? If so, make sure any caches are cleared and fully refresh the page where it appears you can create the discussion (from the test user). Then try to actually submit it and see if it works.

Flarum is a "single-page" app, so sometimes it won't catch up to changes like "Can't create threads anymore". However, if you actually try to submit a post, it'll fail with a "Permissions failed".

If none of that helps, consider trying to replicate it on Devflarum and repost here with step by step instructions

deseven

Kulga nope, that's not a caching problem, i actually can create discussions and post replies with permissions settings like on the above screenshot.
I tried to reproduce it on Devflarum with no luck. I configured exactly the same permissions and enabled exactly the same set of extensions, but everything works fine.
I also set debug to true in config.php in my setup (since in beta 6 it turned off by default), but there are no errors in logs.

DianTama

Having the same issue.
Permission not working for me..

deseven

I've managed to reproduce it on Devflarum.

Set global and tag permissions like that:
Login as user, check that you can't create discussions.
Set permissions to this:
On this step you can easily start discussions with any tags you like. Global permissions are completely ignored.
As a last step, just remove INFO tag permissions:

And that's it.

deseven

And this is my permissions table:

So, i see at least two bugs here:
1. Removing tag permissions in admin panel doesn't remove permissions in database.
2. If there are tag-based permissions, global permissions are ignored.

Should i create an issue(s) on github?

Toby

deseven Thanks for looking into this and writing up a detailed report.

Should i create an issue(s) on github?

Yes please!

deseven

Toby ok, done

deseven

@Toby i saw that you assigned beta7 as a milestone for this issue, but i believe that it should become a hotfix for beta6 instead. With so much time between releases (half a year or even more), it's kinda rude to leave users with it.
Yes, it's beta, i know, but still...

I'm pretty sure that i'll be able to fix it myself and send you a pull request, but if it'll be delayed to beta7 then it's kinda useless for average Flarum user.

In general, all critical bugfixes have to be released outside of the typical release cycle.
What do you think?

Toby

deseven I agree that this is a high priority fix. The current 0.1.0-beta.X numbering scheme doesn't really allow for "hot fix" version numbers, so we'll release beta 7 with a fix (and any others that crop up during the next few days) and then the next "major" release will be beta 8. All the more reason to finally get out of beta ?

Digital

Turnip Hi there, I kindly suggest that you create a new topic for that question.

Brokenshield

I've noticed the same issue on my clean install of Flarum. Good to know it is being looked into, keep up the good work.

deseven

So, @Toby wrote a patch for that.
If you really need working permissions right now you can apply it manually or use this diif.

AngelAvila

deseven Would you mind showing me how can I use the diif?

Thank you in advance.

deseven

AngelAvila sure.

# go to your ext-tags extension location (assuming you're currently in your flarum root directory)
cd vendor/flarum/flarum-ext-tags

# download patch file
wget https://github.com/flarum/flarum-ext-tags/commit/5f126049eead78d4a25eec0edfbe5f969465b253.diff

# apply patch
patch -p1 < 5f126049eead78d4a25eec0edfbe5f969465b253.diff

# remove patch file
rm 5f126049eead78d4a25eec0edfbe5f969465b253.diff

No need to clear cache or anything else since it changes internal logic only.

AngelAvila

deseven Thank you so much, sir. You are really kind! Every step worked perfectly.

Toby

Just released v0.1.0-beta.7 of the tags extension containing this fix – run composer update to get it.

AngelAvila

Toby Thank you! but, I just used @deveseven method to solve the issue temporaly. Does it break anything with the new update or anything wrong happens?

jordanjay29

AngelAvila It will overwrite your current files if you run composer update. If you applied the fix manually, and don't have any abnormal behavior, you're probably okay.

AngelAvila

jordanjay29 Amazing, thank you so much guys!

luceos

jordanjay29 if you encounter issues, simply delete the vendor map and run composer update again.

rm -rf vendor
composer update