FriendsOfFlarum upload, the intelligent file attachment extension

clarkwinkelmann

SnakePromise the update path from Flagrow to FoF requires to first update to at least Flagrow Upload 0.5.0 before switching to FriendsOfFlarum. If you jumped directly from a pre-0.5.0 version to FriendsOfFlarum you're likely missing 5 different migrations.

You should be able to do that without stopping at another intermediate Flarum version as Flagrow Upload version 0.5.0 can be installed on Flarum beta 6.

Now if you want to fix the database manually that's also an option, you can take a look at the migrations you're missing here https://github.com/FriendsOfFlarum/upload/tree/0.5.0/migrations If you don't have the UUID I suspect you're missing migrations starting from 2017-04-14.

Alternatively you can also take a look what the files table is expected to look like when installing the FriendsOfFlarum version here https://github.com/FriendsOfFlarum/upload/blob/master/migrations/2020_02_06_05_create_files_table.php

SnakePromise

clarkwinkelmann You are right, it seems that I skipped upgrading Flagrow Upload and went from 0.4.7 to FOF Upload. I'll work out what will be the easiest way to correct that. Thanks!

SnakePromise

clarkwinkelmann

Tried to upgrade from another old beta installation to flarum 1.0.4. Everything went smoothly, remembered to first upgrade to newer Flagrow Upload version (0.5.0) and only then to FOF Upload. Migrations went well. I can now upload new files. However when clicking on My Media, I get an error. I enabled debug and this is what it shows (I edited my url and directory structure):

500 Internal Server Error

GET https://my-server.eu/api/fof/uploads

Error: Call to a member function preview() on array in /my-server-directories/flarum/vendor/fof/upload/src/Helpers/Util.php:153

Stack trace:
#0  ……… (many lines)

Ir this error connected with the upgrade or have I just configured my sever incorrectly?

huuduy216

robinodds same here. Is anyone else experiencing this?

Nicolas

huuduy216 same here, for the moment i have stop imgur integration, ... sad 🙁

luceos

I just sent in a PR to fix the issue with imgur. Can any of you test the branch by setting the composer.json constraint of fof/upload to dev-dk/imgur-issue-json-deprec and running composer update? Feel free to reset it afterwards.

clarkwinkelmann

I have just opened two PRs to fix the recurrent reports about file extensions and the ability to use embeds provided by other extensions.

For the files extension, I believe the safest solution is a whitelist that the forum owner can provide. This is the solution proposed in the PR.

The embed thing will probably include (minor) breaking changes for custom template developers. If anybody here is using custom templates your feedback is welcome.

Feedback on the implementation is welcome https://github.com/FriendsOfFlarum/upload/pulls

luceos

I guess using formdata instead of json as payload for imgur should fix it.

Nicolas

luceos I guess using formdata instead of json as payload for imgur should fix it.

How i can do that ?

sizonov_stas

is this extension RIP?

clarkwinkelmann

sizonov_stas if you are referring to the Imgur issue, we haven't yet figured what the issue is. If you can provide more details to help us troubleshoot you're welcome. Or if you have access to a dev setup and can try modifying the extension to use a different upload format as described by luceos this will also be helpful. Without more details this will have to wait until an FoF member can try to replicate and troubleshoot themselves.

If you have a different issue please give us more details.

sizonov_stas

clarkwinkelmann
Failed to execute ‘postMessage’ on ‘DOMWindow’: The target origin provided (‘https://s9e.github.io’) does not match the recipient window’s origin (‘null’).

instead of a blue square there should be a picture

clarkwinkelmann

sizonov_stas your issue appears to be with the MediaEmbed feature which is part of Flarum's TextFormatter and enabled by the FoF Formatting extension.

Was that image uploaded through FoF Upload? If so it looks like some kind of conflict between the two extensions because files uploaded through Upload shouldn't be rendered by MediaEmbed.

sizonov_stas

clarkwinkelmann Was that image uploaded through FoF Upload?

no, it doesn't. it was directly link to imgur

clarkwinkelmann If so it looks like some kind of conflict between the two extensions because files uploaded through Upload shouldn't be rendered by MediaEmbed.

it was blocked by Privacy Badger 😄

but I can’t upload the picture either ff or chromium

clarkwinkelmann

Nicolas this requires editing the extension source code. Check out the Imgur adapter under src/Adapters and the Guzzle documentation together with Imgur API documentation.

User18

The other imgur extension still works, so you might be able to reason about why from looking at its source code. https://github.com/matteocontrini/flarum-imgur-upload

Cornelius

Hey there. I just recently installed the upload extension and configured it with the suggested "all allowing" mime type. When I try to upload a file I get the follow error:
"errors":[{"status":"404","code":"not_found","detail":"Flarum\\Http\\Exception\\RouteNotFoundException: \/fof\/upload ...
The file won't upload. (it was a small sized image, jpeg and later png). Also which folder is supposed to be the upload directory? because a "files" directory hasn't been created in assets.
I was wondering if anyone experienced that kind of error before. I am trying to fix the issue for some days now and am happy for any pointers. 😀

clarkwinkelmann

Cornelius is your Flarum in a subfolder? Can you check in the browser console which URL it's trying to use to send the file?

If you use the local adapter, a files directory will be created in assets when the first file is successfully uploaded.

Cornelius

clarkwinkelmann
Hi and thanks for your help. I just checked. I am running flarum on a subdomain.

POST https://forum.mydomain.de/api/fof/upload

the full error stack looks like this:
{"errors":[{"status":"404","code":"not_found","detail":"Flarum\\Http\\Exception\\RouteNotFoundException: \/fof\/upload in \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/DispatchRoute.php:58\nStack trace:\n#0 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\DispatchRoute-\u003Eprocess()\n#1 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/SetLocale.php(50): Laminas\\Stratigility\\Next-\u003Ehandle()\n#2 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\SetLocale-\u003Eprocess()\n#3 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/CheckCsrfToken.php(37): Laminas\\Stratigility\\Next-\u003Ehandle()\n#4 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\CheckCsrfToken-\u003Eprocess()\n#5 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/AuthenticateWithHeader.php(55): Laminas\\Stratigility\\Next-\u003Ehandle()\n#6 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\AuthenticateWithHeader-\u003Eprocess()\n#7 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/AuthenticateWithSession.php(32): Laminas\\Stratigility\\Next-\u003Ehandle()\n#8 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\AuthenticateWithSession-\u003Eprocess()\n#9 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/RememberFromCookie.php(51): Laminas\\Stratigility\\Next-\u003Ehandle()\n#10 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\RememberFromCookie-\u003Eprocess()\n#11 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/StartSession.php(61): Laminas\\Stratigility\\Next-\u003Ehandle()\n#12 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\StartSession-\u003Eprocess()\n#13 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Api\/Middleware\/FakeHttpMethods.php(29): Laminas\\Stratigility\\Next-\u003Ehandle()\n#14 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Api\\Middleware\\FakeHttpMethods-\u003Eprocess()\n#15 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/ParseJsonBody.php(28): Laminas\\Stratigility\\Next-\u003Ehandle()\n#16 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\ParseJsonBody-\u003Eprocess()\n#17 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Middleware\/HandleErrors.php(57): Laminas\\Stratigility\\Next-\u003Ehandle()\n#18 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Flarum\\Http\\Middleware\\HandleErrors-\u003Eprocess()\n#19 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/MiddlewarePipe.php(84): Laminas\\Stratigility\\Next-\u003Ehandle()\n#20 \/var\/www\/mydomain.de\/flarum\/vendor\/middlewares\/request-handler\/src\/RequestHandler.php(84): Laminas\\Stratigility\\MiddlewarePipe-\u003Eprocess()\n#21 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Middlewares\\RequestHandler-\u003Eprocess()\n#22 \/var\/www\/mydomain.de\/flarum\/vendor\/middlewares\/base-path-router\/src\/BasePathRouter.php(97): Laminas\\Stratigility\\Next-\u003Ehandle()\n#23 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Middlewares\\BasePathRouter-\u003Eprocess()\n#24 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Middleware\/OriginalMessages.php(42): Laminas\\Stratigility\\Next-\u003Ehandle()\n#25 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Laminas\\Stratigility\\Middleware\\OriginalMessages-\u003Eprocess()\n#26 \/var\/www\/mydomain.de\/flarum\/vendor\/middlewares\/base-path\/src\/BasePath.php(53): Laminas\\Stratigility\\Next-\u003Ehandle()\n#27 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/Next.php(61): Middlewares\\BasePath-\u003Eprocess()\n#28 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/MiddlewarePipe.php(84): Laminas\\Stratigility\\Next-\u003Ehandle()\n#29 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-stratigility\/src\/MiddlewarePipe.php(73): Laminas\\Stratigility\\MiddlewarePipe-\u003Eprocess()\n#30 \/var\/www\/mydomain.de\/flarum\/vendor\/laminas\/laminas-httphandlerrunner\/src\/RequestHandlerRunner.php(96): Laminas\\Stratigility\\MiddlewarePipe-\u003Ehandle()\n#31 \/var\/www\/mydomain.de\/flarum\/vendor\/flarum\/core\/src\/Http\/Server.php(42): Laminas\\HttpHandlerRunner\\RequestHandlerRunner-\u003Erun()\n#32 \/var\/www\/mydomain.de\/flarum\/public\/index.php(26): Flarum\\Http\\Server-\u003Elisten()\n#33 {main}"}]}

i was yet unable to resolve the issue sadly..

Cornelius

clarkwinkelmann hello again. Do you have yet another idea how my issue a few posts up can be resolved or what might cause it? I'm still stuck.

piperzeng

Hey! I installed FOF/uplaod and I encountered a problem: when I copy and paste from word.doc to Flarum using IOS&Chorme, my text become an image. No issue with Safari.
May I know if there is any solution now?
Thank you so much!

clarkwinkelmann

piperzeng that's a known issue FriendsOfFlarum/upload220

You can paste text by using CTRL/CMD+SHIFT+V.

Unfortunately I have been unable to reproduce with Office 360 in a Windows virtual machine so I haven't been able to test the possible solutions described in the issue yet. If we need a special Word file to reproduce, could you maybe share an example Word file on GitHub that allows me to reproduce?

piperzeng

clarkwinkelmann Thanks for your prompt reply!

Sorry that I don't have any special word file to provide and I don't think it is the issue with a specific Word file. Anyway, my friend found this issue using Word and Chrome on his Macbook. There is no issue with Safari. I didn't meet similar issue in windows.

But anyway I think it is not really a big issue.

« Previous Page Next Page »