FriendsOfFlarum upload, the intelligent file attachment extension

Flatum

I've set the extension up but it appears the BBCode isn't working correctly. When an image is uploaded, something like the following gets inserted into the post:

[upl-image-preview url=https://example.com/assets/files/2019-12-29/1577642069-84037-myPic.png]

And that is how it remains. The link is clickable, but the image isn't exactly embedded and it's obvious this isn't how it's supposed to behave.

I'm not really sure how to go about troubleshooting this. Flarum and this extension are both up to date.

clarkwinkelmann

Flatum try clearing the cache via the admin panel or php flarum cache:clear, then edit and save the post again (you have to change at least one character).

It's possible the old version of the text formatter is still being used and is not aware of that new bbcode added by the extension.

Flatum

clarkwinkelmann Thank you very much for the speedy response! I swear I'd tried clearing the cache but apparently not.

For my own purposes, I plan to make a few modifications (I don't know what I'm doing when it comes to Flarum extensions and currently have higher priorities):

Keep a copy of the original file when resizing so that I can recompress later without generation loss. Today's post content is 760px wide but tomorrow's might not be. This could (implementing it is not a priority for myself) also be used as a means of serving a reduced-resolution version but allowing users to click through to the original version, which would be beneficial for instances such as when someone uploads a screenshot of their entire screen.
Generate a WebP version of images, which gets served to compatible browsers. Maybe also a lower resolution for mobile/narrow devices. I'm aware avatars aren't WebP, but that's another matter since that's core stuff.
Convert lossless to lossy when beneficial for filesize.
Configure the compression. I've not yet investigated exactly what the extension does, but I'm quite picky about what I believe the best JPEG settings are, even down to the DCT method.
Add a video preview template. If contributing to the public source code, I'd probably add one for audio while I'm at it. Ideally ffmpeg would kick in to generate a thumbnail and compress the video after upload if it meets some requirements (in my case 720p and up to 30 seconds). Only one video would be encoded at a time, and with a high niceness to reduce impact on website speed. The user would not have to wait for the video to be compressed - the original would be shown until the compressed version is ready.
Replace upl-image-preview with the default image markup, or make it so there's actually some benefit to upl-image-preview, such as referring to attachments by an ID instead of URL (I wouldn't sort out the latter idea myself because the current setup works and URLs can be rewritten).
Improve the upload process with a progress bar and cancel button, and make it so the user can't send the post before the upload has completed. Somehow, this sounds trickiest.

Things I wouldn't implement myself but would like to see include:

The ability to view all the attachments on the website, from the admin panel. This would make it easier to spot any problematic attachments.
Automatic purging of files that get uploaded but not included in a post within 48 hours (doesn't matter exactly how long, as long as it's long enough to be confident the post has been abandoned).
Different filesize limits for different types of uploads.
User quotas.

I know waffling on about all this might seem a little pointless, but if there's anything straight-forward I've listed I'll work on (not ffmpeg, not progress bar), you (everyone) may be able to change the order I sort these things out (if I do sort them out) and benefit from getting a copy of my modifications.

clarkwinkelmann

nfr472xb that's indeed not implemented. I don't think there's any plan to implement that feature anytime soon.

However our friend above sounds like he will be implementing it as it's liked to one of their proposed additions, but I don't know if they plan to open-source their changes.

Flatum Automatic purging of files that get uploaded but not included in a post within 48 hours

nfr472xb

nice work sir
i find the Database have discussion_id and post_id but no data
do you have plan to finish it ?

Flatum

clarkwinkelmann You missed part of my post.

Things I wouldn't implement myself but would like to see include:

I should investigate what the plugin does with the database, as I'd assumed it only really gets used for storing configuration settings.

I'd be happy to open source any changes of interest. The only thing is, I can get away with hardwiring more things if I'm developing for private use only! :P

clarkwinkelmann

Flatum You missed part of my post

oops, my bad 🙊

Flatum I can get away with hardwiring more things if I'm developing for private use only!

Makes sense. Do what suits you best 😉

Flatum I should investigate what the plugin does with the database

There's a table containing all the files. But as discussed above, it doesn't say if/where a file is used on the forum. So it would require parsing all posts to find if a file is still referenced somewhere. There were some plans to set a discussion and/or post ID, but it's a bit tricky for new discussions/posts and was never actually implemented.

Littlegolden

I can't turn off the Wartermark button. It will turn on again, when I refresh the browser.

luceos

Littlegolden I think this might be caused by Flarum not being able to delete the watermark file. The file name of the watermark is stored in the settings table of your Flarum database, you can clear that entry (set to NULL) to unset/remove it manually.

Littlegolden

luceos Thank you! This works!

Powermage

Is there anyone that has solved the rotation issue (and is willing to share to solution) with the upload plugin and watermarking pictures.
we have a lot of mobile users and on a lot of the uploads the orientation is incorrect.

mrothauer

Powermage
I do not know if your rotation issue is the same that mine (portrait images were never rotated), but I resolved it by manually adding this commit (new version is not yet released).
FriendsOfFlarum/upload14de622

Sidou

Swaggins same here, did @Pherinos helped you ?

Pherinos

Sidou I don't use watermark for the moment.
I use it on my site because I generate a video every night, but it's batch level server

NorioDS

Is there a known issue for Flagrow Upload to not show the S3 option? I only see "Local" and "Imgur", even though I have all the API keys set up correctly.

(This is on an installation of Flarum where I upgraded from beta-7.x to beta-11.)

NorioDS

Whoops! Turns out I was just missing the Flysystem lib.

NorioDS

I found a real issue with with the S3 driver. (The issue is actually with Amazon's certificate.)

The URLs used in the latest version are like this:
https://<bucket-name>.s3.eu-central-1.amazonaws.com/<path-to-file>

They used to be:
https://s3.eu-central-1.amazonaws.com/<bucket-name>/<path-to-file>

Obviously the first one looks better than the second but... but but but...

Amazon's certificate is broken for *.s3.eu-central-1.amazonaws.com which means if your forum is using HTTPS, then those images from Amazon won't load.

My proposal is to switch back to the previous URL structure. That still works.

Alt

Hi all! How can I make a FULL preview for photos, and download menu for files with a download button?
Files:

Photo:

mrothauer

Alt

These settings work for full preview images and download-link for pdf. just adapt the second regex if you want to allow more filetypes.

Img: Last dropdown option selected
Pdf: First dropdown option selected

Alt

mrothauer Thanks! This realy work!

« Previous Page Next Page »