Parent tag not automatically added when moving children

clarkwinkelmann

I wanted to report a problem but I think I understood why it behaved like it did.

I wrote a script to import my old "manually built forum" data into a Flarum instance (via SQL commands). My forum categories were copied as standard tags into Flarum. I then re-organized them into a similar tree in Flarum (after the initial import).

I wanted them to be displayed the same way as here on Discuss, with the primary and secondary labels side by side in the discussions list. But only the secondary label was displayed...

I did a few tests and I think I understand: both the primary and secondary tags are stored in the database for the discussion, is that right ? When creating new discussions under the new tag tree, it works. But because only the secondary tag was linked, it was the only one displayed.

Now I will update my script to import both top-level and second-level relations, but I I believe the problem is not only for import scripts.

If I start by creating only a second-level tag, create a bunch of discussions, and then re-organize this tag under a more general one, I get no option to automatically add the parent tag to all the discussions of the second-level tag (easy to reproduce I believe).

Is this the intended feature ? I think it would be nice to provide an option to add the required top-level tag, or at least display a warning that tags may be messed up when changing the tag tree with existing discussions in the database.

Like I said, not sure if this is a bug or feature...

jordanjay29

Yeah, we noticed that here when doing some tag changes as well. Here's an issue for it on Github: flarum/core828

clarkwinkelmann

Didn't see that issue. I will follow the GitHub issue. Thanks :thumbup_tone1:

clarkwinkelmann

For reference, if anybody needs to do this update manually here is some code you can use:

Just create a new Laravel project and add these files in:

app/Console/Commands/FlarumAddParentTag.php:

<?php

namespace App\Console\Commands;

use App\Discussion;
use App\Tag;
use Illuminate\Console\Command;

class FlarumAddParentTag extends Command
{
    protected $signature = 'flarum:addparenttag';
    protected $description = 'Add missing parents tags for all discussions';

    public function handle()
    {
        $discussions = Discussion::all();
        $discussions->load('tags');

        foreach ($discussions as $discussion) {
            $missing_tags = collect();

            foreach ($discussion->tags as $tag) {
                if (!is_null($tag->parent_id) && !$discussion->tags->contains('id', $tag->parent_id) && !$missing_tags->contains($tag->parent_id)) {
                    $missing_tags->push($tag->parent_id);
                }
            }

            foreach ($missing_tags as $tag_id) {
                $this->info('Tag #' . $tag_id . ' was missing for discussion #' . $discussion->id);
                $discussion->tags()->attach($tag_id);
            }
        }
    }
}

app/Discussion.php:

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;

class Discussion extends Model
{
    public function tags()
    {
        return $this->belongsToMany(Tag::class, 'discussions_tags');
    }
}

app/Tag.php:

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;

class Tag extends Model
{
    //
}

And register the command inside app/Console/Kernel.php:

protected $commands = [
    Commands\FlarumAddParentTag::class,
];

Now you can run php artisan flarum:addparenttag to fix all these tags

I had a look at the flarum/flarum-ext-tags source code but I really have no idea how I would add my code into the existing extension O_o (for example a "macro" button inside the tag edit popup)