FriendsOfFlarum Byōbu, well integrated, advanced private discussions

luceos

Hiob I'm going to investigate this issue. Thanks for reporting and I appreciate your support ?

Csineneo

luceos Multiple recipients cause the line wrap, so that the posting frame extends down to the outside of the screen, please check the image below:

luceos

Csineneo I'll be adding a count in an upcoming version and a tooltip with the recipients.

luceos

Tyler clean up cache and run migrations:

php flarum migrate
php flarum cache:clear

Now clear the browser cache too.

Enable debug if you see no change.

MathieuM

luceos
I've not installed any version of the extension, it's my first installation (beta4) and I've got the previous error message when I tried to enable byobu ?

jordanjay29

MathieuM Did you follow his instructions?

drop the table recipients
delete under the table migrations any entry that refers to the flagrow/messaging or flagrow/byobu extension.
then run php flarum migrate

Csineneo

luceos A new issue here,
I gave the members 'create_private_discussions' and 'edit_recipients' permissions. But members can not create or edit.

Then, when a member browsing the posts he/she did not participate will pop up a tips: "You do not have permission to do that".

A 401 error is returned when a member try to creates a private discussion

{"errors": [{"status": "401","code": "permission_denied"}]}

luceos

Csineneo wow, that's not good. I'll take a look asap.

Csineneo

@luceos Is it possible that private discussions will not be publicly accessible after extension is disabled?

luceos

Csineneo no they will become public again. I might need to add a warning for that.. It's either that or deleting all private discussions..

luceos

@jordanjay29 suggested if we use a tag to map all private discussion to and we make it "special" aka invisible somehow, admins could change the visibility of all private discussions after extension de-installation. Might that help Csineneo ?

MathieuM

jordanjay29
Yep, I've done with it and when I try to activate the extension, I got the same error message :/
Any idea ?

luceos

MathieuM you can't get the same message that the table recipients already exists if you just deleted it.. Are you sure the table is deleted when you re-run php flarum migrate?

staion

Maybe when it's uninstalled, make it that asks admin if it should delete all those discussions or just make them visible only to admins?!

luceos

staion love that idea! ?

[deleted]

luceos here's the problem, when we want to update flarum we have to disable third party extensions and the fact that disabling this extension makes all private discussions public is extremely inconvenient and having it deleted private discussions altogether is even worse :/

luceos

[deleted] disabling third party extensions is a recommendation in case those extensions aren't compatible with the new release. Using these private discussions therefor means you have to wait for this extension to be compatible with that new release, before you run the update process. Or if we would go for the suggestion staion proposed disabling the extension before upgrade might allow you to hide everything up front and after enabling it again, make it visible..

Both scenarios are possible.

JRay

[deleted] that's a good point. Is there a way to mark them pending somehow? Maybe tap into the moderate feature.

Or else maybe come up with a way that these never show publicly and turning off the extension just loses (temporary) access to them.

JRay

luceos disabling the extension before upgrade might allow you to hide everything up front and after enabling it again, make it visible..

That's kind of what I was getting at. ?

[deleted]

luceos I don't think you got my point.... What i was saying is that during upgrading since we have to disable all third party plugins we will also have to disable this plugin so we will pretty much have all private discussions set to public and that won't be reversed when we enable the plugin back after the upgrade

« Previous Page Next Page »