FriendsOfFlarum Byōbu, well integrated, advanced private discussions

luceos

MathieuM wish I could take a look to help you out. Contact me on Gitter?

Csineneo

@luceos Another group related issue:

Group recipient are counted as one recipient only, no matter how many users are in this group.

[deleted]

luceos wow that would be a great idea! Please implement it into the next update ?

Csineneo

Feature Request: Allow recipients to leave the discussion.

jordanjay29

Csineneo flagrow/byobu5

Csineneo

jordanjay29 oops, duplicate issue ?

JRay

@luceos FYI the "developer diary" link at top links back to this thread ?

luceos

JRay thanks removed the link

UaMV

Csineneo Sometimes private discussions are not marked on the discussion list until I view this post.

I have also noticed this to be an issue … particularly if I have entered the forum via a user profile URL or the tags page. When I first click back to All Discussions, then the recipients won't show until I have viewed each specific private discussion.

luceos

UaMV although not quite sure where this behavior comes from, it seems its related to adding the recipients model relationships (or their default includes) on the view page. I have something to start investigating with, thanks .. again!

UaMV

I don't know know that it has yet been mentioned, but it would be good to eventually allow control of notifications (email/on-site) for when a user has been included as the recipient of a private message.

luceos Another fun edge case for you, but may give some more insight into this issue… This appears to also happen when one has been included as a recipient in a message tagged with a tag that is hidden from all discussions. Clicking through to the tag does not show recipients until the discussion itself has been visited. Hope that his clear enough.

luceos

Csineneo thanks, I'll have to look into that.

UaMV your comment is a great pointer, thanks.

Csineneo

I set the 'editUserRecipients' permission to Members, but in fact Member can not see the edit menu.
And permissions are false in returned json.

"canEditRecipients":false,
"canEditUserRecipients":false,
"canEditGroupRecipients":false,

luceos

Hiding discussions when the extension is disabled might be half the solution. Because this event is only triggered when you disable the extension from within Flarum. If you decide to run composer remove, all private discussions will be made public anyway. Aside from that, there seemed to be some complications with identifying which extension is disabled, because that value is not accessible (PR pending for the next release). I will be circumventing this though.

amdad

Hey @luceos. This extension will be official Flarum part? Since, it's on roadmap for a long time.

luceos

amdad I have no way of saying that will be true. If it is this easy to add private discussions/messaging as an extension I would not be surprised to see this functionality to be kept outside of the Flarum organisation (core and core extensions).

For who is following my progress on hiding private discussions, it seems I won't be able to do this easily and I'm almost considering waiting for the next release which holds some of my fixes, before adding the functionality needed..

JRay

luceos bummer this was making good progress. I know it's not your fault, but waiting for the next official release could be forever at their release pace. ?

amdad

Thanks for answer. Personally I think this functionality should be optional (as plugin) but supported as a part of official Flarum release. Since PMS always was strong part of forum software.

luceos

JRay thanks, was hoping I could get it done too. But even my hack to circumvent wasn't successful. Will give it another shot soon.

UaMV

I just noticed that private discussions are not excluded where the tag page shows most recent discussion per tag. The discussion title is still displayed as a most recent discussion, even for a user not included as a recipient … at least when viewing the forum as an admin whose not been included.

« Previous Page Next Page »