FriendsOfFlarum Byōbu, well integrated, advanced private discussions

Ganesha604 make sure the slug you selected in the Byobu settings is a slug that matches an existing tag.

Everything is exposed, sometimes it gives such an error. And sometimes the whole site stops working

Is there a way to change/translate the text in the email notification? I only found the titles of the notifications.

When adding users to a private discussion, it would be helpful if the search function did a lookup on the display name rather than just username (both if possible). In the search results it uses the display name already which is good, not sure if the display name was left out of search for a reason.

Juba007 Flarum (and thus this extension) don't have the ability to translate email content yet. However we are working on making that available in B.14 when it gets released.

tankerkiller125 ️

HD3D did you check your notification settings to see if “Someone includes me in a new private discussion” is enabled? If it is, try disabling and enabling it again

Ralkage Yes it is enabled, I tried disabling and enabling but still didn't work
I tried with a new test account, none are receiving notifications for PD, I tried mentioning in PD then it notified for mention only, posting a reply in PD doesn't send a notification either.

HD3D interesting... I'll try to reproduce this on my live forum when I get the chance

cmwetherell you could automate this from an external platform/script, and create the PMs using Flarum's REST API.

So I'm working on a slightly massive overhaul of byobu, moving it closer to being actual private messages. Some of the things that will change in that upcoming release:

• private discussions (PDs) no longer need tags
• a dedicated page for viewing your private discussions with a navigation menu under "all discussions"
• some bug fixes, cleaner code and anything I find that looks awful

What I'm uncertain about right now is whether we want to see private discussions inside our usual "full list" of discussions visible under "all discussions" as well. This was how Byobu worked previously, but was disabled to gradually please the private messaging proponents. So, I'm considering offering the user a toggle in their settings to once again integrate this list into their usual discussion index.

What do you think?

luceos

Wow, all of this seems really relevant ! Especially the independency from tags

luceos What I'm uncertain about right now is whether we want to see private discussions inside our usual "full list" of discussions visible under "all discussions" as well. (...) So, I'm considering offering the user a toggle in their settings to once again integrate this list into their usual discussion index.

Perfect in my opinion

luceos

I think you are addressing important points here. However, I have however solved these issues with some private extensions already.

• The Byobu setting "Specify which tag all private discussions should use" solves the tag issue for me because I only ask for one tag. Furthermore, with a little jquery I have disabled the possibility to select or deselect tags.
• The automatically assigned tag provides a separate page to view my private discussions. The link is where it should be and if you want with a little help from CSS it could look less like a normal tag.
• It's already possible not to display private messages in the full list of all discussions, but not as a preference for each user.

My real concerns relate to the storage of PMs in the regular "discussions" and "posts" tables, separated only by an "is_private" field set to 1. There are so many things that could go wrong with this layout. I remember the beginnings of Byobu, when deactivating the extension (neccessary e.g. for an update) rendered all private discussions public. Only thereafter was the "is_private" field added.

Another example: While I was experimenting with Byobu recently, I managed to make a private discussion public by simply leaving as the last participant. At that point I had thought about giving each participant the possibility to withdraw from a private discussion, including the last participant.

I had expected to make a discussion inaccessible to everyone by doing so (tantamount to deleting it), since now no one should be able to see its contents anymore. A cron job could then purge private discussions without participants. But to my dismay, the exact opposite happened. How can it be that a discussion becomes public without the explicit consent of all former participants? So as the admin I have to be extremely careful to make sure such a disaster could never happen.

A strict separation of the tables would allow me to sleep much better.

Pollux Another example: While I was experimenting with Byobu recently, I managed to make a private discussion public by simply leaving as the last participant. At that point I had thought about giving each participant the possibility to withdraw from a private discussion, including the last participant.

I decided to refactor the whole logic of making private discussions public. That will no longer be possible. Discussions that have or had recipients (participant users or groups) will remain private (is_private) and when everyone "left" the discussion will be soft deleted.

Hope that gives you more peace?

luceos Discussions that have or had recipients (participant users or groups) will remain private (is_private) and when everyone "left" the discussion will be soft deleted.

Hope that gives you more peace?

Great, that's exactly what I intended to do myself.

One more thing: If you use a quote from a public discussion inside a private discussion, content from the private discussion will be exposed in the public discussion via the "xy replied to this" feature. This shouldn't happen. Neither should the content be exposed nor should the bare fact be exposed that there is a private discussion going on.

From user point of view I have only one QOL complain.

If you're starting private conversation with a specific user (via link trough his profile), step with modal which asks to add more users should be skipped.

Pollux these are all great points, never was aware of all that.

hrvoje_hr If you're starting private conversation with a specific user (via link trough his profile), step with modal which asks to add more users should be skipped.

I noticed that as well and have fixed this already