Scroll to bottom does not mark as read

clarkwinkelmann

I've faced this situation randomly on my own Flarum install but now I've faced it twice on Flarum Discuss as well:

Some discussion never get fully marked as read. Even if I scroll to the bottom, it still says there's one new massage left. Refreshing the page, scrolling up and down, changing post, coming back. Nothing changes, There's still a single hypothetical unread message.

These are the topics where it happens: https://discuss.flarum.org/d/5279-trouble-with-flagrow-ads, https://discuss.flarum.org/d/5178-colors-of-on-new-installation

Maybe this unanswered post is related to this issue, but there's not enough details to be certain: https://discuss.flarum.org/d/3204-read-thread-marked-as-unread

I'm using the latest Firefox on Ubuntu, but I think it's not browser related (continue reading !)

I tried to find the source of the issue myself but are still struggling. Here's what I looked:

I wondered if it was related to the split discussion extension, but I couldn't replicate it on my own forum.

On https://discuss.flarum.org/d/5279-trouble-with-flagrow-ads it looks like both comment #41237 and tag event #41240 have the same post number of #6. Betweem them is post number #7. Maybe there's never a read event for #7 because last post has id #6 ?

On https://discuss.flarum.org/d/5178-colors-of-on-new-installation same issue, we have number #1, #2, #3, #2

I guess this id issue is the cause of the problem, but don't know what caused it. Also, it should not be possible to have two identical numbers in the db for a same discussion !?

clarkwinkelmann

I'm digging into the issue, I can sometimes reproduce on my side.

I'm pretty sure Discuss database does not enforce the discussion id <-> post number constraint. On my test setup I get a duplicate key error. It seems here on Discuss there is no check and more than one post gets the same number !

clarkwinkelmann

Other note: now that @luceos added the Solved tag to https://discuss.flarum.org/d/5279-trouble-with-flagrow-ads, there are two posts with number #7 as well. So now the read status work (because the lastest post has the greatest number), but there are still duplicates

jordanjay29

It's hard to test on such a small discussion. Can you find a longer one where this is present?

Maybe test on devflarum if discussions here aren't proving useful?

BTW, there are no deleted posts in either discussion, just in case you thought that might be a cause.

clarkwinkelmann

The culprit is davis/flarum-ext-split, I submitted a PR here https://github.com/dav-is/flarum-ext-split/pull/2

And as already stated, there's probably an issue with integrity checks on the MySQL server of Flarum because it should result in an Integrity constraint violation instead of duplicating post numbers...