MyBB to flarum

MichaelBelgium

The error mysqli object is already closed means it cant connect to database, but i assume you fixed that as it only happened once.

The user group error should be looked into: it's trying to add a user to a usergroup but that usergroup doesnt exist in the flarum database.

either the usergroup failed to migrate (but it exists in mybb db)
the usergroup doesn't exist in mybb database, which results in the same as above

The easiest way to find out what group it tries to access is to debug in my Migrator.php file.
but i forgot what function u can use to write to flarum.log - imma look it up (or someone might be quicker)

Gerriet

HI there ;D
If I leave the groups out, the convert should work or ?

MattyWjeisz

Trying to migrate and I'm getting the 'Oops!' error and the following in the error log:

[2022-08-18 11:28:22] flarum.ERROR: TypeError: Illuminate\Database\Eloquent\Relations\BelongsToMany::save(): Argument #1 ($model) must be of type Illuminate\Database\Eloquent\Model, null given, called in /home/hx9xvmlx8jo1/public_html/owd/discuss/vendor/michaelbelgium/mybb-to-flarum/src/Migrator.php on line 149 and defined in /home/hx9xvmlx8jo1/public_html/owd/discuss/vendor/illuminate/database/Eloquent/Relations/BelongsToMany.php:1147

clarkwinkelmann

I'm curious why the passwords are ~~set~~ (seeded?) to time() during the migration? That seems pretty insecure. The time of migration can be found in the columns that are set to Carbon::now() in the same migration script, or it could be brute-forced pretty easily if you roughly know the week the migration took place on.

If the goal is to set a random unguessable password, PHP has much better methods to generate those. Or even better, leave the column empty so it won't be a valid hash and no passwords will match.

EDIT: after re-reading the code I realize the code might actually set the password to the bcrypt hash of the time, which stores a hash of a hash, so the hash that serves as password is in fact random since it contains the bcrypt salt which is a true random value. If that's the case then it's safe against attacks, but why do something so complicated to generate a random password? It's so slow compared to other options, there's no need to go through 10 rounds of bcrypt hashing if all you need is a random value.

The script ends up doing 2 times 10 rounds of bcrypt for each user, all of that to set an unusable password? This will waste a lot of minutes over a large dataset migration.

MikeBanim

@MichaelBelgium I executed the migration but received the following error:

SQLSTATE[HY000] [2002] Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock'

I ran through each of users/posts/groups/categories individually and this time they all migrated. However, none of my discussions have been assigned their tags :-( there are about 4,000 so re-adding them manually would take a long time! Any ideas?

MichaelBelgium

MikeBanim SQLSTATE[HY000] [2002] Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock'

Doesn't that mean that your mysql server isn't running or wrong user/password?

@clarkwinkelmann The password is just a bcrypt of current time. I'm not sure where you see it's doing it multiple times?

Or even better, leave the column empty so it won't be a valid hash and no passwords will match.

Password field is required (at least at the time of making the extension) so not sure what to put instead tho?

MikeBanim

Never mind - I figured out a workaround by exporting/importing the values via a csv file

clarkwinkelmann

MichaelBelgium bcrypt does multiple rounds of hashing on a value to generate the output. The more rounds, the more secure the hash is, but the more processing power and time it takes (which is the whole point to protect against brute-force). By default PHP does 10 rounds if you don't specify it. If you create a bcrypt hash and then set it as password through Flarum method it's hashed again, so that would be 20 rounds total.

If you are only trying to generate invalid values, that's a lot of processing time wasted when an empty password column or value generated from the system random generator would serve the same purpose. You won't notice much on hundreds of records but on millions of records it can be significant if the server isn't very powerful.

In Laravel seeds and Flarum tests, password hashes to use are pre-generated and stored in constants to make execution faster. My own Flarum migration script has a bcrypt cache implemented to speed up subsequent re-reruns because of how long it adds to the total execution time. Hence why I would recommend to not use bcrypt at all if the goal can be achieved in a more performant way.

If you create the database model manually, you can set the raw value of the password column to an empty string or just random content. It won't be a valid bcrypt hash, so it'll never match any input.

MikeBanim

MichaelBelgium it was about 50000 records through the posts migration when I received that error. However it worked fine the second time I executed it 🤷‍♂️

MichaelBelgium

clarkwinkelmann Ah alright i see! I didn't know User::register() hashes the password, I didn't see it in the source code.

Either way you're right, it's time wasted for the same, invalid values, purpose. I've updated the extension

Gerriet

Hi there ;D
I have now test my little forum zu merge from mybb to flarum. So I have issues in the log and here is the log ;D
https://paste.md-5.net/iqokujahac.shell

I have no idea, what is the fall by me or better in my forum. I hop you can me help me ;D

Greetings

Gerriet

itsjp89

Is this still being developed or is it dead?

luceos

itsjp89 try Nitro Porter, it's a more generic solution: https://discuss.flarum.org/d/31776-nitro-porter-the-inter-software-migration-toolkit

MichaelBelgium

itsjp89 Neither

Whats there to update? It's not being updated as long as its compatible with newest flarum + if mybb doesn't change their database structure

But yeah, like @luceos said you could try it out, I didnt receive any bug reports since months/years so I assume it still works

itsjp89

MichaelBelgium Ya sorry, that's what I meant.

Jbugy

@MichaelBelgium when I try and install this it constantly gives me errors about not meeting certain requirements yet I am on a later date then all, please advise how to install

clarkwinkelmann

Jbugy please copy the error message you receive.

Jbugy

@clarkwinkelmann / @MichaelBelgium

Error code as requested. Thoughts?

Problem 1 - michaelbelgium/mybb-to-flarum[v8.0, ..., v8.2.1] require flarum/core ^1.0 -> satisfiable by flarum/core[v1.0.0, ..., v1.8.3]. - michaelbelgium/mybb-to-flarum[v4.0, ..., v4.2] require flarum/core ^0.1.0-beta.9 -> found flarum/core[v0.1.0-beta.9, ..., v0.1.0-beta.16] but it does not match your minimum-stability. - michaelbelgium/mybb-to-flarum[v5.0, ..., v5.1] require flarum/core ^0.1.0-beta.13 -> found flarum/core[v0.1.0-beta.13, ..., v0.1.0-beta.16] but it does not match your minimum-stability. - michaelbelgium/mybb-to-flarum v6.0 requires flarum/core ^0.1.0-beta.14 -> found flarum/core[v0.1.0-beta.14, v0.1.0-beta.14.1, v0.1.0-beta.15, v0.1.0-beta.16] but it does not match your minimum-stability. - michaelbelgium/mybb-to-flarum[v7.0, ..., v7.1] require flarum/core ^0.1.0-beta.15 -> found flarum/core[v0.1.0-beta.15, v0.1.0-beta.16] but it does not match your minimum-stability. - flarum/core[v1.0.0, ..., v1.8.3] require monolog/monolog ^1.16.0 -> found monolog/monolog[1.16.0, ..., 1.27.1] but it conflicts with your root composer.json require (^2). - Root composer.json requires michaelbelgium/mybb-to-flarum * -> satisfiable by michaelbelgium/mybb-to-flarum[v4.0, v4.1, v4.2, v5.0, v5.1, v6.0, v7.0, v7.1, v8.0, v8.1, v8.2, v8.2.1].

clarkwinkelmann

Jbugy are you running the Composer command in the correct folder?

Can you share your php flarum info output to confirm you are running the latest version of Flarum?

MichaelBelgium

Gerriet Seeing the stack trace this doesn't seem like an error coming from the extension, it's like you're not logged in?

Jbugy Can you try reinstalling? composer remove and then composer require again

Jbugy

Installed composer on windows with the EXE so should work in any directory but I always goto the public folder.

Sure will do @ flarum but I installed it last week

clarkwinkelmann

Jbugy if you kept the public folder, then the correct location for Composer commands is one level higher, in the directory that contains composer.json, flarum and config.php

« Previous Page Next Page »