Some emoticos are broken

Zeokat

I couldn't test all of them but... if i try to add #⃣ , it dont appears on my flarum installation

Tryed into Chrome and FireFox with same result. Is this an error?

For one unknown reason, in my flarum installation the emoticon image links to http://cdn.jsdelivr.net/emojione/assets/png/000023-20e3.png

But here the image is linked OK to http://cdn.jsdelivr.net/emojione/assets/png/0023-20e3.png

clarkwinkelmann

Zeokat For one unknown reason, in my flarum installation the emoticon image links to http://cdn.jsdelivr.net/emojione/assets/png/000023-20e3.png

That's the intended behavior - Flarum does not host these images, it links them to a CDN.

So, no emoji works at all (from what you've tested) ? Maybe it's a cross-origin issue or you have some security settings blocking these images (for example if you have CSP headers) ?

Is there something written in the dev console ? Is it a public install, so I could have a look ?

Zeokat

@clarkwinkelmann I know that Flarum link that image to the CDN, seems that you don't checked emoji links with attention. If you check slowly the emoji links posted, into my install uses a different file 000023-20e3.png while into official forums it uses 0023-20e3.png.

The one linked into my flarum install dont exists, it's why don't work.

I tested many emojis but :hash: :one: :two: don't works, other emojis works good. I don't have any cross-origin issue, neither CSP headers. I tested into fresh install on Ubuntu 16.04 with Niginx+PHP-FPM and Apache+PHP. Always same problem into FireFox and Chrome.

It isn't a public install... was testing into my dev website. I used composer for a fresh install of latest beta.

I just tested :hash: into some flarum forums that are published arround and the result don't works.

You can check here (reply added from FireFox): http://www.openconquer.com/beta/d/7-pagina-web-full/5

Another example to check (reply added from Chrome): https://forums.odobros.com/d/16-hunter-guide/2

clarkwinkelmann

Zeokat oh, didn't see that, sorry.

It happens on my own Forum as well ? What's strange is that it's displayed correctly in the autocomplete popup, but not in the post composer.

One important thing to know is that Discuss runs on dev-master, whereas our forums are on beta6. So this could mean this bug has already been fixed in the source code.

EDIT: it probably has something to do with this line https://github.com/s9e/TextFormatter/blob/master/src/Plugins/Emoji/Parser.js#L46

Zeokat

Thanks @clarkwinkelmann , i think that you are right. I will edit that line manually and test again to check by myself.

clarkwinkelmann

Zeokat be careful, if you edit something in vendor it may be rollback anytime, in particular if you use an extension like Bazaar ⚠

beta6 uses TextFormatter v0.6.1, while master uses TextFormatter v0.8.1. So the change that solve it is probably between the two https://github.com/s9e/TextFormatter/compare/0.6.1...0.8.1#diff-09b6a0da9eea8b307f08e88cedde18ba

Maybe @JoshyPHP knows what changed, he's the author of TextFormatter ?

JoshyPHP

I don't recall exactly but there was a change a while ago when the plugin switched from Twemoji to EmojiOne and a dozen or so emoji (the keycaps, © and ® I think?) may be incorrect if they were created in one version then displayed on another. In that case, it should be fixed by editing the post.