Adding more bbcode

MichaelBelgium

@0E800 Yeah i found an issue, the parse function from the TextFormatter forum bundle (@JoshyPHP ) doesn't parse it fully. Probably because too much tags or some kind?

If anyone wants the full parsed post: click

JoshyPHP

Tags are limited to 10 levels of nesting by default, after that they are ignored. There's a more detailed explanation there: http://s9etextformatter.readthedocs.io/Internals/Limits/

spiridon

Works great!
Only there are problems with the Cyrillic and incorrect slug in tags there, but it's trifle. I made PR fixing this.

I successfully converted the punbb into a mybb and then into flarum.

MichaelBelgium

JoshyPHP Fast question, is there a better way to edit/add custom?

What i mean is like i tried:

$configurator->BBCodes->addCustom('[size={TEXT1}]{TEXT2}[/size]','<span style="font-size: {TEXT1}">{TEXT2}</span>');

But gives Attribute 'size' is not properly sanitized to be used in this context

$configurator->BBCodes->addCustom('[size=large]{TEXT}[/size]','<span style="font-size: large">{TEXT}</span>');

Gives No valid tokens found in size's definition large

And

$configurator->BBCodes->addCustom('[size={CHOICE=large,small,xx-small,x-small,medium,x-large,xx-large}]{TEXT}[/size]','<span style="font-size: {CHOICE}">{TEXT}</span>');

This works but it adds "px" after it in the css. (Example: font-size: x-smallpx;)

JoshyPHP

It depends on what you mean by "better."

The first example fails for the reasons stated in the exception message. If you want to bypass those security checks, you can create an unsafe BBCode.

The second example fails because it doesn't really provide a definition for the attribute. I guess it could interpret it as a single-option choice, but handling this specific case would require more code and it doesn't seem worth it.

The third example should work fine and I don't know why there's a "px" added to it. You probably have another plugin that redefines the BBCode's template.

MichaelBelgium

JoshyPHP The third example should work fine and I don't know why there's a "px" added to it. You probably have another plugin that redefines the BBCode's template.

If you mean an extension with plugin then I gotta say I don't have any special extensions enabled (but I do have installed).
But after adding an unsafe BBCode, the result is the same issue. This is so strange ...

JoshyPHP

Disable everything and you'll know.

MichaelBelgium But after adding an unsafe BBCode, the result is the same issue. This is so strange ...

Well, no, I don't think that's the case. I don't know what you're doing but you need to eliminate all the variables and focus on one thing. I don't know what actual code you ran and I don't know what "result" is the same. You mentioned 3 different BBCodes. If you're using the 3 at the same time then yeah, the first one gets overwritten by the other two.

Post your actual code.

MichaelBelgium

JoshyPHP I know about the overwritting thing obviously, I only use one line

It's just either this

$configurator = new Configurator;

$configurator->rootRules->createParagraphs(true);
$configurator->BBCodes->addFromRepository('B');
$configurator->BBCodes->addFromRepository('I');
$configurator->BBCodes->addFromRepository('U');
$configurator->BBCodes->addFromRepository('S');
$configurator->BBCodes->addFromRepository('URL');
$configurator->BBCodes->addFromRepository('IMG');
$configurator->BBCodes->addFromRepository('EMAIL');
$configurator->BBCodes->addFromRepository('CODE');
$configurator->BBCodes->addFromRepository('QUOTE');
$configurator->BBCodes->addFromRepository('LIST');
$configurator->BBCodes->addFromRepository('DEL');
$configurator->BBCodes->addFromRepository('COLOR');
$configurator->BBCodes->addFromRepository('*');
$configurator->BBCodes->addFromRepository('FONT');
$configurator->BBCodes->addFromRepository('ALIGN');
$configurator->BBCodes->addFromRepository('HR');
$configurator->BBCodes->addCustom('[size={CHOICE=large,small,xx-small,x-small,medium,x-large,xx-large}]{TEXT}[/size]','<span style="font-size: {CHOICE}">{TEXT}</span>');
//$configurator->BBCodes->addCustom('[size={TEXT1}]{TEXT2}[/size]', new UnsafeTemplate('<span style="font-size: {TEXT1}">{TEXT2}</span>'));
extract($configurator->finalize());

$configurator = new Configurator;

$configurator->rootRules->createParagraphs(true);
$configurator->BBCodes->addFromRepository('B');
$configurator->BBCodes->addFromRepository('I');
$configurator->BBCodes->addFromRepository('U');
$configurator->BBCodes->addFromRepository('S');
$configurator->BBCodes->addFromRepository('URL');
$configurator->BBCodes->addFromRepository('IMG');
$configurator->BBCodes->addFromRepository('EMAIL');
$configurator->BBCodes->addFromRepository('CODE');
$configurator->BBCodes->addFromRepository('QUOTE');
$configurator->BBCodes->addFromRepository('LIST');
$configurator->BBCodes->addFromRepository('DEL');
$configurator->BBCodes->addFromRepository('COLOR');
$configurator->BBCodes->addFromRepository('*');
$configurator->BBCodes->addFromRepository('FONT');
$configurator->BBCodes->addFromRepository('ALIGN');
$configurator->BBCodes->addFromRepository('HR');
//$configurator->BBCodes->addCustom('[size={CHOICE=large,small,xx-small,x-small,medium,x-large,xx-large}]{TEXT}[/size]','<span style="font-size: {CHOICE}">{TEXT}</span>');
$configurator->BBCodes->addCustom('[size={TEXT1}]{TEXT2}[/size]', new UnsafeTemplate('<span style="font-size: {TEXT1}">{TEXT2}</span>'));
extract($configurator->finalize());

this, here full file

JoshyPHP

I don't know. Can you provide a standalone file that can reproduce the issue along with the expected output?

MichaelBelgium

JoshyPHP Somehow it works outside of Flarum, but I know what the issue is I guess

Check this post out where the issue occurs. When doing it outside of flarum this perfectly works. Here's the source

What i think is, flarum uses the "default" size tag so I assume flarum "merges" those 2 SIZE tags together, hence putting a pxafter it.

Thats what i think ..

MichaelBelgium

If anyone can help me: MichaelBelgium/mybb_to_flarum6
Seems i just can't find the problem.

JoshyPHP

Your extension is probably executed before the BBCodes extension and your template gets overwritten. If you disable the BBCodes extension you'll get the right [size]. You need to look up Laravel's event system for a way to execute your extension after the BBCodes extension.

« Previous Page