aws flagrow/upload image issue

vabhik

I am using https://github.com/flagrow/upload to upload the files on aws s3, files get uploaded but with the private access, hence UI is not able to render them. How to make this work ? Or I need to make the directory on S3 public?

{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "AddPerm",
"Effect": "Allow",
"Principal": "*",
"Action": "s3:GetObject",
"Resource": "arn:aws:s3:::my_bucket_name/*"
}
]
}

Did this to make the repo public
But images are still not showing up on ui

luceos

vabhik my apologies for the late reply. Busy weekend ?

Can you confirm the value in your database table for the url column? And perhaps it's related to this:

flagrow/upload42

vabhik

luceos
I have figured this out,
in Flagrow\Upload\Adapters\AwsS3 you are setting sprintf('https://s3.%s.amazonaws.com/', $region) as baseUrl for region other than us-east-1
According to this https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html#access-bucket-intro
for Region-specific endpoint we should use this https://s3-aws-region.amazonaws.com/bucket
Here you can see that its '-' instead of '.' after https://s3

For simplicity you can use http://bucket.s3.amazonaws.com (according to the above link) to access the bucket.

Also, I have added support for google storage as well. Let me know if you would want a PR for that.

luceos

Pushed some code that might fix this for you too. Will tag a version in a bit.

luceos

vabhik Absolutely! Please PR asap ? ❤

luceos

vabhik on a side note. us-east-1 is default and from what I gathered it doesn't use a region url, but the default one: https://github.com/flagrow/upload/blob/master/src/Adapters/AwsS3.php#L29

vabhik

luceos
I am using us-west-2 region hence it's hitting the else condition.

luceos

vabhik i'm on eu-central-1 and it seemed to (have) worked ?

vabhik

luceos
I don't know how it is working for you but according to the s3 doc, you should use the given URL format. And for the PR I need to do include translation and a file upload interface on admin to upload the config file required for google storage. It may take time or if anyone can build up over this then it would be fine for me. ?

luceos

vabhik https://s3.eu-central-1.amazonaws.com/test-flagrow-upload/2017-04-24/1493023329-581227-qrcode-file-43d6e-1.png that's one of the files i generated that I've tested with today. Bucket is removed, please be aware.

vabhik

luceos
this one is not working
https://s3.us-west-2.amazonaws.com/tbdiscuss/2017-04-24/1493030659-0-abhishek.png
And this is working fine
https://s3-us-west-2.amazonaws.com/tbdiscuss/2017-04-24/1493030659-0-abhishek.png

luceos

vabhik already pushing the change, hold tight

luceos

Feel free to test 0.5.5

vabhik

Thanks for that

vabhik

There is one more issue I am facing, the resize image functionality on admin is not working properly. @luceos