[Bug?] Incorrect post order when view unread post with same post time?

ganuonglachanh

I import posts from others forum, when I view a discussion with many unread post, and these post in post at the same time (with import script), then the order is incorrect:

post with smaller post_id is displayed below the larger post_id.

If I mark all posts in the discussion to read (viewed) then the order is correct again.

clarkwinkelmann

What's that for an import script ?

Flarum relies on both post numbers and time to fetch and display the correct posts in a topic, so if your import script is giving default/non-unique values to either of these I expect your forum to not behave correctly.

Any reason for not importing the post time from the old forum ?

Also if your old forum didn't have any post numbering feature you should probably regenerate them on Flarum. It won't end well if all posts have the same number ⚠ Your import script should take care of this

ganuonglachanh

Hi, every post has unique post id, but with the same post time. I can change the post time in my script, but let's look at the case when your forum grow bigger, many members reply at the same time (same 1 second), and this bug will happen.

Can we order by time then by post id in Eloquent?

clarkwinkelmann

ganuonglachanh there's post id and post number. Post ids are not important, they may just reflect the order the rows were inserted (it's the unique id in the DB ). number (which should be unique and chronological in a discussion) and time are used to sort them.

Are your numbers correctly set ? Even if two people did post at the same time, these should make the difference.

ganuonglachanh

clarkwinkelmann

Post number is the order of the post in the discussion and I set it correctly. So I guess we should check in the JS code that render the post from API request when post are unread. Unfortunately, my JS is bad so I can't check it myseft :-(