Memory leak while in editor

Alanc

I've just sumbled upon and have been able to reproduce this performance issue
over and over in both Firefox and Chrome.

Each time I am pressing AltGr+] for the second or third time to write the closing tag of

[url=]

In one of my new threads on my Flarum installation, the browser hangs, and immediately I see the memory use in my Task Manager rise from 200MB to 6000MB.

Is there a way I can log something on the background to 'prove' this performance issue?

clarkwinkelmann

Chrome has a web task manager where you can see some details about what's running on a web page. Maybe this can help trace that issue ? (never actually used it)

Toby

@JoshyPHP This might be a live preview issue? Though the instructions the reproduce are a bit unclear, can you please clarify Alanc?

JoshyPHP

I would assume it's related, yes.

@Alanc Can you reproduce it here? What would be the exact steps to reproduce it here?

Can you reproduce the same behaviour on this page or that page?

Alanc

I can't reproduce it on either of the 2 pages you recommended JoshyPHP
but I just took a closer look at the live preview and it seems to be indeed related.

Note: the URL from my clipboard never appears in the live preview, simply trying to paste it
freezes the session and the memory leak starts as shown below in the animated GIF:

"https://www.e-motionthemovie.com/"

JoshyPHP

Can you reproduce it here? Can you provide an easy way for me to reproduce it? For example, something that can be copy/pasted.

A similar bug was fixed a while ago, it could be that your version of Flarum predates it.

Alanc

JoshyPHP
If I use the exact same code, yes, the memory leak is also present here.

Do the exact following when you start a new reply:
1. copy and paste the following BBcode

have the url https://www.e-motionthemovie.com/ ready in your clipboard after pasting the above
under line 5 (where you can already see the url), start typing [url= and then paste your clipboard

At this point the memory leak starts for me.

JoshyPHP

Ok, I confirm that I can reproduce it here with just the following:

[url=]
>.

I'll look into it as soon as I can.

JoshyPHP

It's an old bug. Updating s9e\TextFormatter to a recent version will fix it.

@Toby FYI I'm going to release a new version in the upcoming days. If you update to 0.12, do note that the hosted minifiers have been removed.