Error in Comparator.php

Daeshan

Hello guys, I was trying to install and I seem to have run into an issue with the comparator.php. I have not made any changes. This seems to be a stock issue. I have created my databased and everything but just this issue happens.

PHP Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/tscfvuia/public_html/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Comparator.php on line 512

luceos

Daeshan what version of php do you have installed? Flarum requires 5.6 or up.

Daeshan

luceos Hi, I have 5.6 with fileinfo on. I am now getting the 503 error and I can not update. I get "something wrong" when I do the update.

Daeshan

luceos This is my current error log.

[18-Dec-2017 18:17:13 UTC] PHP Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S02]: Base table or view not found: 1146 Table 'tscfvuia_forum.forumsettings' doesn't exist' in /home/tscfvuia/public_html/vendor/illuminate/database/Connection.php:319
Stack trace:
#0 /home/tscfvuia/public_html/vendor/illuminate/database/Connection.php(319): PDO->prepare('select value,...')
#1 /home/tscfvuia/public_html/vendor/illuminate/database/Connection.php(655): Illuminate\Database\Connection->Illuminate\Database{closure}(Object(Illuminate\Database\MySqlConnection), 'select value,...', Array)
#2 /home/tscfvuia/public_html/vendor/illuminate/database/Connection.php(618): Illuminate\Database\Connection->runQueryCallback('select value,...', Array, Object(Closure))
#3 /home/tscfvuia/public_html/vendor/illuminate/database/Connection.php(324): Illuminate\Database\Connection->run('select value,...', Array, Object(Closure))
#4 /home/tscfvuia/public_html/vendor/illuminate/database/Query/Builder.php(1431): Illuminate\Database\Connection->select('s in /home/tscfvuia/public_html/vendor/illuminate/database/Connection.php on line 662
[18-Dec-2017 18:17:14 UTC] PHP Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/tscfvuia/public_html/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Comparator.php on line 512
[18-Dec-2017 18:18:56 UTC] PHP Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/tscfvuia/public_html/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Comparator.php on line 512
[18-Dec-2017 18:19:24 UTC] PHP Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/tscfvuia/public_html/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Comparator.php on line 512

chaseme

I experienced the same error on PHP 5.6.30.

The problem seems to be an issue with a vendor package.

In vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/Comparator.php around line 512, I see the following:

    /**
     * TODO: kill with fire on v3.0
     *
     * @deprecated
     */
    private function isALegacyJsonComparison(Types\Type $one, Types\Type $other) : bool
    {
        if ( ! $one instanceof Types\JsonType || ! $other instanceof Types\JsonType) {
            return false;
        }

        return ( ! $one instanceof Types\JsonArrayType && $other instanceof Types\JsonArrayType)
            || ( ! $other instanceof Types\JsonArrayType && $one instanceof Types\JsonArrayType);
    }

From my initial research on the issue, in PHP 7 you're now able to specify expected return types.
PHP 5.6 does not support this new syntax, hence the error. Removing the : bool part of the function declaration seems to fix this issue... however this change will get overridden when you update your vendor packages again via composer...

luceos

chaseme it shouldn't be possible to run composer commands on a machine with 5.6 and get packages installed that require 7 or up, the only way I can imagine this happens is when you uploaded the files to a server with a lower php version...

chaseme

Ah! You are so right! That's exactly what I did... ☹
That makes total sense, since composer shouldn't allow that to happen.

I wasn't really looking too closely what version I was running on my computer versus the server.
It was indeed a version mismatch between the two environments.

clarkwinkelmann

chaseme when running composer on your local PC you can specify which PHP version you want packages for. The following should install 5.6-compatible dependencies on a PHP7 install:

(add a platform setting in the config section of the composer.json file of your Flarum)

    "config": {
        "preferred-install": "dist",
        "platform": {
            "php": "5.6"
        }
    },