Spaces/non-ASCII characters in usernames

tankerkiller125

Mark73 Spaces in usernames is always a complex topic and thing to handle. Just for some examples most services do not allow spaces if they also allow mentioning users (eg. github, discord, etc.) as it adds a ton of complexity as to where does the username end and the content begin? General UTF8 would be great to implement in the future, but I think spaces add a whole layer of complexity that for most people isn't an issue. One thing I do think might be good is a UI change if a username has a Nickname set so that both the username and the nickname get shown (like Github does on the profile pages).

Mark73

tankerkiller125 Agree with you regarding the last suggestion

clarkwinkelmann

Reading the source code, Flarum is supposed to show the Display Name in mentions https://github.com/flarum/mentions/blob/master/src/ConfigureMentions.php

And you're also supposed to be able to search via Display Name when mentioning https://github.com/flarum/mentions/blob/master/js/src/forum/addComposerAutocomplete.js#L100

So basically insertion should work just like in Discord, where you can press @, type any nickname you know the user by, and it will insert their actual Discord username even if it's completely different.

In addition, the mention block should show the Display Name in read mode, so discussion readers shouldn't even see the username that was typed in the message.

I have however not tested the Nickname extension. If the above isn't working, consider reporting it as a bug in Flarum.

tankerkiller125

clarkwinkelmann from my own experience with the nickname extension, mentions work the way you describe, and mentions still show correctly after nick name changes, usernames changes or even disabling the extension.

Mark73

clarkwinkelmann tankerkiller125
That's very interesting, I thought that mentioning should be only via usernames and not nicknames. This actually solves it all, thanks guys for pointing it out 🙂

ctml

I would like to see periods allowed. I am trying to integrate through SSO with my existing system with around 10k users. I can replace with another character like dash '-' but those are also allowed in my system, so then I could end up having duplicate users in flarum which would be catastrophic 😃

https://discuss.flarum.org/d/21666-php-and-wordpress-single-sign-on-sso/295

« Previous Page