Hope to add custom style support for these four email notifications.

2 months later

  • [deleted]

  • Post #91

Any chance that this extension can integrate properly with @clarkwinkelmann WordPress extension ? Currently, the email body is blank on all emails.

    [deleted] I believe it's not an issue with Pretty Mail. It's an issue with Follow Tags. The mail body is already blank before Pretty Mail tries to handle it. I have created an issue in Follow Tags but it will require either a hard-coded rule for the Wordpress extension, or a change in core to allow other types of posts to be converted to HTML FriendsOfFlarum/follow-tags7

    EDIT: or do really ALL emails are blank, including those about replies ?

        7 days later

        [deleted] I have dome some tests and I'm not sure I experience everything you've described.

        From my tests:

        • Pretty Mail has nothing to do with the issue. It happens whether Pretty Mail is enabled or not.
        • Posts about new discussions from fof/subscribed output a Warning: htmlspecialchars() expects parameter 1 to be string, array given.
        • Posts about new discussions from fof/follow-tags output a Notice: Array to string conversion.
        • Every other notification works fine.
        • In no case do I experience blank emails. If warnings and notices are hidden, the post body is simply missing, but everything else is visible.

        Is this what you observe ?

        The issue in subscribed and follow tags is FriendsOfFlarum/follow-tags7 and I think a solution should be introduced through core. Maintaining custom code for compatibility with the Wordpress extension in those two extensions is too difficult.

            • [deleted]

            • Post #96

            clarkwinkelmann Is this what you observe ?

            Yes. Exactly that. The issue doesn't issue occur with posts generated directly in Flarum though - only the WordPress generated posts

                a month later

                ok, thank you. i am asking for this extension on freeflarum

                22 days later

                • [deleted]

                • Post #100

                [deleted] Yes. Exactly that. The issue doesn't issue occur with posts generated directly in Flarum though - only the WordPress generated posts

                Circling back here as I now have this issue with posts created directly in Flarum (well, with the API). When someone replies to a thread I'm following, the body of their response is missing.

                    • [deleted]

                    • Post #101
                    • Edited

                    [deleted] Circling back here as I now have this issue with posts created directly in Flarum (well, with the API). When someone replies to a thread I'm following, the body of their response is missing.

                    Confirmed bug in Pretty Mail. When enabled, the body of the message (the post itself) is missing. With the extension disabled, everything works as expected.

                    Can this be looked at ? I quite like the idea of mail branding but at the moment, I cannot use it.

                    Thanks

                        [deleted] are you able to DM me an example email? Please also include any relevant metadata/message details so I can inspect what data isn't being sent and what's actually being sent. Dummy data is much preferred if you are concerned about privacy 🙂 I'll also try to replicate locally in the meantime.

                          • [deleted]

                          • Post #104
                          • Edited

                          @Ralkage @Kyrne @clarkwinkelmann by way of an update, I can now confirm that this extension is suddenly working after applying updates for

                          v17development-seo
fof/sitemap
fof-pages
flarumalshain/slowlastpost

                          One of these updates, and I don't know which, has meant that fof-pretty-mail is now working as intended. Perhaps something in the above was preventing this from functioning properly.

                          9 days later

                          I get 500 Server error after I installed this extension.
                          I did remove the extension using the composer remove, but even then the website does not work.

                          Please let me know what I can do.

                            9 days later

                            Great extension! Is it possible to change the forum title at the top of the mail (<a href="{{ $baseUrl }}">{{ $settings->get('forum_title') }}</a>) to the logo?

                            Additionally, is there any way to replace the link in the email (for example the confirmation link that appears for new members when they sign up) with a button? If it can't be done through the extension, where can I find the files to implement that?

                              6 days later

                              • [deleted]

                              • Post #108

                              Hello, how would i test the default template? I want that it sends me an email

                              4 months later

                              Hello good morning.
                              is there a way to change the welcome email for the new registration?

                              12 days later

                              When sending an email about mail change, I'm getting Call to a member function html() on null. I can see a commit has changed it on master but will there be created a new tag so it can be updated with composer or can I get the updated code in another way?

                              FriendsOfFlarum/pretty-maile6e7b74

                              Getting cannot allocate memory error. But, my Lightsail LAMP VPS has 1.3 G free.

                              bitnami@ip:/opt/bitnami/apache/htdocs$ free -m
                              total used free shared buff/cache available
                              Mem: 1995 498 1257 7 239 1351

                              Any tips?

                              Edit: I wanted to mention I have previously overcome the memory issue with other extensions by removing memory limits in my PHP config file, I changed it to unlimited.

                                Not sure if this is related to flarum core, or FoF pretty mail, but new user signup emails (and perhaps other templates) that are not configurable and rely on the default template, use the users username, rather than display name. For forums where the username is not user friendly the display name should be used in really all places besides user sign in.

                                Is it possible for pretty mail to support more templates, such as user signup so we can ensure the correct fields are used?

                                  danielunited Great extension! Is it possible to change the forum title at the top of the mail (<a href="{{ $baseUrl }}">{{ $settings->get('forum_title') }}</a>) to the logo?

                                  Try replacing that line with <img src="{{ $forum['logoUrl'] }}" alt="{{ $forum['title'] }}" class="Header-logo"> and see if that works 🙂

                                  ctml Is it possible for pretty mail to support more templates, such as user signup so we can ensure the correct fields are used?

                                  I support this 🙏 I will try to look at adding more templates after beta 14 is released seeing as beta 14 is the main focus right now 😃

                                      10 days later

                                      A way to send preview to your own email when you edit the code would be really great.

                                      23 days later

                                      • [deleted]

                                      • Post #116

                                      Wondering if this plugin will be updated for Beta 14 ? I use it frequently to display HTML etc in notification emails, and it would be nice to be able to use it going forward.

                                        • [deleted]

                                        • Post #120

                                        karaok ok, I'll need to create a test replica first to upgrade and then revert. I'm not ready to upgrade production just yet

                                          0.2.0

                                          • beta 14 ready 🥳
                                          • Flarum's UrlGenerator is available to the extension's templates, access via $url in your blade template.

                                          Breaking changes

                                          • ALL templates will require some degree of updating, even when using the defaults.

                                          If using default templates

                                          • Revert to default should be clicked (in /admin/fof/pretty-mail) for all templates
                                          • Save changes
                                          • php flarum cache:clear
                                          • Done

                                          If using custom templates

                                          • Edit each template, noting the following:
                                          • Use of app()->url() is no longer supported at all - replace with $url->to('forum')->base()
                                          • Use of $baseUrl is deprecated in this version - will be completely removed in a future release. As above, use $url->to('forum')->base().
                                          • Save changes
                                          • php flarum cache:clear
                                          • Done
                                          Updating
                                          composer require fof/pretty-mail:^0.2.0
php flarum cache:clear
                                            17 days later

                                            Anyone know if this version uses the display name for new signup emails? In 13 beta, the extension template is hardcoded to username.

                                            5 days later

                                            I have tried saving custom templates, but these errors show up in the console:
                                            I've got the latest Flarum and Pretty Mail extension version.
                                            Thanks!

                                              0.2.1

                                              • Fix intermittent issue where saving templates resulted in a console error (diegoc )
                                              Updating
                                              composer require fof/pretty-mail
php flarum cache:clear
                                                  10 days later