FriendsOfFlarum Pretty Mail

panteLx

[deleted] something is wrong with your a href tag 😃 check it twice

[deleted]

panteLx I just copy pasted your code 😃

datitisev

panteLx [deleted] There's a "> at the end that does not need to be there. Right before </a></p>.

hrvoje_hr

datitisev please can you confirm this? I can't find strings in Linguist extension for email subjects.

datitisev

hrvoje_hr Oh, sorry. Subjects aren't currently translatable in core. This extension does not change that.

[deleted]

datitisev Well apparently i can change the email messages using linguist?

datitisev

[deleted] What email messages? I'm pretty sure core email messages aren't translatable either. Some extensions may have made their content translatable.

datitisev

[deleted] Oh, I didn't realize that email was translatable. Looks like only a few core emails are. But that is explicitly coded. Currently, you can't translate the email subjects.

[deleted]

Anyone else seeing this in their logs ?

[Tue Nov 26 17:05:02.945499 2019] [proxy_fcgi:error] [pid 78117:tid 140489923753728] [client 77.68.89.92:55970] AH01071: Got error 'PHP message: PHP Warning: scandir(/var/www/vhosts/phenomlab.com/forum.phenomlab.com/vendor/fof/pretty-mail/src/Overrides/../../../../public/assets/): failed to open dir: No such file or directory in /var/www/vhosts/phenomlab.com/forum.phenomlab.com/vendor/fof/pretty-mail/src/Overrides/NotificationMailer.php on line 68 PHP message: PHP Warning: scandir(): (errno 2): No such file or directory in /var/www/vhosts/phenomlab.com/forum.phenomlab.com/vendor/fof/pretty-mail/src/Overrides/NotificationMailer.php on line 68 PHP message: PHP Warning: preg_grep() expects parameter 2 to be array, bool given in /var/www/vhosts/phenomlab.com/forum.phenomlab.com/vendor/fof/pretty-mail/src/Overrides/NotificationMailer.php on line 68'

Littlegolden

Hey guys! I want to share you a great template of Pretty Email! Available in Chinese, Japanese, and English。
https://discuss.flarum.org/d/22327-share-a-template-of-pretty-email

[deleted]

Littlegolden This link does not work.

Littlegolden

[deleted] Because this post is still under review, I don't know why it needs to be reviewed. You can also view this post in https://bbs.csur.fun/d/14-share-a-template-of-pretty-email

Littlegolden

Hope to add custom style support for these four email notifications.

[deleted]

Any chance that this extension can integrate properly with @clarkwinkelmann WordPress extension ? Currently, the email body is blank on all emails.

clarkwinkelmann

[deleted] I believe it's not an issue with Pretty Mail. It's an issue with Follow Tags. The mail body is already blank before Pretty Mail tries to handle it. I have created an issue in Follow Tags but it will require either a hard-coded rule for the Wordpress extension, or a change in core to allow other types of posts to be converted to HTML FriendsOfFlarum/follow-tags7

EDIT: or do really ALL emails are blank, including those about replies ?

[deleted]

clarkwinkelmann all emails are blank.

[deleted]

clarkwinkelmann Any more thoughts about this please ? It's still an open issue.

clarkwinkelmann

[deleted] I have dome some tests and I'm not sure I experience everything you've described.

From my tests:

Pretty Mail has nothing to do with the issue. It happens whether Pretty Mail is enabled or not.
Posts about new discussions from fof/subscribed output a Warning: htmlspecialchars() expects parameter 1 to be string, array given.
Posts about new discussions from fof/follow-tags output a Notice: Array to string conversion.
Every other notification works fine.
In no case do I experience blank emails. If warnings and notices are hidden, the post body is simply missing, but everything else is visible.

Is this what you observe ?

The issue in subscribed and follow tags is FriendsOfFlarum/follow-tags7 and I think a solution should be introduced through core. Maintaining custom code for compatibility with the Wordpress extension in those two extensions is too difficult.

[deleted]

clarkwinkelmann Is this what you observe ?

Yes. Exactly that. The issue doesn't issue occur with posts generated directly in Flarum though - only the WordPress generated posts

[deleted]

[deleted] Yes. Exactly that. The issue doesn't issue occur with posts generated directly in Flarum though - only the WordPress generated posts

Circling back here as I now have this issue with posts created directly in Flarum (well, with the API). When someone replies to a thread I'm following, the body of their response is missing.

vaultboy

Does this extension support latest version?

datitisev

vaultboy It should, yes.

« Previous Page Next Page »