FriendsOfFlarum Pretty Mail

datitisev

Gatsu I'm confused as to what you mean with the first two problems.

For #1, are you talking about in emails or...?
And for #2, I don't believe this extension modifies anything user-facing other than the email templates... so the normal forum experience should stay the same.

What's the language extension you're referring to with #3?

Gatsu

datitisev I mean in the forum.

The language is Italian
@Justoverclock

datitisev

Gatsu That should not be caused by this extension.

Gatsu

datitisev For me yes, if I disable the extension I no longer have these problems.

IanM

1.1.0

Allow extensions to register callbacks to provide additional variables to the HTML templates FriendsOfFlarum/pretty-mail27
Webpack5 FriendsOfFlarum/pretty-mail26

Updating

composer require fof/pretty-mail:"*"
php flarum cache:clear

TomaterID

I am trying to integrate professional templates using pretty mail extension, however every time I do change on the forum that is supposed to trigger sending email, I get an error. Mail is not sent. In the logs I see following message:

[2022-05-29 09:46:58] flarum.ERROR: Exception: ParseError: syntax error, unexpected token "&" in /flarum/app/vendor/fof/pretty-mail/src/BladeCompiler.php(28) : eval()'d code:133

I suppose that syntax of template is not 100% html compatible and some symbols should be screened for parser to work, right? Is there any reference for what should be screened or avoided in templates?

Sorry if this is stupid question, but I am not a PHP guy, so bear with me please.

hrvoje_hr

si_edgey I've found a similar issue as the user above

<p><a href="{{!! $url->to('forum')->route('user', ['username' => $blueprint->post->user->username]) !!}}">{!! $blueprint->post->user->username !!}</a> mentioned you in a post in <a href="{{!! $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]) !!}}">{!! $blueprint->post->discussion->title !!}</a>.</p>

This code does not generate any link.

<a href="{{!! $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]) !!}}">

EDIT: It worked on my previous version (0.1.13.)

hrvoje_hr

@si_edgey @FriendsOfFlarum found the issue. Bolded exclamation marks in the code are surplus.

<p><a href="{{!! $url->to('forum')->route('user', ['username' => $blueprint->post->user->username]) !!}}">{!! $blueprint->post->user->username !!}</a> mentioned you in a post in <a href="{{!! $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]) !!}}">{!! $blueprint->post->discussion->title !!}</a>.</p>

clarkwinkelmann

hrvoje_hr is that code inside of the extension? If so can you name the file so we can get it fixed?

Indeed, there are 2 different blade "echo" tags, {{ }} and {!! !!}. But {{!! !!}} is not a thing as far as I'm aware.

In this context either of the valid ones should work, but usually unless there's an explicit reason to use {!! !!} (raw echo) you should always use {{ }} (sanitized echo for HTML context)

hrvoje_hr

clarkwinkelmann yes, that's the default code for user mention notification (second field in the backend)

masihdindar

Hi,
There is one problem in this extension with Flarum 1.5:
https://discuss.flarum.org/d/31599-flarum-v150-released/22
I hope you fix it asap!
Thanks

jsystems73

Hello!
This error appears in some topics when posting a new comment:

[2022-09-15 05:44:02] flarum.ERROR: ArgumentCountError: Too few arguments to function Flarum\Notification\NotificationMailer::__construct(), 2 passed in /www/wwwroot/csapat.org/vendor/fof/pretty-mail/src/Overrides/NotificationMailer.php on line 52 and exactly 3 expected in /www/wwwroot/csapat.org/vendor/flarum/core/src/Notification/NotificationMailer.php:40

The comment succeeds on the second or third attempt.

clarkwinkelmann

jsystems73 thanks for the report.

It appears this extension is incompatible with Flarum 1.5.

An internal Flarum change in the NotificationMailer interface requires Pretty Mail code to be modified.

I have created an issue to track this FriendsOfFlarum/pretty-mail29

masihdindar

@luceos Hey man,
So after this plugin is Incompatible with 1.5, What should i use instead of this extension?
I was really happy because i could customize my forum's emails.
Do you have any extension or any hard code trick to do this?

masihdindar

How?

This extension is totally broken in Flarum 1.5!

clarkwinkelmann

Please be patient. An update will be provided in the near future.

Since Flarum 1.5 isn't a security update, you can hold on updating until a compatible version is released.

If you already updated to Flarum 1.5, you can either restore to a previous backup or disable this extension until it's made compatible.

Extiverse has it own logic to determinate compatible versions, and I don't think it can tell when an extension is broken by an internal Flarum code change. It can only tell when developers know in advance that an extension will be broken and specify it in their composer.json code. The particular change that broke this extension isn't even documented in the release notes so I doubt Extiverse could detect it.

masihdindar

clarkwinkelmann I just downgraded to 1.4.1 and waiting for this extension to upgrade.
Thanks.

masihdindar

Hi again.
I'm still waiting for this extension's update. Any progress?
@clarkwinkelmann

clarkwinkelmann

Version 1.1.1

Fix compatibility with Flarum 1.5+
Fix errors if extensions call the Pretty Mail extender on PHP versions below 8.0

masihdindar

clarkwinkelmann Finally! Thanks a lot mate. Now it's time to upgrade to Flatum 1.5 😃

« Previous Page Next Page »