FriendsOfFlarum Pretty Mail

hrvoje_hr

si_edgey I've found a similar issue as the user above

<p><a href="{{!! $url->to('forum')->route('user', ['username' => $blueprint->post->user->username]) !!}}">{!! $blueprint->post->user->username !!}</a> mentioned you in a post in <a href="{{!! $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]) !!}}">{!! $blueprint->post->discussion->title !!}</a>.</p>

This code does not generate any link.

<a href="{{!! $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]) !!}}">

EDIT: It worked on my previous version (0.1.13.)

hrvoje_hr

@si_edgey @FriendsOfFlarum found the issue. Bolded exclamation marks in the code are surplus.

<p><a href="{{!! $url->to('forum')->route('user', ['username' => $blueprint->post->user->username]) !!}}">{!! $blueprint->post->user->username !!}</a> mentioned you in a post in <a href="{{!! $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]) !!}}">{!! $blueprint->post->discussion->title !!}</a>.</p>

clarkwinkelmann

hrvoje_hr is that code inside of the extension? If so can you name the file so we can get it fixed?

Indeed, there are 2 different blade "echo" tags, {{ }} and {!! !!}. But {{!! !!}} is not a thing as far as I'm aware.

In this context either of the valid ones should work, but usually unless there's an explicit reason to use {!! !!} (raw echo) you should always use {{ }} (sanitized echo for HTML context)

hrvoje_hr

clarkwinkelmann yes, that's the default code for user mention notification (second field in the backend)

masihdindar

Hi,
There is one problem in this extension with Flarum 1.5:
https://discuss.flarum.org/d/31599-flarum-v150-released/22
I hope you fix it asap!
Thanks

jsystems73

Hello!
This error appears in some topics when posting a new comment:

[2022-09-15 05:44:02] flarum.ERROR: ArgumentCountError: Too few arguments to function Flarum\Notification\NotificationMailer::__construct(), 2 passed in /www/wwwroot/csapat.org/vendor/fof/pretty-mail/src/Overrides/NotificationMailer.php on line 52 and exactly 3 expected in /www/wwwroot/csapat.org/vendor/flarum/core/src/Notification/NotificationMailer.php:40

The comment succeeds on the second or third attempt.

clarkwinkelmann

jsystems73 thanks for the report.

It appears this extension is incompatible with Flarum 1.5.

An internal Flarum change in the NotificationMailer interface requires Pretty Mail code to be modified.

I have created an issue to track this FriendsOfFlarum/pretty-mail29

masihdindar

@luceos Hey man,
So after this plugin is Incompatible with 1.5, What should i use instead of this extension?
I was really happy because i could customize my forum's emails.
Do you have any extension or any hard code trick to do this?

masihdindar

How?

This extension is totally broken in Flarum 1.5!

clarkwinkelmann

Please be patient. An update will be provided in the near future.

Since Flarum 1.5 isn't a security update, you can hold on updating until a compatible version is released.

If you already updated to Flarum 1.5, you can either restore to a previous backup or disable this extension until it's made compatible.

Extiverse has it own logic to determinate compatible versions, and I don't think it can tell when an extension is broken by an internal Flarum code change. It can only tell when developers know in advance that an extension will be broken and specify it in their composer.json code. The particular change that broke this extension isn't even documented in the release notes so I doubt Extiverse could detect it.

masihdindar

clarkwinkelmann I just downgraded to 1.4.1 and waiting for this extension to upgrade.
Thanks.

masihdindar

Hi again.
I'm still waiting for this extension's update. Any progress?
@clarkwinkelmann

clarkwinkelmann

Version 1.1.1

Fix compatibility with Flarum 1.5+
Fix errors if extensions call the Pretty Mail extender on PHP versions below 8.0

masihdindar

clarkwinkelmann Finally! Thanks a lot mate. Now it's time to upgrade to Flatum 1.5 😃

si_edgey

Hi Clark, great extension! I'm having a problem sporadically when making a post, getting the 'Oops' message in Flarum. The post does still post correctly, but the reply window stays open as though it hasn't posted.

At the same time that this happens, I get an error in the log:

flarum.ERROR: Exception: Error: Call to undefined method Illuminate\Container\Container::url() in /home/sites/4b/9/9d43d8391c/public_html/forum/public/vendor/fof/pretty-mail/src/BladeCompiler.php(28) : eval()'d code:50

Any suggestions would be very helpful - this has been happening since at least v1.3 for me.]

Thanks

n-peugnet

Can this extension be used to customize the email templates while keeping them as plain text messages? I hate HTML in emails with a passion so I would really like to avoid it at all cost.

This extension seems to be dedicated to HTML but as @clarkwinkelmann said in this thread that:

even if you are not using the Pretty Mail extension, you will probably have to re-use/re-implement most of the exact same code that can be found in that extension.

it would be really cool if it allowed plain text templates too 😃

blueCamel

n-peugnet

If plain text is what you need, I believe you could use FOF-linguist to edit the translation strings.

blueCamel

I'm curious: if a user gives me an @mention in a discussion thread I'm already following, I get the email notification tied to Flarum/subscriptions New Post Email, and not the one for Flarum/mentions User Mentioned Email.

I would think that getting a direct mention trumps the general "there's yet another message in a discussion you follow", in favor of the more targeted "Someone messaged you directly, you should check it out..."

Is this expected behavior? Is there some config I can tune to define what event "wins" over another?

« Previous Page