FoF Terms, ask your users to accept TOS and Privacy Policy

clarkwinkelmann

html5syt remove the update date on the terms, or downgrade the extension.

html5syt

clarkwinkelmann ok, I'll tell the manager of freeflarum to let them downgrade it.

IanM

I've reverted that change in the repository, and asked the author to look at those changes again. No new release just yet, as this is the same as using 1.3.0 for the time being.

mikhamatta

Hi, i have a problem in my website with this extension for EXISTING USERS. they cant click on "CLICK HERE TO REVIEW AND ACCEPT THE NEW TERMS". it is not clickable..any help?

luceos

mikhamatta downgrade,

composer require fof/terms:"1.3.0 || ^1.3.2"

~~@IanM can you please delete 1.3.1 as a tag, that would probably help prevent questions like these from new users of the extension.~~
Update: just deleted 1.3.1 from packagist.

baicai

FriendsOfFlarum
There may be a bug.
After the user “clicks here to view and agree to the new Terms of Service”, no pop-up window will appear, and the web page will be stuck, resulting in the mouse not being able to click on any content, and in the case of mobile, the top navigation bar will become blank.
Below is the error message from the console:

mount-redraw.js:15 TypeError: Cannot read properties of undefined (reading '1') at AcceptPoliciesModal.js:28:40 at Array.filter (<anonymous>) at e.body (AcceptPoliciesModal.js:27:43) at e.content (AcceptPoliciesModal.js:22:34) at n.view (Modal.tsx:164:19) at Function.a (render.js:30:16) at render.js:155:45 at render.js:160:3 at c (render.js:66:8) at l (render.js:50:5) a @ mount-redraw.js:15 (匿名) @ mount-redraw.js:25 requestAnimationFrame u @ mount-redraw.js:23 t.4615.t.exports.O.handleEvent @ render.js:890 显示简略信息

sdgsdgsd

baicai I have this same problem. How can i just hide it?

ange1k

baicai I just downgraded it and it works fine:

composer require fof/terms:"1.3.0 || ^1.3.2"

Dret42

baicai

Same problem for me! 🙁

Capybara

Thanks for the extension. Please add the option to disable notification of the requirement to accept new terms for users. Accept the terms need only at the registration stage

clarkwinkelmann

Capybara if you have existing users for which you don't want to show terms, you could manually insert acceptation dates in your database using an SQL query. Make sure the users have already agreed through another means to not have any legal issue, ideally using the correct date(s) so they make sense if you produce an export at a later point

davetodave178

Dret42 Which version are you using? It seems like the downgrading from 1.3.1 to 1.3.0 did resolve the issues for the other users. But 1.3.1 has now been deleted for quite some time, so I would be surprised if you were still using that.

rapty88

On the settings page, I can see the "policies" text, like in the image below.
terms.png

davetodave178

1.4.1

What's Changed

fix(optional-policies): hide Policies section in user profile when no optional policies exist by @rafaucau in FriendsOfFlarum/terms60

Full Changelog: FriendsOfFlarum/terms1.4.0 → 1.4.1

wolfman

I have a weird behavior which seems to track back to FoF Terms. This already happened before Version 1.4.1 but i didn't look into it in more detail until today.

I can reproduce this with my two Administrator accounts, but Moderators and Users are not affected by this.

I have a lot of errors in my NGINX error log of the following kind. The Flarum Logs (storage/logs) themselves don't show any error.

2024/11/30 18:02:32 [error] 1466#1466: *851 FastCGI sent in stderr: "PHP message: PHP Warning: Attempt to read property "pivot" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "is_accepted" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "pivot" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "is_accepted" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "pivot" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "is_accepted" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "pivot" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "is_accepted" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "pivot" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "is_accepted" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "pivot" on null in /var/www/example.com/forum/vendor/fof/terms/src/Repositories/PolicyRepository.php on line 98; PHP message: PHP Warning: Attempt to read property "is_accepted" on null in /var/www/example.com/forum/vendor/fof/terms/src/Reposito

While the error above happens more often, it is sometimes - always on the same (secondary) Tags or Discussions - followed by the next error.

2024/11/30 18:02:32 [error] 1466#1466: *851 upstream sent too big header while reading response header from upstream, client: 2003:ea:cccc:bbbb:aaaa:zzzz:yyyy:xxxx, server: forum.example.com, request: "GET /api/discussions?include=user%2ClastPostedUser%2Ctags%2Ctags.parent%2CrecipientUsers%2CrecipientGroups%2CfirstPost&filter%5Btag%5D=marktplatz&sort&page%5Boffset%5D=0 HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php8.3-fpm.sock:", host: "forum.example.com", referrer: "https://forum.example.com/t/marktplatz"

While the first error seemingly has no visible issues while browsing the forum, the second error leads to a 502 error and subsequently not loading the requested page. Affected (secondary) Tags won't even load with Ctrl+R, while affected Discussions can be reloaded with Ctrl+R without a 502 error.

As mentioned this only affects my Administrator accounts and is a nuissance to me, while other users are not affected by this. Does anybody have a clue, what is causing this problem?

Edit: Deactivating FoF Terms and the problem is gone.

Edit: Flarum info

Flarum core: 1.8.9
PHP version: 8.3.6
MySQL version: 8.0.40-0ubuntu0.24.04.1
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, bz2, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, iconv, imagick, intl, exif, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+--------------------------------------+------------+--------+
| Flarum Extensions                    |            |        |
+--------------------------------------+------------+--------+
| ID                                   | Version    | Commit |
+--------------------------------------+------------+--------+
| flarum-flags                         | v1.8.2     |        |
| flarum-bbcode                        | v1.8.0     |        |
| flarum-suspend                       | v1.8.4     |        |
| flarum-approval                      | v1.8.2     |        |
| flarum-tags                          | v1.8.3     |        |
| fof-formatting                       | 1.0.3      |        |
| wolfgang-demeter-bbcode-5star-rating | v0.1.8     |        |
| wolfgang-demeter-amazon-product-api  | v0.1.7     |        |
| fof-user-bio                         | 1.4.2      |        |
| fof-upload                           | 1.6.1      |        |
| fof-terms                            | 1.4.1      |        |
| fof-split                            | 1.1.1      |        |
| fof-socialprofile                    | 1.1.6      |        |
| fof-recaptcha                        | 1.3.4      |        |
| fof-polls                            | 2.2.9      |        |
| fof-pages                            | 1.0.8      |        |
| fof-merge-discussions                | 1.4.1      |        |
| fof-links                            | 1.3.0      |        |
| fof-byobu                            | 1.3.8      |        |
| fof-amazon-affiliation               | 1.1.0      |        |
| flarum-subscriptions                 | v1.8.1     |        |
| flarum-sticky                        | v1.8.2     |        |
| flarum-statistics                    | v1.8.1     |        |
| flarum-nicknames                     | v1.8.2     |        |
| flarum-mentions                      | v1.8.5     |        |
| flarum-markdown                      | v1.8.1     |        |
| flarum-lock                          | v1.8.2     |        |
| flarum-likes                         | v1.8.1     |        |
| flarum-lang-german                   | dev-master |        |
| flarum-lang-english                  | v1.8.0     |        |
| datlechin-birthdays                  | v2.1.2     |        |
| askvortsov-auto-moderator            | v0.1.3     |        |
| antoinefr-bbcode-fa                  | v1.0.0     |        |
+--------------------------------------+------------+--------+
Base URL: https://forum.example.com
Installation path: /var/www/example.com/forum
Queue driver: sync
Session driver: file
Mail driver: mail
Debug mode: off

wolfman

@AngryDragonite @rafaucau @IanM Sorry to bother you, but the above error seems to coincide with the addition of optional policies to FoF Terms via FriendsOfFlarum/terms51 in Version 1.4.0.

rafaucau

wolfman These are warnings, not errors. You should disable error display in php.ini on your production site.

display_errors = Off

php/php-srcblob/b01f5e367f11a68b3d68ea2d63087bc1bf5550d1/php.ini-production#L509

Of course, this should be fixed, but in my opinion it's not urgent since these warnings don't affect the extension functionality and should be hidden in production anyway. I'll try to submit a PR when I find some time, unless someone else does it first.

wolfman

rafaucau Thanks for looking into it.

rafaucau You should disable error display in php.ini on your production site.

display_errors is already off. But i added & ~E_WARNING to error_reporting to silence those warnings for the moment (not the PHP recommended production value). That prevents the 502 Bad Gateway error from NGINX and the affected sites are loaded again.

rafaucau

rafaucau I'll try to submit a PR when I find some time, unless someone else does it first.

I have submitted a PR: FriendsOfFlarum/terms61

davetodave178

1.4.2

What's Changed

fix(optional-policies): resolve null property warnings and improve UX by @rafaucau in FriendsOfFlarum/terms61

Full Changelog: FriendsOfFlarum/terms1.4.1 → 1.4.2

« Previous Page