Custom CSS/LESS limit

arda

I'm testing my custom theme on a local installation and wrote 2775 lines of code.

Flarum doesn't accept all of this, cuts the code from the bottom, is this a known feature or am I the only one experiencing this?

arda

arda is this a known feature or am I the only one experiencing this?

I asked that is this an intentional limit or if not, what can we do it to remove it from Flarum?

I may be the first one to experience this (or not doesn't matter) but in the future, more users can be affected as the users of Flarum is increasing every day.

Ralkage

If you feel as if it's a bug, you know where to bring it up at officially ?

arda

Ralkage Before submitting to the issue tracker, I want to make sure this is not made intentionally.

I reported so many issues and some of them were made intentionally.

clarkwinkelmann

Flarum settings are saved in the database as TEXT, so it has a maximum storage of 65,535 bytes for a setting.

Most likely you exceeded that limit (the number of lines in itself doesn't matter, only the total size), so MySQL truncated the input. In a way that's expected.

Might be wise to have a validation rule that prevents you from saving the custom Less if it exceeds that limit though ?

Ralkage

clarkwinkelmann I remember running into this issue before and just shrugged it off for some reason ?

arda

clarkwinkelmann Any solutions though?

Frink

Ralkage I remember running into this issue before and just shrugged it off for some reason ?

Did you apologize for running into it?

jordanjay29

arda Sure, there are bigger field types than TEXT. MEDIUMTEXT can store 16,777,215 bytes. LONGTEXT can store 4,294,967,295 bytes. An extension could easily solve this by writing a migration to update the field type.

Pollux

arda Any solutions though?

Reduce the amount of CSS. Example: Instead of

.c1 { font-weight: bold }
.c2 { font-weight: bold, color: blue }
.c3 { color: blue }

you could write:

.c1, .c2 { font-weight: bold }
.c2, .c3 { color: blue }

Or you could make your classes more meaningful:

.bold { font-weight: bold }
.blue { color: blue }

... and instead of applying .c2 you apply .bold.blue.

2775 lines of CSS looks like a lot of rules, I guess there should be some room for improvement.

arda

People, I didn’t want support here. I created this topic to ask if we have something like this on Flarum. I already fixed my issue by declaring variables.

And as my theme is an extension, there is no limit on the extension side.

Pollux I said solutions for Flarum to remove this limit, not my style ?

Please everyone notice that I used the features tag, not the support tag.

jordanjay29

Also, you could add the LESS to an extension rather than using the Custom CSS box via the admin panel.

luceos

You all assume his theme is adding data to a column. I'm not sure this makes any sense for an extension. Extensions can easily write temporary css or less to disk, which is possibly even more performant..

If this is not about code written to the database I'm not sure what truncated the code.

lorem

Uglify your css

luceos

You created a feature request for what, exactly? Upon reading the original post, I don't see a request for features. I see a question that could either be valid in Support or Dev.

If you'd like to make a feature request, please be clear about what the feature should do. Remove limits to the Custom CSS box? Allow importing of CSS/LESS files? What?

Also know that people are likely to suggest alternative solutions, it's happened in other feature request discussions, and sometimes provides viable workarounds that don't require the feature to be implemented. That's just part of having multiple opinions here. As far as I can see, nothing has strayed off topic.

arda

arda I may be the first one to experience this (or not doesn't matter) but in the future, more users can be affected as the users of Flarum is increasing every day.

Razor We don't know that, and we won't ever. Everything is possible my friend ?

luceos So this is related to the Custom Style textarea..

Yes, extension styles don't have this limit, I used the same style I pasted to the custom CSS area and get the limit thing to the extension and it worked perfectly.

luceos

Can you please explain where you wrote your code? Can you give us an example where you hit "a limit"?

arda

luceos Let me tell you.

I wrote 2775 lines of code and applied to my custom CSS area.

After submitting, it trimmed my style from the bottom, resulting in my forum to not load the CSS because the brackets stayed open.

Razor

With less than 100 lines u can make a flarum to look completely different so if there is that limit i do not think someone will hit it.

luceos

So this is related to the Custom Style textarea..

Thanks for the clarification.

Toby

Make an issue please.

arda

Toby flarum/core1523