FoF Sitemap

eddiewebb

Thanks clarkwinkelmann , if I remove print line it runs without error (but also without including the objects)

If I change to an exception it is never thrown. (where as constructor exception halts it)

class SitemapsResource extends Resource
{

    public function __construct()
    {
        // exception or print will show if added here
    }

    public function query(): Builder
    {
        // print, throw do nothing here.
        throw new \Exception("Query was called");
        return Model::query();
    }

SitemapGenerator is not resolving it after Register

I added a var_dump to your SitemapGenerator and only the 3 default resources are listed.

array(3) {
  [0]=>
  object(FoF\Sitemap\Resources\User)#748 (0) {
  }
  [1]=>
  object(FoF\Sitemap\Resources\Discussion)#747 (0) {
  }
  [2]=>
  object(FoF\Sitemap\Resources\Tag)#746 (0) {
  }
}

HOWEVER - adding a var_dump to RegisterResource (line ₄₄) correctly includes the core 3 + my extensions.

The list is not being correctly passed /persisted some reason. I even tried adding RequireResource directly to my site's extend.php, no change.


array(4) {
  [0]=>
  object(FoF\Sitemap\Resources\User)#746 (0) {
  }
  [1]=>
  object(FoF\Sitemap\Resources\Discussion)#745 (0) {
  }
  [2]=>
  object(FoF\Sitemap\Resources\Tag)#744 (0) {
  }
  [3]=>
  object(Webbinaro\AdvCalendar\Integrations\SitemapsResource)#736 (0) {
  }
}

datitisev

eddiewebb Instead of print for debugging, use dd() with composer require --dev symfony/var-dumper or app('log')->debug(...).

eddiewebb

datitisev taht's good general debug advice.

In this case though, I don't for what additional info I could grab. the instances of resource aren't being resolved by the container after I register them.

eddiewebb

Woot! Fixed it, and PR submitted - FriendsOfFlarum/sitemap15 to change the register function's interaction with container.

[2020-07-22 00:00:55] production.DEBUG: [Webbinaro\AdvCalendar] Resource Initialized  
[2020-07-22 00:00:55] production.DEBUG: [RegisterResource::extend] added Webbinaro\AdvCalendar\Integrations\EventResource  
[2020-07-22 00:00:55] production.DEBUG: [RegisterResource::extend] resolved 4 resources.  
[2020-07-22 00:00:55] production.DEBUG: [RegisterResource::extend] afterResolving still has 4 resources.  
[2020-07-22 00:00:55] production.DEBUG: [SitemapGenerator::getUrlSet] will be processing 4 resources.  
[2020-07-22 00:00:55] production.DEBUG: [Webbinaro\AdvCalendar] Resource Queried

2006bt

FriendsOfFlarum
Hi,

It returned 500 when I was accessing /sitemap.xml.I set it as disk mode.This is the log:

[2020-07-24 12:28:36] production.ERROR: TypeError: Return value of FoF\Sitemap\Resources\Discussion::lastModifiedAt() must be an instance of Carbon\Carbon, null returned in /data/wwwroot/community.wvbtech.com/vendor/fof/sitemap/src/Resources/Discussion.php:47
Stack trace:
#0 /data/wwwroot/community.wvbtech.com/vendor/fof/sitemap/src/SitemapGenerator.php(57): FoF\Sitemap\Resources\Discussion->lastModifiedAt()
#1 /data/wwwroot/community.wvbtech.com/vendor/illuminate/database/Concerns/BuildsQueries.php(62): FoF\Sitemap\SitemapGenerator->FoF\Sitemap\{closure}()
#2 /data/wwwroot/community.wvbtech.com/vendor/illuminate/database/Concerns/BuildsQueries.php(39): Illuminate\Database\Eloquent\Builder->Illuminate\Database\Concerns\{closure}()
#3 /data/wwwroot/community.wvbtech.com/vendor/illuminate/database/Concerns/BuildsQueries.php(66): Illuminate\Database\Eloquent\Builder->chunk()
#4 /data/wwwroot/community.wvbtech.com/vendor/fof/sitemap/src/SitemapGenerator.php(61): Illuminate\Database\Eloquent\Builder->each()
#5 /data/wwwroot/community.wvbtech.com/vendor/fof/sitemap/src/Commands/CacheSitemapCommand.php(27): FoF\Sitemap\SitemapGenerator->getUrlSet()
#6 [internal function]: FoF\Sitemap\Commands\CacheSitemapCommand->handle()
#7 /data/wwwroot/community.wvbtech.com/vendor/illuminate/container/BoundMethod.php(29): call_user_func_array()
#8 /data/wwwroot/community.wvbtech.com/vendor/illuminate/container/BoundMethod.php(87): Illuminate\Container\BoundMethod::Illuminate\Container\{closure}()
#9 /data/wwwroot/community.wvbtech.com/vendor/illuminate/container/BoundMethod.php(31): Illuminate\Container\BoundMethod::callBoundMethod()
#10 /data/wwwroot/community.wvbtech.com/vendor/illuminate/container/Container.php(572): Illuminate\Container\BoundMethod::call()
#11 /data/wwwroot/community.wvbtech.com/vendor/illuminate/console/Command.php(183): Illuminate\Container\Container->call()
#12 /data/wwwroot/community.wvbtech.com/vendor/symfony/console/Command/Command.php(255): Illuminate\Console\Command->execute()
#13 /data/wwwroot/community.wvbtech.com/vendor/illuminate/console/Command.php(170): Symfony\Component\Console\Command\Command->run()
#14 /data/wwwroot/community.wvbtech.com/vendor/symfony/console/Application.php(1018): Illuminate\Console\Command->run()
#15 /data/wwwroot/community.wvbtech.com/vendor/symfony/console/Application.php(271): Symfony\Component\Console\Application->doRunCommand()
#16 /data/wwwroot/community.wvbtech.com/vendor/symfony/console/Application.php(147): Symfony\Component\Console\Application->doRun()
#17 /data/wwwroot/community.wvbtech.com/vendor/flarum/core/src/Console/Server.php(44): Symfony\Component\Console\Application->run()
#18 /data/wwwroot/community.wvbtech.com/flarum(24): Flarum\Console\Server->listen()
#19 {main}

And this is my flarum info:

[root@main community.wvbtech.com]# php flarum info
Flarum core 0.1.0-beta.13
PHP version: 7.4.8
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, ctype, curl, dom, hash, filter, ftp, gd, gettext, SPL, iconv, intl, json, mbstring, session, standard, pcntl, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, Reflection, mysqli, shmop, SimpleXML, soap, sockets, sodium, exif, sysvsem, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, gmp, imagick, fileinfo, imap, memcached, redis, Zend OPcache
+--------------------------------------+-------------------+--------+
| Flarum Extensions                    |                   |        |
+--------------------------------------+-------------------+--------+
| ID                                   | Version           | Commit |
+--------------------------------------+-------------------+--------+
| flarum-approval                      | v0.1.0-beta.13    |        |
| flarum-emoji                         | v0.1.0-beta.13    |        |
| flarum-lang-english                  | v0.1.0-beta.13    |        |
| flarum-flags                         | v0.1.0-beta.13    |        |
| flarum-lock                          | v0.1.0-beta.13    |        |
| flarum-markdown                      | v0.1.0-beta.13    |        |
| flarum-statistics                    | v0.1.0-beta.13    |        |
| flarum-sticky                        | v0.1.0-beta.13    |        |
| flarum-subscriptions                 | v0.1.0-beta.13    |        |
| flarum-suspend                       | v0.1.0-beta.13    |        |
| flarum-tags                          | v0.1.0-beta.13    |        |
| oe800-bbcode-alerts                  | 0.2.0             |        |
| lcinhk-acgembed                      | v0.5.2            |        |
| flarum-akismet                       | v0.1.0-beta.13    |        |
| flarum-bbcode                        | v0.1.0-beta.12    |        |
| michaelbelgium-discussion-views      | v4.0.1            |        |
| flarum-embed                         | v0.1.0-beta.13    |        |
| flagrow-ads                          | 0.2.4             |        |
| flagrow-direct-links                 | 0.2.0             |        |
| askvortsov-categories                | v1.0.4            |        |
| littlegolden-lang-simplified-chinese | v0.1.67           |        |
| csineneo-lang-traditional-chinese    | 1.13.1            |        |
| askvortsov-moderator-warnings        | v0.2.4            |        |
| fof-ban-ips                          | 0.2.0             |        |
| fof-best-answer                      | 0.1.11            |        |
| fof-byobu                            | 0.5.6             |        |
| fof-disposable-emails                | 0.1.0             |        |
| saleksin-auth-google                 | v0.1.0-beta.8.0.3 |        |
| flarum-auth-github                   | v0.1.0-beta.13    |        |
| fof-follow-tags                      | 0.3.6             |        |
| fof-formatting                       | 0.1.5             |        |
| fof-geoip                            | 0.1.7             |        |
| fof-html-errors                      | 0.4.0             |        |
| fof-ignore-users                     | 0.1.6             |        |
| fof-linguist                         | 0.4.2             |        |
| fof-links                            | 0.3.0             |        |
| fof-merge-discussions                | 0.3.3             |        |
| fof-nightmode                        | 0.4.0             |        |
| fof-pages                            | 0.4.0             |        |
| fof-polls                            | 0.1.2             |        |
| fof-pretty-mail                      | 0.1.6             |        |
| fof-prevent-necrobumping             | 0.2.1             |        |
| fof-profile-image-crop               | 0.1.2             |        |
| fof-reactions                        | 0.3.4             |        |
| fof-secure-https                     | v0.1.0            |        |
| fof-sitemap                          | 0.5.1             |        |
| fof-socialprofile                    | 0.1.2             |        |
| fof-spamblock                        | 0.2.2             |        |
| fof-split                            | 0.4.4             |        |
| fof-stopforumspam                    | 0.2.2             |        |
| fof-upload                           | 0.9.2             |        |
| fof-user-bio                         | 0.1.3             |        |
| fof-user-directory                   | 0.3.4             |        |
| fof-username-request                 | 0.2.0             |        |
| fof-recaptcha                        | 0.1.2             |        |
| kilowhat-mailing                     | 0.2.3             |        |
| kvothe-pipetables                    | 1.0.9             |        |
| flarum-mentions                      | v0.1.0-beta.13    |        |
| antoinefr-online                     | 0.4.0             |        |
| michaelbelgium-profile-views         | v3.1.0            |        |
| kvothe-reply-to-see                  | v0.1.2            |        |
| v17development-seo                   | 1.2.1             |        |
| kvothe-signup-button                 | v0.1.4            |        |
| amaurycarrade-syndication            | v0.3.1            |        |
| wvbforum-tieba-stickers              | 0.2.1             |        |
| extiverse-bazaar                     | 0.4.1             |        |
| zeokat-seoslugs                      | v0.1.6            |        |
| the-turk-extended-appearance         | 0.1.1             |        |
| the-turk-edit-notifications          | 0.1.5             |        |
| the-turk-diff                        | 1.0.8             |        |
| fof-impersonate                      | 0.5.0             |        |
| flarum-pusher                        | v0.1.0-beta.13    |        |
| fof-drafts                           | 0.1.12            |        |
| reflar-doorman                       | 0.1.6             |        |
| tank-polyfills                       | v0.1.1            |        |
| askvortsov-pwa                       | v1.0.1            |        |
| clarkwinkelmann-author-change        | 0.1.5             |        |
| fof-terms                            | 0.4.3             |        |
| fof-pwned-passwords                  | 0.4.0             |        |
| jjandxa-chinese-search               | 0.0.9             |        |
| fof-gamification                     | 0.2.1             |        |
| the-turk-welcome-widgets             | 0.1.2             |        |
| squeevee-fancybox                    | 0.2-beta          |        |
+--------------------------------------+-------------------+--------+
Base URL: https://community.wvbtech.com
Installation path: /data/wwwroot/community.wvbtech.com
Debug mode: off
[root@main community.wvbtech.com]#

clarkwinkelmann

2006bt this could happen if you manually inserted discussions in the database without a last_posted_at value.

We might want to add an extra check against that.

jmelich

2006bt Same error here, any news about that?

Database is not manipulated as clarkwinkelmann says

2006bt

clarkwinkelmann
Hi,
It returned nothing

rob006

Why 0.5.2 release is older than 0.5.1?

https://github.com/FriendsOfFlarum/sitemap/tags

clarkwinkelmann

rob006 oops, my bad. I messed up the tagging.

I have now tagged version 0.5.3 and delete the 0.5.2 tag completely. 0.5.3 is now the one with the fix to the extender.

I tagged locally thinking I was on master but was in fact on an older PR branch 😬

ART994

appears at the very bottom of the sitemap.xml file browser Opera

(function () { if (typeof navigator.getUserMedia !== "undefined") navigator.getUserMedia = undefined; if (typeof window.MediaStreamTrack !== "undefined") window.MediaStreamTrack = undefined; if (typeof window.RTCPeerConnection !== "undefined") window.RTCPeerConnection = undefined; if (typeof window.RTCSessionDescription !== "undefined") window.RTCSessionDescription = undefined; if (typeof navigator.mozGetUserMedia !== "undefined") navigator.mozGetUserMedia = undefined; if (typeof window.mozMediaStreamTrack !== "undefined") window.mozMediaStreamTrack = undefined; if (typeof window.mozRTCPeerConnection !== "undefined") window.mozRTCPeerConnection = undefined; if (typeof window.mozRTCSessionDescription !== "undefined") window.mozRTCSessionDescription = undefined; if (typeof navigator.webkitGetUserMedia !== "undefined") navigator.webkitGetUserMedia = undefined; if (typeof window.webkitMediaStreamTrack !== "undefined") window.webkitMediaStreamTrack = undefined; if (typeof window.webkitRTCPeerConnection !== "undefined") window.webkitRTCPeerConnection = undefined; if (typeof window.webkitRTCSessionDescription !== "undefined") window.webkitRTCSessionDescription = undefined; })();

clarkwinkelmann

ART994 does that same content appear at the bottom of other pages?

Which mode of operation are you using in Sitemap?

That looks like something a proxy might add to the requests, though it makes no sense to insert raw javascript in an xml file.

ART994

clarkwinkelmann Runtime mode, I enter the link site.com/sitemap.xml and at the very bottom I see this message. but this only appears in the opera browser

clarkwinkelmann

ART994 unfortunately I have no idea where this can come from. That code is definitely not in the source code of Sitemap, nor does Flarum offer a way to inject content at the end of other blade templates so this likely isn't coming from another Flarum extension either.

It must be related to your host or a proxy.

Or possibly it's client-side and is related to a browser add-on or something like that.

ART994

clarkwinkelmann
what the site uses cloudflare can on this?

ChadJessen

ChadJessen I was wondering if there was any update on this issue? I didn't see any response. I did create an issue on github for this too if that is easier to use and keep track of.

clarkwinkelmann

ChadJessen installation errors are usually unique to each setup. It's best for each person to report separately so we can best assist.

I have made some suggestions for your issue on GitHub.

rob006

IanM Wouldn't be better to remove these settings and introduce only one universal mode - paginated runtime mode? As multiple sitemaps like sitemap-page_1.xml (which contains discussions with ID between 1-1000) and sitemap.xml containing links to all these sitemap-pages (all generated on fly). This should work for forum with any size (up to 50kk discussions), does not need cron, it is always up-to-date and does not require any configuration. It will also allow to ping Google after new discussion is added using https://developers.google.com/search/docs/guides/submit-URLs with URL to correct siemap-page (based on discussion ID).

clarkwinkelmann

rob006 now that the choices are built-in, it probably doesn't make sense to remove any, no?

This mode could be offered as an additional mode if someone implements it.

rob006

clarkwinkelmann now that the choices are built-in, it probably doesn't make sense to remove any, no?

Less options means less code to maintain and simpler configuration for users (these options may look cool, but for non-technical users it may be really confusing). If these additional options does not bring any significant advantage over "paginated runtime mode", I don't see the point in keeping them.

cmwetherell

After installing, I got this. Any advice? My forum is small now, so maybe its fine without it being bigger - but I like to future proof where possible!

bitnami@ip:/opt/bitnami/apache/htdocs$ php flarum fof:sitemap:cache

In StreamHandler.php line 110:

The stream or file "/opt/bitnami/apache/htdocs/storage/logs/flarum-2020-09-21.log" co
uld not be opened in append mode: failed to open stream: Permission denied

bitnami@ip:/opt/bitnami/apache/htdocs$ sudo php flarum fof:sitemap:cache

There are no commands defined in the "fof:sitemap" namespace.

luceos

cmwetherell bitnami is quite confusing with their file permissions, you should allow the right user access to the directories needed by flarum or run commands as the web user (www-data usually).

« Previous Page Next Page »