FoF Sitemap

blueCamel

Thank you, with your guidance, I was able to get on the php 8.1 bandwagon.

The composer why-not fof/sitemap 2.0 now gives me:

Deprecated: Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/cpanel/composer/bin/composer/vendor/symfony/console/Helper/HelperSet.php on line 112
Deprecation Notice: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///opt/cpanel/composer/bin/composer/vendor/justinrainbow/json-schema/src/JsonSchema/Constraints/Constraint.php:48
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/cpanel/composer/bin/composer/src/Composer/Repository/ArrayRepository.php:286
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/cpanel/composer/bin/composer/src/Composer/Repository/ArrayRepository.php:286
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/cpanel/composer/bin/composer/src/Composer/Repository/ArrayRepository.php:286
Deprecation Notice: Return type of Composer\Repository\CompositeRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be usedto temporarily suppress the notice in phar:///opt/cpanel/composer/bin/composer/src/Composer/Repository/CompositeRepository.php:180
Info from https://repo.packagist.org: #StandWithUkraine
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/cpanel/composer/bin/composer/src/Composer/Repository/ArrayRepository.php:286
flarum/flarum  -  requires  fof/sitemap (^1.0)

clarkwinkelmann

blueCamel ~~it looks like your Composer version is too recent for the PHP version it runs as~~ EDIT: I think it's more likely the opposite. You probably updated PHP but are still running an older Composer version. You can check version with composer --version

If everything is up to date, you could just hide those deprecation notices in your php.ini config. But I think if you have the right PHP version for your Composer version it shouldn't output any notice/warning.

In any case, if the Composer command reached the end, you can ignore those deprecation notices, they shouldn't prevent Composer from finishing its job.

blueCamel

clarkwinkelmann
I'm on 2.1.3 as far as composer is concerned. I guess I should aim for 2.5.4?

blueCamel

After updating composer, I was able to get fof-sitemap to the latest version by running the require command.

Thanks everyone.

Lumeinshin

I hope I havent missed someone already addressing this
I am adding sitemap to my site to help with SEO and all that
/sitemap.xml has been added as a location as mentioned in the OP nginx troubleshooting. However I have it set to the multi map mode and it seems to put them in /public/sitemaps/sitemap/sitemap(number).xml, would I need to change the nginx.conf to reflect each one?

and so i'm not just being completely useless and not providing anything, if you're using nginx via docker and pushing the forum out that way, change both the in-docker nginx conf and the host one. That will at least get you somewhere, and make sure the location{ is separate from the other.

clarkwinkelmann

Lumeinshin the sitemap at the well-known path /sitemap.xml contains instructions to tell search engines where the individual map files are. It's expected for the auto-generated files to be found at a different path. All you need is to give the original /sitemap.yml URL to search engines and they'll automatically figure it out.

EDIT: as to the nginx configuration, you probably don't need to change it further. The instructions in the README are because of an issue that only happens with that exact file path. If you get any error from the Google search console, please report back with the message!

Lumeinshin

clarkwinkelmann
thanks for the quick reply, 😃
For both google and bing, both give a HTTP Error: 404. i'll give it a bit longer before I try changing more settings just to make sure the forum has had a chance to make its sitemap, although I doubt that'll do it

h4ck3r0

clarkwinkelmann i don't understand nginx step , where i have to put that code , in which file , sitemap not working

clarkwinkelmann

Lumeinshin as soon as the extension is enabled, trying to access <forum url>/sitemap.xml should return an XML file with HTTP code 200. You can test it yourself in the browser. There is no file on disk with that name, that's normal. Flarum will automatically answer the URL with an auto-generated response. The change to nginx configuration is because sometimes nginx refuses to let Flarum generate an answer for that URL.

poVoq

hmm, for me it says Flarum itself depends on 1.0, but uninstalling 1.0 and then installing 2.x again seems to have worked.

IanM

2.1.0

feat: Adds a new default Resource added to the Provider: StaticUrls by @iPurpl3x in FriendsOfFlarum/sitemap47

This is a pseudo-resource, as it isn't related to any model. It contains a list of route names that can be iterated to generate URLs to static pages of the app. By default there are 2 static pages: index and tags. Tags are only present in the list if the tags extension is activated.

A new Extender (FoF\Sitemap\Extend\RegisterStaticUrl) has been added, so that other extensions can add thier own static URLs to the list. Example:

new RegisterStaticUrl('reviews')

Darkle

IanM Could I use this to register multiple URLs from extend.php?

IanM

Darkle Yep! Simply enter multiple RegistrStaticUrl's

new \FoF\Sitemap\Extend\RegisterStaticUrl('my.route'),
new \FoF\Sitemap\Extend\RegisterStaticUrl('my.other.route'),
....

Darkle

IanM Thanks, I've tried it, I remember Clark telling me a very similar idea some time ago to register the static pages of flarum-pages-generator, this will probably make things a lot easier.

It's strange that it works with some extensions and not with others, it throws an error when building the sitemap saying it can't find them, it's probably a matter of the extensions itself, for example with fof/gamification it works great to register /rankings

poVoq

Hmm again it did not update by itself and I have to remove the old version and reinstall.

I also noticed that I don't actually get a /sitemap.xml but only the flarum internal 404 message (I have the nginx redirect working).

Any idea how to completely purge this extension and start new?

h4ck3r0

where to add that nginx error rule , i added to config.php but still not working

RelicSystem

You would want to put the location line inside of a server {} block below location / and above the PHP location (something along the lines of location ~ .php$ {) then issue a reload/restart to nginx.

Vertruc

In your plugin, readme file and/or plugin blurbs once activated, please explain what is a sitemap and what it is used for. As i was browsing plugins, i couldn'ttell if this was for the users to use or the search engine bots to crawl.

clarkwinkelmann

Vertruc this is a sitemap for search engines only.

We could probably fit the term "search engine" somewhere in the extension description. It's the first time I see a report about this about this, but I understand the possible confusion. I feel like the SEO XML sitemap is the most commonly used concept when referring to this name, hence why there hasn't been more confusion.

CyberGene

When in runtime mode, is the sitemap generated on each request reading the sitemap? Or on each new content, e.g. new discussion/post?

I'm asking because if it's the former, then how about keeping it in runtime mode but configuring CloudFlare with a cache rule for the sitemap which will be the equivalent of using Flarum scheduler?

GreXXL

CyberGene When in runtime mode, is the sitemap generated on each request reading the sitemap? Or on each new content, e.g. new discussion/post?

As far as I know on each new content created.

CyberGene I'm asking because if it's the former, then how about keeping it in runtime mode but configuring CloudFlare with a cache rule for the sitemap which will be the equivalent of using Flarum scheduler?

No it will not - the extension will still generate a new sitemap on your server each time new content is created.

clarkwinkelmann

CyberGene GreXXL I'm pretty sure it's the opposite. In runtime mode, nothing is stored. The XML sitemap is generated on the fly when queried by search engines.

Generating on each content change would be prone to breaking because if any issue happens (like for example the SMTP server being down and email failing to send, or any kind of bug in another extension) it could result in an outdated/broken sitemap. And if the full sitemap was generated every time a discussion is created or edited, it would cause even longer response times for users on a site that doesn't use a queue, so it would be really counter-productive to use this option for hostings that are already quite limited. Instead only the search engines have to wait for the sitemap to be generated, which should have no impact for regular users.

In any case if you can use the scheduler to generate the sitemap you'll have the best solution overall, with no load time impact for both customers and search engines.

« Previous Page Next Page »