In the beta 8 links in post will open differently?

peopleinside

Hi, i am using last Flarum beta: 0.1.0-beta.7.2
I am very happy to see links open in a new tab.

I see on the Flarum community where i suppose is running beta 8, links open in the same window so visitor left the forum, loose the discussion. Is this something will be also affect me when upgrading to beta 8 ? In affirmative case how can i have links as open now in my beta in a new tab?

Thanks

MikeJones

Great question!

jordanjay29

It's a bug. And I'm not seeing an issue for it yet on Github.

peopleinside

Found another bug? Wow, should I open ? Or you can open it.
😀

jordanjay29

peopleinside https://github.com/flarum/core/issues/1650

clarkwinkelmann

This might actually be a bug.

I also notice on my dev-master setup, links no longer open in a new tab. But the code hasn't changed https://github.com/flarum/core/blob/c34fcecf0380d130d1aeb0a5dc6155f07f885d87/src/Formatter/Formatter.php#L140

So my guess is that there is an issue applying the target attribute to links in dev-master. By the way, rel=nofollow also isn't applied anymore, which could be a bigger issue referral wise 😬

Anybody else's thoughts on this ? Should we open an issue on GitHub ?

jordanjay29

And it's fixed. Thanks for reporting it, guys.

MikeJones

jordanjay29 you guys are awesome!