FriendsOfFlarum Formatting

Developers each have different goals. Some try to achieve readable and beautiful code, others want code to be performant. The s9e lib is created with performance in mind and does so well.

luceos I understand but I continue thinking that adding ?rel=0parameter will not affect the performance at all, and will make our flarums-video-embeds more clean.

neogeo my comment was intended for tankerkiller125

tankerkiller125 I work for a software engineering company

Then you should see that this file is obviously generated

For reference : https://github.com/s9e/TextFormatter/blob/master/scripts/generateBundles.php

(I think we're off-topic)

matteocontrini Hm, yeah, but that probably generates it only for the dev before publishing.

But you are correct, I personally don't think this is in the scope of the extension. And if I ever do add the functionality, it will probably be limited, as allowing all options will most likely confuse regular Flarum users with no coding and/or RegExp knowledge.
Please continue the discussion on adding sites to MediaEmbed at https://discuss.flarum.org/d/18535-add-mannualy-website-for-s9e-mediaembed, thank you

rob006 I never said I was a software engineer, I do work in PHP in my spare time, however, I am no software engineer, I maintain all the servers and infrastructure for the company, not the code base.

New to flarum and installed the upload extension yesterday to allow images to be uploaded to imgur.
Today I realised youtube videos are not embedded so installed the formatting extension [https://github.com/FriendsOfFlarum/formatting] with
composer require fof/formatting
went into extensions and enabled it and went into admin to set Autovideo to on, however any youtuve url in a post still remains as just the url and not an embedded video.

Could there be an extension conflict or some other issue?

ecar Autovideo to on, however any youtuve url in a post still remains as just the url and not an embedded video.

Autovideo embeds any link with a video extension (.avi, .mp4, .webm) and MediaEmbed embeds video site links (YouTube, Vimeo, etc). Enable MediaEmbed in the Formatting options.

jordanjay29 Enable MediaEmbed in the Formatting options.

thanks!

YldrayBilgin That looks like a very invalid URL. While it may be valid, the TextFormatter parser probably is not recognizing it as a URL. Try using https://cdn.vox-cdn.com/uploads/chorus_image/image/60671473/firefox_logos.0.jpg, and clear your cache if it still doesn't work.

iosmall What do you mean? HTTP image links to not appear as the image itself, just the link?

There's not much we can do from the current purpose of the extension, which is simply to enable already-existing plugins, so that would be an issue with TextFormatter. However, try clearing your cache first & adding some more text to the post to update it, see if that fixes it.

datitisev The picture is HTTPS which can be formatted automatically. If the image address is HTTP, it cannot be formatted automatically.

I just installed this, but I can't see anywhere in Admin to change modify settings. Any tips?

troymccann Does it not appear in the extensions page ?

Thank you, it works great!

can it embed bilibili link with a video？ ：)