FriendsOfFlarum User Bio

zhanzhang

FriendsOfFlarum After upgrading my site to 1.7.1, installing this plugin reported an error, which caused a bit of headaches.

datitisev

1.2.0

Add TextFormatter support (FriendsOfFlarum/user-bio48)
- Only raise BioChanged event if bio did indeed change
- Add option to enable formatting
- Create separate TextFormatter instance than the regular Flarum formatter -- this means users won't be able to use Mediaembed in their bio even if it is enabled in fof/formatting.
  Only BBCode and Markdown are available by default, excluding images.
  Extensions may *explicitly* extend this formatter to add features.

datitisev

1.2.1

Fix users with permission to edit others' bios clearing their content instead

Derbosik

@datitisev Posted a pull request with a newline fix, can you approve it please?
Also, there is a need for limiting text per-line, because it is possible to move it out of the site.

datitisev

Derbosik What do you mean text per line? As in it the text doesn't wrap properly?

Also, your PR doesn't contain a setting item in admin for the max new lines. Not entirely sure what a "newline fix" is trying to accomplish either - is it bypassing max character count limit by just using new lines? If so, I don't think just checking for too many linebreaks is the best solution..

Derbosik

datitisev You are able to use infinite newlines almost, making it quite long, dragging out profiles.

IanM

1.2.3

fix: Unable to create a new user via the API with the bio field included FriendsOfFlarum/user-bio53
feat: basic backend testing (more still needed)

Updating

composer update fof/user-bio
php flarum cache:clear

datitisev

1.3.0

Add measures to prevent users from setting user bios with line breaks that cover entire page
Improve error handling when user bio fails to save

IanM

1.3.2

fix: displayname not used by @IanM in FriendsOfFlarum/user-bio57

treyb

How do you save the bio? I type it in, and hit enter, then it just puts in a line break.
My install does not have a save/submit button either.

datitisev

treyb If I remember correctly, clicking out of the input should save it.

EDIT: That indeed should do it. However, a regular "enter" should also submit it. Shift+enter puts in a line break, at least for me (and all cases that I've personally seen).

treyb

datitisev For me it isnt working even clicking out.

I also am not able to edit the bio when I hover over the username. The box in unclickable.

I am trying to disable all my extensions to see if I can get it working.

datitisev

treyb Does it work fine here on discuss for both of those cases? If so, are there any errors in the developer console when this occurs?

treyb

datitisev Yes, works fine here.

Just 2 errors:

Video: I promise I'm clicking, just no way to show that.

Flarum core: 1.8.5
PHP version: 8.3.6
MySQL version: 10.6.18-MariaDB-log
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, readline, Reflection, SPL, session, standard, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, ldap, exif, mysqlnd, odbc, PDO, pgsql, Phar, posix, pspell, shmop, SimpleXML, snmp, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, xmlreader, monarxprotect, imagick, sodium, Zend OPcache
+------------------------------------+---------+--------+
| Flarum Extensions                  |         |        |
+------------------------------------+---------+--------+
| ID                                 | Version | Commit |
+------------------------------------+---------+--------+
| flarum-flags                       | v1.8.0  |        |
| flarum-approval                    | v1.8.1  |        |
| flarum-tags                        | v1.8.0  |        |
| flarum-suspend                     | v1.8.1  |        |
| flarum-sticky                      | v1.8.0  |        |
| flarum-lock                        | v1.8.0  |        |
| afrux-forum-widgets-core           | v0.1.7  |        |
| flarum-nicknames                   | v1.8.0  |        |
| fof-pages                          | 1.0.8   |        |
| fof-ban-ips                        | 1.1.1   |        |
| flarum-mentions                    | v1.8.3  |        |
| flarum-subscriptions               | v1.8.0  |        |
| fof-byobu                          | 1.3.6   |        |
| flarum-likes                       | v1.8.0  |        |
| flarum-markdown                    | v1.8.0  |        |
| v17development-seo                 | v1.8.1  |        |
| the-turk-stickiest                 | 3.0.1   |        |
| migratetoflarum-canonical          | 1.0.0   |        |
| mickmelon-coloured-usernames       | 0.1.1   |        |
| kilowhat-formulaire                | 1.9.0   |        |
| kilowhat-custom-paths              | 1.9.0   |        |
| katosdev-signature                 | 1.6     |        |
| katosdev-automore                  | 1.0     |        |
| justoverclock-welcomebox           | 2.0.2   |        |
| justoverclock-staff-members-widget | 0.1.3   |        |
| justoverclock-og-meta-tag          | 0.1.0   |        |
| justoverclock-guestengagement      | 1.0.3   |        |
| justoverclock-custom-html-widget   | 0.1.4   |        |
| justoverclock-contactme            | 0.2.3   |        |
| ianm-synopsis                      | 1.3.2   |        |
| ianm-log-viewer                    | 0.1.1   |        |
| fof-username-request               | 1.2.4   |        |
| fof-user-directory                 | 1.3.3   |        |
| fof-user-bio                       | 1.3.2   |        |
| fof-upload                         | 1.5.4   |        |
| fof-terms                          | 1.3.1   |        |
| fof-split                          | 1.1.1   |        |
| fof-sitemap                        | 2.2.1   |        |
| fof-share-social                   | 1.2.0   |        |
| fof-profile-image-crop             | 1.1.6   |        |
| fof-pretty-mail                    | 1.1.2   |        |
| fof-oauth                          | 1.6.9   |        |
| fof-nightmode                      | 1.5.3   |        |
| fof-moderator-notes                | 1.2.2   |        |
| fof-merge-discussions              | 1.4.1   |        |
| fof-links                          | 1.2.3   |        |
| fof-geoip                          | 1.4.2   |        |
| fof-formatting                     | 1.0.3   |        |
| fof-follow-tags                    | 1.2.2   |        |
| fof-drafts                         | 1.2.10  |        |
| fof-doorman                        | 1.1.5   |        |
| fof-disposable-emails              | 1.0.0   |        |
| fof-direct-links                   | 1.0.0   |        |
| fof-custom-footer                  | 1.1.2   |        |
| fof-analytics                      | 1.1.0   |        |
| flarumite-simple-discussion-views  | 1.2.2   |        |
| flarum-statistics                  | v1.8.0  |        |
| flarum-pusher                      | v1.8.0  |        |
| flarum-lang-english                | v1.8.0  |        |
| flarum-extension-manager           | v1.0.3  |        |
| flarum-emoji                       | v1.8.0  |        |
| flarum-bbcode                      | v1.8.0  |        |
| davwheat-share                     | v1.1.0  |        |
| davwheat-custom-sidenav-links      | 1.0.1   |        |
| datitisev-backup                   | 1.1.0   |        |
| club-1-cross-references            | v1.1.1  |        |
| clarkwinkelmann-post-permissions   | 1.0.0   |        |
| clarkwinkelmann-mass-actions       | 1.1.2   |        |
| clarkwinkelmann-mailing            | 1.1.0   |        |
| clarkwinkelmann-likes-received     | 1.0.2   |        |
| clarkwinkelmann-group-list         | 1.0.0   |        |
| clarkwinkelmann-emojionearea       | 1.0.0   |        |
| clarkwinkelmann-circle-groups      | 1.0.1   |        |
| blomstra-turnstile                 | 0.1.4   |        |
| blomstra-secondary-tags-toggler    | 0.2.3   |        |
| blomstra-fontawesome               | 0.1.5   |        |
| askvortsov-rich-text               | v2.1.7  |        |
| askvortsov-pwa                     | v3.4.0  |        |
| askvortsov-markdown-tables         | v1.2.1  |        |
| askvortsov-discussion-templates    | v0.8.3  |        |
| askvortsov-checklist               | v1.3.1  |        |
| alexanderomara-gravatar            | 1.5.0   |        |
| afrux-news-widget                  | v0.1.1  |        |
| acpl-mobile-tab                    | 1.4.3   |        |
+------------------------------------+---------+--------+
Base URL: https://atlticket.exchange
Installation path: /home/treyb/atlticket.com
Queue driver: sync
Session driver: file
Scheduler status: Active
Mail driver: mail
Debug mode: ON

Edit: I have also removed all custom CSS, custom Header, and Footer with no luck.

datitisev

treyb Hm. Nothing jumps out at me. Those errors look like they occur on page load or some other unrelated event.

treyb

datitisev Same, I have been disabled every extension and still nothing.

Edit: I have also tried using Edge and it didn't work either.

treyb

treyb Tried on a fresh install, and still same problem

Flarum core: 1.8.5
PHP version: 8.3.6
MySQL version: 10.6.18-MariaDB-log
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, readline, Reflection, SPL, session, standard, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, ldap, exif, mysqlnd, odbc, PDO, pgsql, Phar, posix, pspell, shmop, SimpleXML, snmp, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, xmlreader, monarxprotect, imagick, sodium, Zend OPcache
+----------------------+---------+--------+
| Flarum Extensions    |         |        |
+----------------------+---------+--------+
| ID                   | Version | Commit |
+----------------------+---------+--------+
| flarum-flags         | v1.8.0  |        |
| flarum-suspend       | v1.8.1  |        |
| flarum-approval      | v1.8.1  |        |
| flarum-tags          | v1.8.0  |        |
| fof-user-bio         | 1.3.2   |        |
| flarum-subscriptions | v1.8.0  |        |
| flarum-sticky        | v1.8.0  |        |
| flarum-statistics    | v1.8.0  |        |
| flarum-mentions      | v1.8.3  |        |
| flarum-markdown      | v1.8.0  |        |
| flarum-lock          | v1.8.0  |        |
| flarum-likes         | v1.8.0  |        |
| flarum-lang-english  | v1.8.0  |        |
| flarum-emoji         | v1.8.0  |        |
| flarum-bbcode        | v1.8.0  |        |
| blomstra-fontawesome | 0.1.5   |        |
+----------------------+---------+--------+
Queue driver: sync
Session driver: file
Mail driver: mail
Debug mode: off

nxmndr

Hi. It is not clear for the average user that Shift+Enter is the way to line return. I suggest adopting standard behavior of

Enter to line return
Button to save

That would make clear it for everybody.

datitisev

treyb Ah, it seems like it doesn't work on the user card. It works in the profile page.

treyb

datitisev yep, that’s it. Works fine on profile.

datitisev

treyb So it seems like this is because Post prevents unnecessary redraws by only updating when specific things change ( flarum/frameworkblob/873db6e0/framework/core/js/src/forum/components/Post.tsx#L38-L45 ). I don't know why this isn't an issue on Discuss though, since the flarum/core changes were made years ago and it is on the latest fof/user-bio version...

I think a good solution, instead of managing to keep track of whether to redraw the textarea for user input, would be to just allow updating the bio in the user profile & add save/cancel buttons for better accessibility. It gets rid of some functionality (which doesn't seem to be functioning properly since ?? anyways) but that's probably for the best (can't update profile pic from the user card!)

« Previous Page Next Page »