FriendsOfFlarum User Bio

nxmndr

Hi. It is not clear for the average user that Shift+Enter is the way to line return. I suggest adopting standard behavior of

Enter to line return
Button to save

That would make clear it for everybody.

treyb

treyb Tried on a fresh install, and still same problem

Flarum core: 1.8.5
PHP version: 8.3.6
MySQL version: 10.6.18-MariaDB-log
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, readline, Reflection, SPL, session, standard, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, ldap, exif, mysqlnd, odbc, PDO, pgsql, Phar, posix, pspell, shmop, SimpleXML, snmp, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, xmlreader, monarxprotect, imagick, sodium, Zend OPcache
+----------------------+---------+--------+
| Flarum Extensions    |         |        |
+----------------------+---------+--------+
| ID                   | Version | Commit |
+----------------------+---------+--------+
| flarum-flags         | v1.8.0  |        |
| flarum-suspend       | v1.8.1  |        |
| flarum-approval      | v1.8.1  |        |
| flarum-tags          | v1.8.0  |        |
| fof-user-bio         | 1.3.2   |        |
| flarum-subscriptions | v1.8.0  |        |
| flarum-sticky        | v1.8.0  |        |
| flarum-statistics    | v1.8.0  |        |
| flarum-mentions      | v1.8.3  |        |
| flarum-markdown      | v1.8.0  |        |
| flarum-lock          | v1.8.0  |        |
| flarum-likes         | v1.8.0  |        |
| flarum-lang-english  | v1.8.0  |        |
| flarum-emoji         | v1.8.0  |        |
| flarum-bbcode        | v1.8.0  |        |
| blomstra-fontawesome | 0.1.5   |        |
+----------------------+---------+--------+
Queue driver: sync
Session driver: file
Mail driver: mail
Debug mode: off

datitisev

treyb Ah, it seems like it doesn't work on the user card. It works in the profile page.

treyb

datitisev yep, that’s it. Works fine on profile.

datitisev

treyb So it seems like this is because Post prevents unnecessary redraws by only updating when specific things change ( flarum/frameworkblob/873db6e0/framework/core/js/src/forum/components/Post.tsx#L38-L45 ). I don't know why this isn't an issue on Discuss though, since the flarum/core changes were made years ago and it is on the latest fof/user-bio version...

I think a good solution, instead of managing to keep track of whether to redraw the textarea for user input, would be to just allow updating the bio in the user profile & add save/cancel buttons for better accessibility. It gets rid of some functionality (which doesn't seem to be functioning properly since ?? anyways) but that's probably for the best (can't update profile pic from the user card!)

datitisev

@treyb I've made a PR FriendsOfFlarum/user-bio58 (mainly didn't feel like publishing it right now, pretty sure it's good to go out though). I welcome any thoughts -- if you want to try it out, composer require fof/user-bio:dev-ds/ux-improvements

treyb

datitisev Thank you.

I have upgraded, and it looks good and is working fine. The option to edit "inline" on the user card has been removed, and the save / cancel appear with no issues on the profile page.

Only recommendation I have, would be to maybe to add the dashed line around the user's bio (visible to the account owner at all times, and not just on hover) to point out that it can be edited.

datitisev

treyb I added a faint border that gets clearer on hover. I didn't think a constant border (even though it was faint already) would look great.

I also noticed that, because one can use formatting in the bio, the functionality I added for where the cursor starts after you click will not necessarily line up with the text you clicked on. Sadly, there's not much that can be done about that without adding extra complicated logic - and I thought having it like this might be better than starting at the end every time.

treyb

datitisev that makes sense! thank you for the changes!!

datitisev

1.4.0

Disable editing on user card hover
- Did not work in a discussion page, causing confusion
- Maintains core logic of only editing (eg. profile picture) in user page
Add save/cancel buttons when editing bio
- Removed enter & click outside events from causing you to save
Clicking on bio will put your cursor near where you clicked when it becomes editable
- Depends on how much custom formatting there is - for plain text with no extra whitespace, should be identical
- eg. clicking before "the" in "hello there" will put your cursor there once it becomes editable
Accessibility improvements
- Allow keyboard navigation to select bio
- Allow keyboard navigation to trigger edit bio

peopleinside

Hi, I'm looking for a way to force all users links in all bio to open in a new tab.
Could you help me to understand how I can do?
User bio is not supporting this, how can I implement it?

I tried to put in the footer a script but is not correctly and fully working with user bio extension

<!-- Open external link in a new tab -->
<script>
window.addEventListener("DOMContentLoaded", function externalLinks() {
  var anchors = document.getElementsByTagName("a");
  for (var i = 0; i < anchors.length; i++) {
    if (anchors[i].hostname !== window.location.hostname) {
      anchors[i].setAttribute("target", "_blank");
      anchors[i].setAttribute("rel", "noopener");
    }
  }
});
</script>

Maybe I should insert this script in the extension?
I need some help to resolve links opened in the same window.

I have the SEO extension but doesn't work for external link in a new tab for user bio.

Subarist

peopleinside
It's not the officially recommended method, but you can try the following.

/www/wwwroot/flarum/vendor/fof/user-bio/js/dist/forum.js

Find: .autoLink({rel:"nofollow ugc"}

Add target:: .autoLink({rel:"nofollow ugc",target:"_blank"}

Then run: php flarum cache:clear

peopleinside

Subarist
thank you very much, it works!

I will just have the issue that I will loose the change on every update so if I forget, links still return to open on the same window... in any case is one step and was what I was looking for.

I hope user bio extension can add an option in the back end to enable this or can exist a way to set an override for this that get not lost with the update.

Thank you so much! 🩷
You was very kind to take some time to find how to resolve and share a fix to me, also if it's not permanent was what I spent time to try to do.

luceos

This is untested, add this between [ and ] in your extend.php next to the config.php; make a backup of the extend.php in case you make any mistakes.


    (new \FoF\UserBio\Extend\Formatter)
        ->configure(function (\s9e\TextFormatter\Configurator $configurator) {
            $dom = $configurator->tags['URL']->template->asDOM();

            foreach ($dom->getElementsByTagName('a') as $a) {
                $a->setAttribute('target', '_blank');

                $rel = $a->getAttribute('rel');
                $a->setAttribute('rel', "$rel noopener");
            }

            $dom->saveChanges();
        }),

Based on: franzliedke/flarum-open-links-in-new-tabblob/master/extend.php and FriendsOfFlarum/user-bioblob/master/src/Extend/Formatter.php

peopleinside

Thank you luceos, but unfortunately this seems is NOT working 😐
I hope in the future a way to keep this setting / edit without loose it with updates.

For the temporary edit to improve security in

/www/wwwroot/flarum/vendor/fof/user-bio/js/dist/forum.js

Find: .autoLink({rel:"nofollow ugc"})

and change to:

.autoLink({rel:"nofollow ugc noreferrer noopener", target:"_blank"})

I hope in the future maybe a settings can let admin decide if open links in the same window or in new tab.
The fix found here is temporary and will be lost when user bio is updated.

peopleinside

I see a new user bio version has been released... this will means I will loose edits to the core extension to have links in the bio opened in a new tab. I hope a fix can be implemented to be able to set links to open in a new tab in the extension settings.

I don't like external link let user loose the current page and the extension SEO doesn't works for link in user bio.

IanM

peopleinside sorry, what?

Yes I have tagged a new release, and will be announcing it once some other prep work is complete. You do not have to update yet, at least wait until the announcement informing you of what has changed!

peopleinside

IanM
I have the issue that discovered in user bio all links user insert are not opened in a new tab.

For have links opened in a new tab I need edit the core user bio code but on every update I loose this edits.
I hope in a solution as SEO for Flarum is opening external links in a new tab everywhere except user-bio.

Ok I will wait to update user-bio thanks.

luceos

IanM Marco means he is editing specific files in vendor for user-bio so that all links his users place in the user bio are opened in a new tab. The new version to him, thus, is a burden, because he needs to edit the same javascript files and recompile. He is hoping that such a feature is added to user bio at some point.

IanM

peopleinside 1.4.2 now has this functionality by default for you 🙂

IanM

1.4.1 What's Changed

chore: prep for flarum/gdpr by @IanM in FriendsOfFlarum/user-bio60

Full Changelog: FriendsOfFlarum/user-bio1.4.0 → 1.4.1

1.4.2 What's Changed

feat: open bio links in new tab, add nofollow and ugc by @IanM in FriendsOfFlarum/user-bio61

Full Changelog: FriendsOfFlarum/user-bio1.4.1 → 1.4.2

« Previous Page