FriendsOfFlarum Webhooks

ctml

@datitisev could it be related to his column prefix? Just spitballing ideas.

czayorijinal

ctml Like having fl_tags instead of tags?

datitisev

ctml czayorijinal The prefix shouldn't be an issue. You can see the error message mentions fl_tags, so it's applying the prefix. I can't think of what the issue could be.

datitisev

1.0.3

1.0.2 Add Debug switch to help debug issues with webhooks (logs to Flarum log file)
Remove tag foreign key from existing migration
- Should resolve some problems with installations
- Stops having flarum/tags as a "required" dependency (needed to have been installed & enabled in the past)

Amarok

Is it possible to make @discordrank to notifi only one discord rank or not ? I tried adding it in the text field but seams not working :S

datitisev

Amarok How did you try implementing the mention? Usually mentions have to be done with IDs.

Make sure you have Developer Mode enabled (App Settings > Advanced).
Go to the Discord Server Settings > Roles, right click the role & select "Copy ID".
Then, in the additional text field, write <@&ID>, replacing ID with the ID you copied.

Amarok

datitisev Thx ! Works like a charm 🥰

AdamXweb

I seem to be running into an issue with webhooks enabled.

After clicking submit on a post, an error occurs at the bottom left, then if the page is refreshed, the post will display, however the discussion doesn't link to first_post_id in the database

I should note:
Flarum core 1.0.4
PHP 8.0.8
Webhooks 1.0.3

Logs:

[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: queuing  
[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: handling with FoF\Webhooks\Actions\Post\Posted  
[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: webhook 1 --> invalid URL / ignored event  
[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: webhook 2 --> not subscribed  
[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: webhook 3 --> not subscribed  
[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: webhook 4 --> not subscribed  
[2021-07-28 01:58:29] flarum.DEBUG: [fof/webhooks] Flarum\Discussion\Event\Started: queuing  
[2021-07-28 01:58:29] flarum.ERROR: Exception: Serialization of 'Closure' is not allowed in /var/www/flarum/vendor/illuminate/queue/Queue.php:158
Stack trace:
#0 /var/www/flarum/vendor/illuminate/queue/Queue.php(158): serialize()
#1 /var/www/flarum/vendor/illuminate/queue/Queue.php(127): Illuminate\Queue\Queue->createObjectPayload()
#2 /var/www/flarum/vendor/illuminate/queue/Queue.php(105): Illuminate\Queue\Queue->createPayloadArray()
#3 /var/www/flarum/vendor/illuminate/queue/SyncQueue.php(38): Illuminate\Queue\Queue->createPayload()
#4 /var/www/flarum/vendor/fof/webhooks/src/Listener/TriggerListener.php(90): Illuminate\Queue\SyncQueue->push()
#5 /var/www/flarum/vendor/illuminate/events/Dispatcher.php(389): FoF\Webhooks\Listener\TriggerListener->run()
#6 /var/www/flarum/vendor/illuminate/events/Dispatcher.php(237): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}()
#7 /var/www/flarum/vendor/flarum/core/src/Foundation/DispatchEventsTrait.php(33): Illuminate\Events\Dispatcher->dispatch()
#8 /var/www/flarum/vendor/flarum/core/src/Discussion/Command/StartDiscussionHandler.php(97): Flarum\Discussion\Command\StartDiscussionHandler->dispatchEventsFor()
#9 /var/www/flarum/vendor/illuminate/bus/Dispatcher.php(122): Flarum\Discussion\Command\StartDiscussionHandler->handle()
#10 /var/www/flarum/vendor/illuminate/pipeline/Pipeline.php(128): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}()
#11 /var/www/flarum/vendor/illuminate/pipeline/Pipeline.php(103): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#12 /var/www/flarum/vendor/illuminate/bus/Dispatcher.php(132): Illuminate\Pipeline\Pipeline->then()
#13 /var/www/flarum/vendor/illuminate/bus/Dispatcher.php(78): Illuminate\Bus\Dispatcher->dispatchNow()
#14 /var/www/flarum/vendor/flarum/core/src/Api/Controller/CreateDiscussionController.php(61): Illuminate\Bus\Dispatcher->dispatch()
#15 /var/www/flarum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(110): Flarum\Api\Controller\CreateDiscussionController->data()
#16 /var/www/flarum/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(22): Flarum\Api\Controller\AbstractSerializeController->handle()
#17 /var/www/flarum/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractCreateController->handle()
#18 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#19 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ExecuteRoute->process()
#20 /var/www/flarum/vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle()
#21 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Api\Middleware\ThrottleApi->process()
#22 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(44): Laminas\Stratigility\Next->handle()
#23 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\CheckCsrfToken->process()
#24 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle()
#25 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ResolveRoute->process()
#26 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#27 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\SetLocale->process()
#28 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(56): Laminas\Stratigility\Next->handle()
#29 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithHeader->process()
#30 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle()
#31 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithSession->process()
#32 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle()
#33 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\RememberFromCookie->process()
#34 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#35 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\StartSession->process()
#36 /var/www/flarum/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle()
#37 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Api\Middleware\FakeHttpMethods->process()
#38 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#39 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ParseJsonBody->process()
#40 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#41 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\HandleErrors->process()
#42 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle()
#43 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\InjectActorReference->process()
#44 /var/www/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(76): Laminas\Stratigility\Next->handle()
#45 /var/www/flarum/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#46 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\RequestHandler->process()
#47 /var/www/flarum/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle()
#48 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\BasePathRouter->process()
#49 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle()
#50 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Laminas\Stratigility\Middleware\OriginalMessages->process()
#51 /var/www/flarum/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle()
#52 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\BasePath->process()
#53 /var/www/flarum/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle()
#54 /var/www/flarum/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ProcessIp->process()
#55 /var/www/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(76): Laminas\Stratigility\Next->handle()
#56 /var/www/flarum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(65): Laminas\Stratigility\MiddlewarePipe->process()
#57 /var/www/flarum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle()
#58 /var/www/flarum/vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#59 /var/www/flarum/public/index.php(26): Flarum\Http\Server->listen()
#60 {main}

ctml

AdamXweb it's a known issue right now, unfortunately very difficult to track down. If you can add any info, such as extensions installed you can add your notes here to hopefully help.

FriendsOfFlarum/webhooks37

Amarok

Don't work if FoF Follow Tags is activated for me 😉
just an incompatible extension

ctml

Amarok what's the error you see? Is it the serialization error that a bunch of us are having an issue with?

datitisev

ctml @EvilExecutor tested it locally and figured out Follow Tags is the culprit, or at least one of them. Thanks to him I can finally reproduce the bug locally ❤️.

ctml

datitisev oh my lord 🙏 so thankful for you both... that's amazing. Webhooks is pretty critical for me, I had to disable it for the last little while but will be great to have it back.

datitisev

1.0.4

Fix issues regarding serialization of Closures (FriendsOfFlarum/webhooks37)
- Use https://github.com/opis/closure to serialize the $event data
- Resolves incompatibility with fof/follow-tags and other extensions

cc @ctml, @Amarok, @AdamXweb

ctml

datitisev

This might have been one of the other issues I was having where webhooks were not posting. Debug output captured the below and screenshots of the webhook settings.

[2021-08-04 19:26:19] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: queuing  
[2021-08-04 19:26:19] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: handling with FoF\Webhooks\Actions\Post\Posted  
[2021-08-04 19:26:19] flarum.DEBUG: [fof/webhooks] Flarum\Post\Event\Posted: webhook 7 --> invalid URL / ignored event

ctml

ctml turns out the discussion that replies were posted on had no first_post_id set in the database. I think this may have been caused by the original issue fixed in 1.0.4, originally when the discussions were posted using the older version of webhooks the webhook failed due to the bug with follow-tags and during discussion creation the first_post_id wouldn't be set for those discussions. For any replies on the thread after webhook actions would be ignored, after I set the first_post_id manually for the handful of discussions webhooks began working. I guess the first_post_id doesn't get set because of an issue related to error handling in flarum core, the first_post_id should always be set if the discussion is created and first post is posted regardless of other failures that may occur (such as emails, webhooks, or anything else that may run during the discussion creation process)

Anyways, I hopefully should be all good now 🙂

datitisev

ctml Oh good point, yeah that could've broken that code. That makes sense now.

Justman10000

I would fix this so that every time you add a webhook, the webhook URL remains in the field:

ctml

Justman10000 after you add a webhook, if you want to add another using the same url you can just copy it, no? I don't think leaving the fields that are used for adding a new Webhook with the last added Webhook settings would be good UX. Unless I am misunderstanding you.

Akito

I have got this error

datitisev

Akito Hm interesting. This would be an error when sending the hook to Discord... try looking at the flarum log to see if there's anything more helpful there.

Justman10000

ctml

No, when you add a webhook, it stays in the field after the other is added! The webhook that is added is copied into the field in which you declare webhooks to be added ... And this should be removed so that the field is empty after you have added a webhook!

« Previous Page Next Page »