FriendsOfFlarum Pages

therealsujitk

This isn't a major bug but, this is how the Pages panel looks in dark mode:

datitisev

therealsujitk I don't see any issue 😇. Please make an issue on GitHub so we can keep track of it 🙂.

Ralkage

therealsujitk do you have the Night Mode extension installed by any chance? 🤔

therealsujitk

datitisev I don't see any issue 😇.

You mean you aren't getting the same issue?

datitisev Please make an issue on GitHub so we can keep track of it 🙂.

Sure, I'll do this tomorrow. Btw, this issue is using beta.13 Dark Mode and not the fof extension.

datitisev

r4nchy You can change the CSS to remove the padding. I can't remember what element adds that space off the top of my head.

therealsujitk

Ralkage No, I'm using the built in dark mode. It is the admin panel, so the extension doesn't work there anyway.

datitisev

therealsujitk You mean you aren't getting the same issue?

Sorry, it was a joke - was supposed to read as me not seeing any issue in the screenshot you posted.

therealsujitk

datitisev oh lol 😅.. I'm dumb.

Artuu

@datitisev I discovered two bugs. Below I send you a link to the video where I present them.

I will describe here quickly what is on the film.
Before showing the bug I refreshed the page.
On the first tab of the browser I show what are the pages (slug, name, etc), on the second tab I show the first bug, and on the third tab I show the second bug.

https://youtu.be/TEInlSW7zPc

EDIT: I think the error lies with js, but I'm not sure.

EDIT: I think the whole problem lies here.
I added console.log() command and returned me this.

Artuu

Artuu I'm presenting a sample solution, you can use it unless you have a better idea. I hope I helped 😺

  id() {
    const id = m.route.param("id").split("-")[0];
    if (!isNaN(id)) {
      return id;
    } else {
      return m.route.param("id");
    }
  }

datitisev

Artuu Oooh, interesting. So it's taking only the first item when split by -, even if its not an ID. Good catch.

Artuu

datitisev Exactly, and with this conditional expression it checks that the first item when split by - is a number and returns the slug or id.

Artuu

datitisev Could you update the extension to correct this error?

Artuu

datitisev I created a pull request with a commit to fix this bug.

patron79

Hi,
where can I find the page templates? I would like to change the meta data.

Thank you for your help.

clarkwinkelmann

patron79 this extension only lets you customize the body of the additional pages you create.

If you want to create more advanced pages, you should probably use Flarum's extension API and register custom pages that way.

If you're trying to customize the head meta tags for the whole forum and it's not something that's already in the admin panel, here's a discussion that explains how you might want to do it https://discuss.flarum.org/d/20162-how-to-add-to-head-head

patron79

clarkwinkelmann
Thank you for the Information.

sburkett

Question: If I set a page to be the "home" page for the site .... what URL would I use to send the user to the actual discussions at that point? The settings.default_route is used in the ForumServiceProvider. And that value is now a route to a custom page.

The use-case here is that I have a private, invite-only forum. So I want random visitors to see a custom page telling them what we're about, etc., but not to see any actual discussions, etc.

I'm guessing I could possibly use extend.php to override the default "forum" route, but I'm still getting used to the architecture of Flarum.

Thanks in advance!

datitisev

sburkett The discussions route is /all, I think.

sburkett

datitisev Yep, that works. Thanks!

« Previous Page Next Page »