I suppose Packagist accepts non-semver-compilant versions.

If we read the semver spec, 0.4-beta is not a valid version https://semver.org/

A normal version number MUST take the form X.Y.Z

But because it's a valid version in Packagist, I think the correct approach here would be for Admin Dashboard to use Composer's normalize() function https://github.com/composer/semver/blob/master/src/VersionParser.php#L102 on the version before using it as semver.

    clarkwinkelmann It definitely should not fail hard when it finds one invalid version. At worst case 0.4-beta and similar versions should be ignored.

    I've already implemented finding last version for my Weblate initiative (based on list of tags from Github/Gitlab, but it should work with Packagist data too), you may want to take a look: https://github.com/rob006-software/flarum-translations-builder/blob/60946656b1b63ffd3e89bd6c41c3353a34568eef/components/extensions/ExtensionsRepository.php#L270-L312

      I have a tiny issue with your addon, it is complaining about the sitemap addon. I do have the fof Sitemap addon installed, enabled, and the Sitemap is there, but it still thinks that I have not set it up. I have tried reinstalling both addons, but the issue does not go away. Is there a way you could help me with this?

      Thank you!

        TommyTran732 Looks like the extension is looking for the flagrow-sitemap ID. When you installed flagrow/sitemap, I assume it installed the fof version as the GitHub repository was transferred, so Packagist is retrieving the FriendsOfFlarum repository now.

            So currently if you share the post it's preview image does not tell anything about it because every post has the same uploaded image from this extension. Because of this a lot of people would not click the post and advertising is also harder or almost impossible (sadly images really makes that big of a difference). So I was hoping there could be added a option where we could change the social media image for specific post. So a system where you could upload or put a image url in some additional setting window at each post would help a lot. this would then update the meta tags for that post with new image. And so the post sharing would become so much more functionally.

            • S4mo replied to this.

              datitisev Hi!, I am facing the same issue, the fof sitemap isnt being picked up and is showing me the same error.
              Irregardless, love this plugin so much!

                Update 1.2

                This release brings you keywords support for the home page. Also, the extension now supports the current version of fof/best-answer and fof/sitemap.

                How to update?

                To update, run:

                composer update v17development/flarum-seo

                To install, run:

                composer require v17development/flarum-seo

                Then check in the admin dashboard if version 1.2 is installed. And add your forum keywords! 🙂

                Changelog:

                • Added forum keywords support
                • Added support for fof/best-answer, thanks to v17development/flarum-seo26
                • Added site og:type property and added og:url property to home page
                • Added missingog:title to tag page
                • Updated Canonical URL for profiles and added profile:username property
                • Replaced Zend namespace with Laminas
                • Removed support for flagrow/sitemap and moved to fof/sitemap
                • Bumped minimal Flarum version to Beta 12

                The above update will fix the following issues of: TommyTran732 alfathso therealsujitk and implements some of Alshain feedback.

                          JasperVriends

                          during installation issues this

                          Using version ^1.2 for v17development/flarum-seo
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Generating autoload files
Carbon 1 is deprecated, see how to migrate to Carbon 2.
https://carbon.nesbot.com/docs/#api-carbon-2
    You can run './vendor/bin/upgrade-carbon' to get help in updating carbon and other frameworks and libraries that depend on it.
60 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

                              EvgeniySotnikov There's no issue there. Ignore the Carbon-related warning. The package has already been installed with a version matching 1.2, so composer did nothing.

                                  datitisev
                                  Thanks for the answer! But my installation ends here, the process breaks down and I can’t fully install. There are no errors, but it is not installed. what could be the reason or maybe there is some kind of solution?

                                      lets hope someone will add those features in upcoming builds 😄

                                      EvgeniySotnikov You can always try running composer remove v17development/flarum-seo and then run composer require v17development/flarum-seo again. Have you cleared the cache of your forum already? Maybe the extension appears after that. The last thing I could think of is you're running the composer require command in the wrong folder, have you doublechecked that?

                                      SezginYILDIRIM Can be interesting, do you want the name before the title or really remove it from the page title?